From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99B893822AB for ; Sat, 9 May 2026 21:47:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778363243; cv=none; b=CyWJc2/0rmXWU4/wcIPDy1sRpx/SDhgDJW7SaZXgXRAF/31yExMYq7Fmn5HHBkzoECigGzJkwhFW15NVvdYj1+YSwJKx3cpbBOEgQS7ftZPeexyDIk/929kqEtQVZS0+RKbXxiPOH07XxAeyQoeAODNWczDOuQZ+3F3iA+Ggxpg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778363243; c=relaxed/simple; bh=L7nbRIzbIN+BvCH7led9bntZ8t7xIfoW9DdhBmRjaUw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=I6kQvW7ct4VqP8lJ4OPyZXzHPcRFg6CZfKQW0KRf7CF1vYld6JaRPrwIZ7DFx1qVSy+Dmr5T7P+eU/w2SHMSktjOBNZsRQEbJHI7Hj23UXCOISNA1MAr4cs04gRRqdpVYYDgrEfvvKUsgYs8pLgkneCO+ePOr/MZU9GONqTulsQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=UhilQVM7; arc=none smtp.client-ip=209.85.210.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="UhilQVM7" Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-7dbca22dbfeso1860611a34.1 for ; Sat, 09 May 2026 14:47:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1778363234; x=1778968034; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VLsgqjiauXUHOOz4Y63xwmK3jjt7GtmWKwgselV/o2g=; b=UhilQVM7Ogcw4QZPFbdiQUAYxib3US7J7jRJiydcOs9PeGBLw21y0wxgWoejNp+bZK 7sH/PjVitHKwNiiUJWHmvFIyqcpFtbBxqZkhxnW3fI+bVDtQo6XW9V1zmodluHwcPmQn N4FOVjHH/OpSxZhivpXEKgRKi89tzxQw3wNYM0pgORYcdYVW1lzRUe2WnpPSfoPjG+2/ BM7crUn0/FiW03OC6gDOSvdtpWpZLLQAExHytk6Mdi4iQC79Nk1wa9ub8rfQNwe/leyJ kVc0htTZGgi5/w9naRR5LEdF8MwEGWK2lXj2XAlamMqnmHn+h4yAkFwMl+vjpPMKe5VK aKJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778363234; x=1778968034; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VLsgqjiauXUHOOz4Y63xwmK3jjt7GtmWKwgselV/o2g=; b=dVDc+DH8GcrruC3nX4Z/VXMhwq9GJHQTFlGrhhNbSMC2LMZySlF9NfVzeZyWCPFHxj CgmSh/JwfHIi1LrqEfp+I/ECyJTuiwRQBBlXgV9lTF2snJfISueze2gpnRIN1H0aCONo h35V0XUw9yWwvJBurFc7zCsTHcfSyEc/8BdSnXQjG9+LWZCUzozWXdO9JfF69nKymEVi 2bVwHAUbwKC53I4iGSqe3k8zejjROt4Tf1Gm5rQbRnbdwcXzv1GrBeJ5gWJpcsHlYxw/ 4wp/esJtrCn/KVO1uj6p1Nm0lO1kkF/N5+RG9BZTpoSr1FaS5kmmirk2UiAy3bIrglAu l+JQ== X-Forwarded-Encrypted: i=1; AFNElJ9bAgeUNwOMIgJK/UONlModpH2g/OiAXY5pL6PGpLdNdNgl2hqP1ExBuZKyl5iv2uHogk61Mb+LhpDXqXE=@vger.kernel.org X-Gm-Message-State: AOJu0YzDbFWjokWM/KWh204piuil2JCAXNJ/6yhu7hyqRRTfT6CDTVIU xf4ah9AiUTNNtODD51l3Z9/WWNJDYde/3D0aqyIgmPhh32xXm4U0fSnZ37cnTsVwpXk= X-Gm-Gg: Acq92OFR9o2QlV0hdHiSKgV7kM/5RHRcDG42pSa31idkEWFm/KRvdwZFeIZ502819Iz JKLVOfpfGV5SAdK6pP6Cnxl/Uk/Edc6STIgEDqHwu7xZFZhIuMlkCXi/4k7YeFzrtlT5yMyOZHG fptEkCQ1B8Yg79tICCDroEh+lVS/uEQHNceOG64uyHqE2fcesimlRsHU8eRtIAqK/7wehRHiLq7 GSVFu6LoMGQtYezqBxT21r9B4ReBjDvbtLk/xM8NZI+gin7WdMGYC0CULzNbB3+uQ87yP6CgLKN 243COvLXBzxzKLfRud91mRNmnwgTVzGhaoy3BpXSoqWFcm214xzFEhZNGQFvcPCcGjIvP1UVGQB KoifCW4bD6m0YNETBCOPPFGTOAkxp1AqhMIwGryv0tLJYYZ0dQ/wwag8rRli8+jYQ4nSvX9arpX CY4GVXG8ZzNV389gPDS+QKk4jE70+MGmk2ftZ1cAZuv61MyowmOtEVnQC/DIc7anb8mTrjfxFSC GoijZRKZoQj+bzGnZ9Z2Vg= X-Received: by 2002:a05:6830:4992:b0:7dc:4947:36a1 with SMTP id 46e09a7af769-7e1deed3d7bmr10846987a34.12.1778363234496; Sat, 09 May 2026 14:47:14 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:3548:c22e:ea52:dbc7? ([2600:8803:e7e4:500:3548:c22e:ea52:dbc7]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e367d4fe15sm3737018a34.18.2026.05.09.14.47.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 May 2026 14:47:14 -0700 (PDT) Message-ID: Date: Sat, 9 May 2026 16:47:12 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iio: chemical: scd30: Prevent potential divide-by-zero error To: Maxwell Doose Cc: jic23@kernel.org, Tomasz Duszynski , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , "open list:IIO SUBSYSTEM AND DRIVERS" , open list References: <20260509211921.84969-1-m32285159@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 5/9/26 4:36 PM, Maxwell Doose wrote: > On Sat, May 9, 2026 at 4:25 PM David Lechner wrote: >> >> On 5/9/26 4:19 PM, Maxwell Doose wrote: >>> In scd30_read_raw, the current value of tmp in the >>> IIO_CHAN_INFO_SAMP_FREQ case is unchecked. Add checking to see if the >>> value we got was 0 to prevent a divide-by-zero error. >>> >>> Fixes: 64b3d8b1b0f5 ("iio: chemical: scd30: add core driver") >>> Signed-off-by: Maxwell Doose >>> --- >>> drivers/iio/chemical/scd30_core.c | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/drivers/iio/chemical/scd30_core.c b/drivers/iio/chemical/scd30_core.c >>> index be8c055be184..3e2bb6f4e42c 100644 >>> --- a/drivers/iio/chemical/scd30_core.c >>> +++ b/drivers/iio/chemical/scd30_core.c >>> @@ -237,6 +237,13 @@ static int scd30_read_raw(struct iio_dev *indio_dev, struct iio_chan_spec const >>> if (ret) >>> return ret; >>> >>> + /* Likely only taken if something really strange happens */ >> >> Instead of saying "strange" I would mention a possible hardware failure >> to justify the EIO return. I'm assuming this is reading the value over >> SPI or I2C? >> > > Yes, we're reading over either SPI or I2C, the sensor supports both. > Hardware failure is going to be the most likely cause of this path > being taken, but I could also see some sort of noise on the bus being > the cause. Perhaps we change it to: > > /* Likely taken if hardware is failing or noise on bus */ > > best regards, > max Sounds OK. A more verbose alternative: /* * Value of 0 is unexpected, but could happen, e.g. due to * hardware failure. */