Re: [PATCH] tpm: fixes uninitialized allocated banks for IBM vtpm driver

Michal Suchánek
2019-07-04T15:32:35Z

On Thu, 4 Jul 2019 19:26:36 +0530
Sachin Sant <sachinp@linux.vnet.ibm.com> wrote:

> > On 04-Jul-2019, at 5:29 PM, Mimi Zohar <zohar@linux.ibm.com> wrote:
> >
> > On Wed, 2019-07-03 at 23:32 -0400, Nayna Jain wrote:
> >> The nr_allocated_banks and allocated banks are initialized as part of
> >> tpm_chip_register. Currently, this is done as part of auto startup
> >> function. However, some drivers, like the ibm vtpm driver, do not run
> >> auto startup during initialization. This results in uninitialized memory
> >> issue and causes a kernel panic during boot.
> >>
> >> This patch moves the pcr allocation outside the auto startup function
> >> into tpm_chip_register. This ensures that allocated banks are initialized
> >> in any case.
> >>
> >> Fixes: 879b589210a9 ("tpm: retrieve digest size of unknown algorithms with
> >> PCR read")
> >> Signed-off-by: Nayna Jain <nayna@linux.ibm.com>
> > Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
>
> Thanks for the fix. Kernel boots fine with this fix.
>
> Tested-by: Sachin Sant <sachinp@linux.vnet.ibm.com>
>

Tested-by: Michal Suchánek <msuchanek@suse.de>

Thanks

Michal