From: <Andrei.Simion@microchip.com>
To: <broonie@kernel.org>
Cc: <lgirdwood@gmail.com>, <claudiu.beznea@tuxon.dev>,
<Nicolas.Ferre@microchip.com>, <krzk+dt@kernel.org>,
<conor+dt@kernel.org>, <robh@kernel.org>,
<alexandre.belloni@bootlin.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<Mihai.Sain@microchip.com>
Subject: Re: [PATCH 1/6] regulator: mcp16502: Add supplier for regulators
Date: Fri, 2 Aug 2024 14:25:15 +0000 [thread overview]
Message-ID: <f318439f-b520-4b86-99a7-eb9a2e47525f@microchip.com> (raw)
In-Reply-To: <98f91a56-946c-4a40-b908-45f4c6c6d66e@sirena.org.uk>
> On Fri, Aug 02, 2024 at 11:44:28AM +0300, Andrei Simion wrote:
>> Based on the datasheet [1] (Block Diagram) PVIN[1-4] and LVIN
>> represent the input voltage supply for each BUCKs respective LDOs.
>> Update the driver to align with the datasheet [1].
>>
>> [1]: https://ww1.microchip.com/downloads/en/DeviceDoc/MCP16502-High-Performance-PMIC-for-SAMA5DX-SAM9X6-MPUs-Data-Sheet-DS20006275A.pdf
> I'd expect to see a matching update to the bindings.
In regulator.yaml exists .*-supply [1] which practically allows every
char sequence before -supply. In the binding microchip,mcp16502.yaml [2]
each node under the regulators includes all the rules/documentation
from regulator.yaml , so I supposed that it is unnecessary to add
in the binding of those new property.
What is your opinion? Let me know any thoughts.
[1] https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/regulator/regulator.yaml#L244
[2] https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bindings/regulator/microchip%2Cmcp16502.yaml#L39
Best Regards,
Andrei Simion
next prev parent reply other threads:[~2024-08-02 14:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 8:44 [PATCH 0/6] Add input voltage suppliers for PMIC MCP16502 regulators Andrei Simion
2024-08-02 8:44 ` [PATCH 1/6] regulator: mcp16502: Add supplier for regulators Andrei Simion
2024-08-02 12:56 ` Mark Brown
2024-08-02 14:25 ` Andrei.Simion [this message]
2024-08-02 17:58 ` Mark Brown
2024-08-05 12:43 ` Andrei.Simion
2024-08-07 7:35 ` Andrei.Simion
2024-08-08 9:43 ` Andrei.Simion
2024-08-08 11:52 ` Andrei.Simion
2024-08-02 8:44 ` [PATCH 2/6] ARM: dts: microchip: at91-sama7g5ek: Add reg_5v to supply PMIC nodes Andrei Simion
2024-08-02 8:44 ` [PATCH 3/6] ARM: dts: microchip: at91-sama7g54_curiosity: " Andrei Simion
2024-08-02 8:44 ` [PATCH 4/6] ARM: dts: microchip: at91-sama5d2_icp: " Andrei Simion
2024-08-02 8:44 ` [PATCH 5/6] ARM: dts: microchip: at91-sama5d27_wlsom1: " Andrei Simion
2024-08-02 8:44 ` [PATCH 6/6] ARM: dts: microchip: sama5d29_curiosity: " Andrei Simion
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f318439f-b520-4b86-99a7-eb9a2e47525f@microchip.com \
--to=andrei.simion@microchip.com \
--cc=Mihai.Sain@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox