Re: [PATCH 0/1] sphinx-build-wrapper: add support for skipping sphinx-build

[Akira Yokosawa <akiyks@gmail.com>]

On Sun, 21 Sep 2025 11:13:24 +0200, Mauro Carvalho Chehab wrote:
> Hi Jon,
> 
> This patch adds support for not running sphinx-build at the wrapper
> tool. It was requested by Akira, who wanted to be able to ignore
> Sphinx errors during latex build and still try to build PDF.

Thank you for trying to figure out my intention.
However, you failed to see the point.

> 
> This patch is against docs/build-script and applies after the 3 patch
> series I sent yesterday:
> 
>     https://lore.kernel.org/linux-doc/cover.1758361087.git.mchehab+huawei@kernel.org/
> 
> 
> While Akira's original intention is to have pdfdocs target depend on
> latexdocs, IMO, this is overkill, as probably only Akira and a couple
> of other developers might want to have such behavior.

I think it is only you who don't want such behavior.

> 
> See, after all changes, the makefile rule for *all* doc build targets
> is simple:
> 
>         $(Q)@$(srctree)/tools/docs/sphinx-pre-install --version-check
>         +$(Q)$(PYTHON3) $(BUILD_WRAPPER) $@ \
>                 --sphinxdirs="$(SPHINXDIRS)" $(RUSTDOC) \
>                 --builddir="$(BUILDDIR)" --deny-vf=$(FONTS_CONF_DENY_VF) \
>                 --theme=$(DOCS_THEME) --css=$(DOCS_CSS) --paper=$(PAPER)
> 
> After applying patch 1 from this series, it is really easy to replicate 
> "make -i" by writing a small script that does:
> 
> 	tools/docs/sphinx-pre-install --version-check	
> 	tools/docs/sphinx-build-wrapper latexdocs || echo "LaTeX build failed, but we'll try build PDF anyway"
> 	tools/docs/sphinx-build-wrapper -s pdfdocs
> 

Hello?

You are the one who is changing the way "make pdfdocs" behaves.
All I want is to restore the current behavior, without any need to
use such an ad-hoc script.

Sorry, but I think I have to NAK this.

Furthermore, your "cleanup" is obfuscating the very fact that "pdfdocs"
needs a successful "latexdocs" stage.

I believe Documentation/Makefile is the right place to describe it.

Good luck,
Akira