From: Pavel Skripkin <paskripkin@gmail.com>
To: yashi@spacecubics.com, wg@grandegger.com, mkl@pengutronix.de,
davem@davemloft.net, kuba@kernel.org, mailhol.vincent@wanadoo.fr
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+3bc1dce0cc0052d60fde@syzkaller.appspotmail.com
Subject: Re: [PATCH v3] can: mcba_usb: properly check endpoint type
Date: Wed, 23 Mar 2022 23:35:11 +0300 [thread overview]
Message-ID: <f35435f3-13bd-2985-bfdd-b693388e49a0@gmail.com> (raw)
In-Reply-To: <20220313100903.10868-1-paskripkin@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1471 bytes --]
On 3/13/22 13:09, Pavel Skripkin wrote:
> Syzbot reported warning in usb_submit_urb() which is caused by wrong
> endpoint type. We should check that in endpoint is actually present to
> prevent this warning
>
> Found pipes are now saved to struct mcba_priv and code uses them directly
> instead of making pipes in place.
>
> Fail log:
>
> usb 5-1: BOGUS urb xfer, pipe 3 != type 1
> WARNING: CPU: 1 PID: 49 at drivers/usb/core/urb.c:502 usb_submit_urb+0xed2/0x18a0 drivers/usb/core/urb.c:502
> Modules linked in:
> CPU: 1 PID: 49 Comm: kworker/1:2 Not tainted 5.17.0-rc6-syzkaller-00184-g38f80f42147f #0
> Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.14.0-2 04/01/2014
> Workqueue: usb_hub_wq hub_event
> RIP: 0010:usb_submit_urb+0xed2/0x18a0 drivers/usb/core/urb.c:502
> ...
> Call Trace:
> <TASK>
> mcba_usb_start drivers/net/can/usb/mcba_usb.c:662 [inline]
> mcba_usb_probe+0x8a3/0xc50 drivers/net/can/usb/mcba_usb.c:858
> usb_probe_interface+0x315/0x7f0 drivers/usb/core/driver.c:396
> call_driver_probe drivers/base/dd.c:517 [inline]
>
> Reported-and-tested-by: syzbot+3bc1dce0cc0052d60fde@syzkaller.appspotmail.com
> Fixes: 51f3baad7de9 ("can: mcba_usb: Add support for Microchip CAN BUS Analyzer")
> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
> Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
gentle ping. looks like this patch got somehow lost
With regards,
Pavel Skripkin
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
prev parent reply other threads:[~2022-03-23 20:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 18:53 [PATCH RFT] can: mcba_usb: properly check endpoint type Pavel Skripkin
2022-03-08 0:23 ` Vincent MAILHOL
2022-03-08 8:06 ` Pavel Skripkin
2022-03-09 2:58 ` Yasushi SHOJI
2022-03-13 9:41 ` Pavel Skripkin
2022-03-08 8:16 ` [PATCH v2] " Pavel Skripkin
2022-03-08 8:54 ` Vincent MAILHOL
2022-03-13 10:09 ` [PATCH v3] " Pavel Skripkin
2022-03-23 20:35 ` Pavel Skripkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f35435f3-13bd-2985-bfdd-b693388e49a0@gmail.com \
--to=paskripkin@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=syzbot+3bc1dce0cc0052d60fde@syzkaller.appspotmail.com \
--cc=wg@grandegger.com \
--cc=yashi@spacecubics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox