From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752710AbcF1UHj (ORCPT ); Tue, 28 Jun 2016 16:07:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37648 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752227AbcF1UHi (ORCPT ); Tue, 28 Jun 2016 16:07:38 -0400 Subject: Re: [PATCH] KVM: vmx: fix underflow in TSC deadline calculation To: yunhong jiang References: <1467096859-3143-1-git-send-email-wanpeng.li@hotmail.com> <20160628104547.4844fd2e@jnakajim-build> <640874638.2724253.1467136598812.JavaMail.zimbra@redhat.com> <20160628113414.18f637b5@jnakajim-build> Cc: Wanpeng Li , linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Wanpeng Li , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Yunhong Jiang From: Paolo Bonzini Message-ID: Date: Tue, 28 Jun 2016 22:07:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160628113414.18f637b5@jnakajim-build> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 28 Jun 2016 20:07:37 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/06/2016 20:34, yunhong jiang wrote: > Paolo, thanks for reply. > > Which race window you are talking about? Is it the > kvm_lapic_switch_to_hv_timer()? If yes, hope we will not forgot it once the > lapic timer is not pinned anymore in future. Yes, it's that one. This is a good point against using local_irq_save/restore. Paolo