From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751803AbeBUTjv (ORCPT ); Wed, 21 Feb 2018 14:39:51 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:53450 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751698AbeBUTjq (ORCPT ); Wed, 21 Feb 2018 14:39:46 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 7AE626019F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=clew@codeaurora.org Subject: Re: [PATCH] rpmsg: glink: Use spinlock in tx path To: Bjorn Andersson , Ohad Ben-Cohen , Arun Kumar Neelakantam , Srini Kandagatla Cc: linux-remoteproc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180213190404.25026-1-bjorn.andersson@linaro.org> From: Chris Lew Message-ID: Date: Wed, 21 Feb 2018 11:39:45 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180213190404.25026-1-bjorn.andersson@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey Bjorn, Minor issue with the glink patch. Thanks, Chris On 2/13/2018 11:04 AM, Bjorn Andersson wrote: [..] > @@ -288,15 +288,14 @@ static int qcom_glink_tx(struct qcom_glink *glink, > const void *data, size_t dlen, bool wait) > { > unsigned int tlen = hlen + dlen; > + unsigned long flags; > int ret; > > /* Reject packets that are too big */ > if (tlen >= glink->tx_pipe->length) > return -EINVAL; > > - ret = mutex_lock_interruptible(&glink->tx_lock); > - if (ret) > - return ret; > + spin_lock_irqsave(&glink->tx_lock, flags); > qcom_glink_tx will return an uninitialized ret value with removal of mutex_lock_interruptible. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project