From: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Subject: Re: [PATCH 00/18] media: rcar: Streams support
Date: Wed, 19 Feb 2025 16:41:24 +0200 [thread overview]
Message-ID: <f3795f3b-8d38-40cd-abcc-723b18d6dc70@ideasonboard.com> (raw)
In-Reply-To: <20250219142256.GA512344@ragnatech.se>
Hi,
On 19/02/2025 16:22, Niklas Söderlund wrote:
> Hi Tomi,
>
> I'm happy to see this, nice work.
>
> Unfortunately it does not apply to the media-tree. As this series is a
It should, if you apply the dependencies first. But one of the
dependencies from you is a bit old and that doesn't apply without some
conflicts resolved. So... Yes, doesn't apply =).
> mix of fixes and new features as well as covering multiple drivers. Do
> you think it would make sens to break out the fixes per driver which we
> could review and apply ASAP and the new features which we can review but
> need to wait until the dependencies are meet?
Yes. I think that's the RAW8 and RAW10 fixes. However, I can't test them
without streams and GMSL2, so...
> If the new features depends on stuff that is hard to upport, maybe just
> focus on the fixes to get them out of the way?
>
> On 2025-02-19 15:48:54 +0200, Tomi Valkeinen wrote:
>> Add streams support to Renesas rcar platform driver.
>>
>> The series attempts to keep compatibility with the current upstream.
>> However, in upstream there's some kind of custom multi-stream support
>> implemented to the rcar driver, which breaks at patch "media: rcar-csi2:
>> Simplify rcsi2_calc_mbps()".
>
> I would not worry about breaking the make shift multi-stream, it was
> based on our first attempt to allow streams for GMSL many years ago and
> it was bonkers ;-) As long as it don't break a single streams, even from
> subdevs that do not themself support streams I'm happy.
Alright. Then you're happy with this series. I hope =). I don't have
anything to test this with, and only the v4h board.
Tomi
next prev parent reply other threads:[~2025-02-19 14:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 13:48 [PATCH 00/18] media: rcar: Streams support Tomi Valkeinen
2025-02-19 13:48 ` [PATCH 01/18] media: rcar-vin: Add RCAR_GEN4 model value Tomi Valkeinen
2025-02-19 13:48 ` [PATCH 02/18] media: rcar-vin: Fix RAW8 Tomi Valkeinen
2025-02-19 13:48 ` [PATCH 03/18] media: rcar-vin: Fix RAW10 Tomi Valkeinen
2025-02-19 13:48 ` [PATCH 04/18] media: rcar-isp: Improve ISPPROCMODE_DT_PROC_MODE_VC Tomi Valkeinen
2025-02-19 13:48 ` [PATCH 05/18] media: rcar-isp: Move {enable|disable}_streams() calls Tomi Valkeinen
2025-02-19 13:49 ` [PATCH 06/18] media: rcar-csi2: " Tomi Valkeinen
2025-02-19 13:49 ` [PATCH 07/18] media: rcar-csi2: Fix typo Tomi Valkeinen
2025-02-19 14:24 ` Niklas Söderlund
2025-02-19 14:36 ` Tomi Valkeinen
2025-02-19 14:46 ` Niklas Söderlund
2025-02-19 14:50 ` Tomi Valkeinen
2025-02-19 13:49 ` [PATCH 08/18] media: rcar-csi2: Move rcar2_calc_mbps() Tomi Valkeinen
2025-02-19 13:49 ` [PATCH 09/18] media: rcar-csi2: Simplify rcsi2_calc_mbps() Tomi Valkeinen
2025-02-19 13:49 ` [PATCH 10/18] media: rcar-csi2: Optimize rcsi2_calc_mbps() Tomi Valkeinen
2025-02-19 13:49 ` [PATCH 11/18] media: rcar-csi2: Switch to Streams API Tomi Valkeinen
2025-02-19 13:49 ` [PATCH 12/18] media: rcar-isp: " Tomi Valkeinen
2025-02-19 13:49 ` [PATCH 13/18] media: rcar-csi2: Add .get_frame_desc op Tomi Valkeinen
2025-02-19 13:49 ` [PATCH 14/18] media: rcar-isp: Call get_frame_desc to find out VC & DT Tomi Valkeinen
2025-02-19 13:49 ` [PATCH 15/18] media: rcar-csi2: Add more stream support to rcsi2_calc_mbps() Tomi Valkeinen
2025-02-19 13:49 ` [PATCH 16/18] media: rcar-csi2: Call get_frame_desc to find out VC & DT (Gen3) Tomi Valkeinen
2025-02-19 13:49 ` [PATCH 17/18] media: rcar-csi2: Add full streams support Tomi Valkeinen
2025-02-19 13:49 ` [PATCH 18/18] media: rcar-isp: " Tomi Valkeinen
2025-02-19 14:22 ` [PATCH 00/18] media: rcar: Streams support Niklas Söderlund
2025-02-19 14:41 ` Tomi Valkeinen [this message]
2025-02-19 14:56 ` Niklas Söderlund
2025-02-19 15:00 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3795f3b-8d38-40cd-abcc-723b18d6dc70@ideasonboard.com \
--to=tomi.valkeinen+renesas@ideasonboard.com \
--cc=jacopo.mondi@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox