From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 839154C63; Mon, 8 Apr 2024 02:36:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712543780; cv=none; b=NpuTkN8yuYw8kQxnJCUIEMB7SMEVnvqP4bPmPvm9eW8OhnFNBQyqnabrmAC2jfF5aPLaXOSdpQnkKSKz5T30lhCiK8D8djod/ycv7gz0WHFGoltnsYwF19qboGsjfZWxFE5xm68phrPQBe3i7aT9j+E+ZnsVHLOzzTWclu3cyv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712543780; c=relaxed/simple; bh=Qy3aIcnw128COjcx5ZkLH7sn4aLCJPiOUq2u2hUN8ak=; h=Message-ID:Content-Type:MIME-Version:In-Reply-To:References: Subject:From:Cc:To:Date; b=vErE4Zl0xVk0g+uhLmYqvNKvPyoZAyQKDjRvPYbpcm30OaGku/b3KvZ8L1HPO6ait4BDj6ajXMhPwoByNj+ZniNUd18h4hX9x3hIYhlgPnpPzf29WY30lRNF9inbXGzLNoq//H3va6G80mvEcygjyZNPW5WzYE6lenohwBe2mf0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Nz2LHvRO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Nz2LHvRO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02506C433F1; Mon, 8 Apr 2024 02:36:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712543780; bh=Qy3aIcnw128COjcx5ZkLH7sn4aLCJPiOUq2u2hUN8ak=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=Nz2LHvRO5rSrzZFXLK8P17cotOVKV4gDgenEsN5Psrhybwr3VnT+68TR90mFzNfyc PA11WbLEBzLG8u2jFPqUHAo/VhCCsMPGrXnHKUKmfe/U8QjYUjRoqmOcWcJZICUnXN 816PfSnhKzyBk2qPxbWnSjwn0tbvAqwKjmWfA23quaAMXghyxyDCbZJi4xcCbFSsYq r+qtzRWOa6ZSXClsKzRC9/7qAAmbFbChkxQ+0G+FldL4sHdHz/QTrv9Et8RLPwRgie Y7/MLmVXy8zf/re14wDZoGbyF6Coxy3xPDZ0tjkXqq/5KVf1kLkjVIQbwqbqE+Fei6 9E3ByLd7ptUAQ== Message-ID: Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20240325184204.745706-4-sboyd@kernel.org> References: <20240325184204.745706-1-sboyd@kernel.org> <20240325184204.745706-4-sboyd@kernel.org> Subject: Re: [PATCH v2 3/5] clk: Initialize struct clk_core kref earlier From: Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, patches@lists.linux.dev, linux-arm-msm@vger.kernel.org, Douglas Anderson To: Michael Turquette , Stephen Boyd Date: Sun, 07 Apr 2024 19:36:17 -0700 User-Agent: alot/0.10 Quoting Stephen Boyd (2024-03-25 11:41:57) > Initialize this kref once we allocate memory for the struct clk_core so > that we can reuse the release function to free any memory associated > with the structure. This mostly consolidates code, but also clarifies > that the kref lifetime exists once the container structure (struct > clk_core) is allocated instead of leaving it in a half-baked state for > most of __clk_core_init(). >=20 > Reviewed-by: Douglas Anderson > Signed-off-by: Stephen Boyd > --- Applied to clk-fixes