From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753313AbdEJPQA (ORCPT ); Wed, 10 May 2017 11:16:00 -0400 Received: from mout.web.de ([212.227.15.14]:56532 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751267AbdEJPP7 (ORCPT ); Wed, 10 May 2017 11:15:59 -0400 Subject: [PATCH] tinydrm: mipi-dbi: Adjust buffer output in mipi_dbi_debugfs_command_show() To: dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Fengguang Wu , Joe Perches , =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= , Thierry Reding Cc: kernel-janitors@vger.kernel.org, LKML References: <2795b611-dfb9-eaf6-e04d-10e27ce96772@users.sourceforge.net> <7a6e57ed-7d71-78bc-706e-3a6a1eea3a23@tronnes.org> <1494354199.20782.5.camel@perches.com> From: SF Markus Elfring Message-ID: Date: Wed, 10 May 2017 17:15:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <1494354199.20782.5.camel@perches.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:fP+FEDm0X8G6qOkydkkds8kpqs6K5xBxx2tBmT4zeGUFa2zuPAZ 5iVoTwmGZMSTv1kPVebqT9Wqemqe8i3T6X6cB6v9fjX5BhJIgw7D3JnawWS4UsW/aUZaj02 Hy8WGweBkG6D03ar4XC7SPQl27BDsy6ZxLxk4B4RW7fX/XfPGdhoAcvsVZULTY68Ut8uCHq 8dfbGYpaFKKjjEHfgAmXw== X-UI-Out-Filterresults: notjunk:1;V01:K0:sJX36iqV08A=:GSNT7ToETqPftVcI+V7Gc9 y9pZ80DXvzHMPcLC7F/hKlCh4TlHpzHeiNXJhlntCxc3WNmT7v0kvEvqEH71RyiNXoNmRujSP ThzGqWv2aE5/qwLFqTM3xEC8IYWeJn2R9mNrMkYC2+0iFcBkgq85s4P4eNHtCVvRuGITlzaxE etlMkrfWe6gXjBlQ166mErTlPobjFl84JvUZXXE1Crn+33EB55TMOymLSSxn/w9yymsbp3Ns/ zcJa5YbOKw4fpIllHSRNiwggN1p/Tia1Ji30ZPqzAiE+R2/au0q0MbRsi9Dzc57YnUo9A0oCi CjpBtvOdsRW6x/6u5AOSkT6LjHGTivlIRNPzyRoGcweYbmZMZvTN43ROFOaF6EBxxLe8vFCp8 RJ3rY+j+bmgeVaoTxKb2PuhhAIp01B2M6WicqkSvywiuakDZBLThHbsqGFCE67lbWbZ9ImATn 8D6ceNbULI7LXYh+AMMmWU8II0N6Gvd8oqON+Wp8nVBNlt9ctZQdQtW89NKOGi3x74lM3lyEc qhYpILHYvNGClpZg8yxGqFXFFt2fiem4r4cMMwX3FcyDzZwKv+kFU+WMuhi0fryvZ9yIwsCCl o7DrdlXm8WPs3/KGIYjowvLNiQH2zRwXETJJfa401+KRNNMZIlXTcmRb/rf8cHWvozh8SU9kN K3YU5MTPHss/KYvKZ0QZbLcsgtw1dcuT3hZhHAK5mBY8Bg+yNKzLsnImB31znQZ7w1RrMllfO 0CDUvTmJSUjtLMduPlJladciTYLwTP/9fMFs0kIaCvXDEj50ixdasFSpc5v2KBUQFnQ895XMW vMv3xIt Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 10 May 2017 17:03:20 +0200 * Use a special format string specification for the desired output of the array "val" into a sequence. * Adjust two local variables accordingly. This refactoring supersedes the update suggestion "tinydrm: mipi-dbi: Use seq_putc() in mipi_dbi_debugfs_command_show()" from 2017-05-08. https://patchwork.kernel.org/patch/9716119/ Fixes: 02dd95fe316936269a52d6ccb971bb956412b40a ("drm/tinydrm: Add MIPI DBI support") Suggested-by: Joe Perches Signed-off-by: Markus Elfring --- drivers/gpu/drm/tinydrm/mipi-dbi.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/tinydrm/mipi-dbi.c b/drivers/gpu/drm/tinydrm/mipi-dbi.c index f4eb412f3604..2670259d1798 100644 --- a/drivers/gpu/drm/tinydrm/mipi-dbi.c +++ b/drivers/gpu/drm/tinydrm/mipi-dbi.c @@ -914,8 +914,7 @@ static int mipi_dbi_debugfs_command_show(struct seq_file *m, void *unused) { struct mipi_dbi *mipi = m->private; u8 cmd, val[4]; - size_t len, i; - int ret; + int len, ret; for (cmd = 0; cmd < 255; cmd++) { if (!mipi_dbi_command_is_read(mipi, cmd)) @@ -944,9 +943,7 @@ static int mipi_dbi_debugfs_command_show(struct seq_file *m, void *unused) continue; } - for (i = 0; i < len; i++) - seq_printf(m, "%02x", val[i]); - seq_puts(m, "\n"); + seq_printf(m, "%*phN\n", len, val); } return 0; -- 2.12.3