[PATCH v8 0/5] Add display support for stm32f769-disco board

[PATCH v8 0/5] Add display support for stm32f769-disco board

[Dario Binacchi]

The series adds display support for the stm32f769-disco board. It has been
tested on hardware revisions MB1225-B03 and MB1166-A09. This required
modifications to the nt35510 driver that have already been applied.

Changes in v8:
- Add Acked-by tag of Lee Jones
- Add Reviewed-by tag of Raphael Gallais-Pou
- Add Reviewed-by tag of Raphael Gallais-Pou
- Remove unit name from 'ltdc/port/endpoint@0' to fix the compiling
  warning:
  ../arch/arm/boot/dts/st/stm32f769-disco.dts:189.28-191.5: Warning
  (unit_address_vs_reg): /soc/display-controller@40016800/port/endpoint@0: node
  has a unit name, but no reg or ranges property
- Add Reviewed-by tag of Linus Walleij
- Add Reviewed-by tag of Raphael Gallais-Pou

Changes in v7:
- Replace .dts with .dtb in the Makefile

Changes in v6:
- Drop patches
  - [5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK
  - [7/8] drm/panel: nt35510: move hardwired parameters to configuration
  - [8/8] drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK
  because applied by the maintainer Linus Walleij

Changes in v5:
- Replace GPIOD_ASIS with GPIOD_OUT_HIGH in the call to devm_gpiod_get_optional().

Changes in v2:
- Add Acked-by tag of Conor Dooley
- Change the status of panel_backlight node to "disabled"
- Delete backlight property from panel0 node.
- Re-write the patch [8/8] "drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK"
  in the same style as the original driver.

Dario Binacchi (5):
  dt-bindings: mfd: stm32f7: Add binding definition for DSI
  ARM: dts: stm32: add DSI support on stm32f769
  ARM: dts: stm32: rename mmc_vcard to vcc-3v3 on stm32f769-disco
  ARM: dts: stm32: add display support on stm32f769-disco
  ARM: dts: add stm32f769-disco-mb1225-revb03-mb1166-reva09

 arch/arm/boot/dts/st/Makefile                 |  1 +
 ...f769-disco-mb1225-revb03-mb1166-reva09.dts | 18 +++++
 arch/arm/boot/dts/st/stm32f769-disco.dts      | 78 ++++++++++++++++++-
 arch/arm/boot/dts/st/stm32f769.dtsi           | 21 +++++
 include/dt-bindings/mfd/stm32f7-rcc.h         |  1 +
 5 files changed, 115 insertions(+), 4 deletions(-)
 create mode 100644 arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts
 create mode 100644 arch/arm/boot/dts/st/stm32f769.dtsi

-- 
2.43.0

[PATCH v8 1/5] dt-bindings: mfd: stm32f7: Add binding definition for DSI

[Dario Binacchi]

Add binding definition for MIPI DSI Host controller.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Acked-by: Lee Jones <lee@kernel.org>
Reviewed-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>

---

Changes in v8:
- Add Acked-by tag of Lee Jones
- Add Reviewed-by tag of Raphael Gallais-Pou

Changes in v2:
- Add Acked-by tag of Conor Dooley

 include/dt-bindings/mfd/stm32f7-rcc.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/dt-bindings/mfd/stm32f7-rcc.h b/include/dt-bindings/mfd/stm32f7-rcc.h
index 8d73a9c51e2b..a4e4f9271395 100644
--- a/include/dt-bindings/mfd/stm32f7-rcc.h
+++ b/include/dt-bindings/mfd/stm32f7-rcc.h
@@ -108,6 +108,7 @@
 #define STM32F7_RCC_APB2_SAI1		22
 #define STM32F7_RCC_APB2_SAI2		23
 #define STM32F7_RCC_APB2_LTDC		26
+#define STM32F7_RCC_APB2_DSI		27
 
 #define STM32F7_APB2_RESET(bit)	(STM32F7_RCC_APB2_##bit + (0x24 * 8))
 #define STM32F7_APB2_CLOCK(bit)	(STM32F7_RCC_APB2_##bit + 0xA0)
-- 
2.43.0

[PATCH v8 2/5] ARM: dts: stm32: add DSI support on stm32f769

[Dario Binacchi]

Add support for MIPI DSI Host controller. Since MIPI DSI is not
available on stm32f746, the patch adds the "stm32f769.dtsi" file
containing the dsi node inside.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

(no changes since v1)

 arch/arm/boot/dts/st/stm32f769.dtsi | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
 create mode 100644 arch/arm/boot/dts/st/stm32f769.dtsi

diff --git a/arch/arm/boot/dts/st/stm32f769.dtsi b/arch/arm/boot/dts/st/stm32f769.dtsi
new file mode 100644
index 000000000000..e09184f7079c
--- /dev/null
+++ b/arch/arm/boot/dts/st/stm32f769.dtsi
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2023 Dario Binacchi <dario.binacchi@amarulasolutions.com>
+ */
+
+#include "stm32f746.dtsi"
+
+/ {
+	soc {
+		dsi: dsi@40016c00 {
+			compatible = "st,stm32-dsi";
+			reg = <0x40016c00 0x800>;
+			interrupts = <98>;
+			clocks = <&rcc 1 CLK_F769_DSI>, <&clk_hse>;
+			clock-names = "pclk", "ref";
+			resets = <&rcc STM32F7_APB2_RESET(DSI)>;
+			reset-names = "apb";
+			status = "disabled";
+		};
+	};
+};
-- 
2.43.0

[PATCH v8 3/5] ARM: dts: stm32: rename mmc_vcard to vcc-3v3 on stm32f769-disco

[Dario Binacchi]

In the schematics of document UM2033, the power supply for the micro SD
card is the same 3v3 voltage that is used to power other devices on the
board. By generalizing the name of the voltage regulator, it can be
referenced by other nodes in the device tree without creating
misunderstandings.

This patch is preparatory for future developments.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Reviewed-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>

---

Changes in v8:
- Add Reviewed-by tag of Raphael Gallais-Pou

 arch/arm/boot/dts/st/stm32f769-disco.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/st/stm32f769-disco.dts b/arch/arm/boot/dts/st/stm32f769-disco.dts
index 5d12ae25b327..8632bd866272 100644
--- a/arch/arm/boot/dts/st/stm32f769-disco.dts
+++ b/arch/arm/boot/dts/st/stm32f769-disco.dts
@@ -92,9 +92,9 @@ usbotg_hs_phy: usb-phy {
 		clock-names = "main_clk";
 	};
 
-	mmc_vcard: mmc_vcard {
+	vcc_3v3: vcc_3v3 {
 		compatible = "regulator-fixed";
-		regulator-name = "mmc_vcard";
+		regulator-name = "vcc_3v3";
 		regulator-min-microvolt = <3300000>;
 		regulator-max-microvolt = <3300000>;
 	};
@@ -128,7 +128,7 @@ &rtc {
 
 &sdio2 {
 	status = "okay";
-	vmmc-supply = <&mmc_vcard>;
+	vmmc-supply = <&vcc_3v3>;
 	cd-gpios = <&gpioi 15 GPIO_ACTIVE_LOW>;
 	broken-cd;
 	pinctrl-names = "default", "opendrain", "sleep";
-- 
2.43.0

Re: [PATCH v8 3/5] ARM: dts: stm32: rename mmc_vcard to vcc-3v3 on stm32f769-disco

[Alexandre TORGUE]

Hi Dario

On 1/12/24 15:48, Dario Binacchi wrote:
> In the schematics of document UM2033, the power supply for the micro SD
> card is the same 3v3 voltage that is used to power other devices on the
> board. By generalizing the name of the voltage regulator, it can be
> referenced by other nodes in the device tree without creating
> misunderstandings.
> 
> This patch is preparatory for future developments.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Reviewed-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
> 
> ---
> 
> Changes in v8:
> - Add Reviewed-by tag of Raphael Gallais-Pou
> 
>   arch/arm/boot/dts/st/stm32f769-disco.dts | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/st/stm32f769-disco.dts b/arch/arm/boot/dts/st/stm32f769-disco.dts
> index 5d12ae25b327..8632bd866272 100644
> --- a/arch/arm/boot/dts/st/stm32f769-disco.dts
> +++ b/arch/arm/boot/dts/st/stm32f769-disco.dts
> @@ -92,9 +92,9 @@ usbotg_hs_phy: usb-phy {
>   		clock-names = "main_clk";
>   	};
>   
> -	mmc_vcard: mmc_vcard {
> +	vcc_3v3: vcc_3v3 {

Replace node name by vcc-3v3. If no v9 sent, I'll do it directly.

>   		compatible = "regulator-fixed";
> -		regulator-name = "mmc_vcard";
> +		regulator-name = "vcc_3v3";
>   		regulator-min-microvolt = <3300000>;
>   		regulator-max-microvolt = <3300000>;
>   	};
> @@ -128,7 +128,7 @@ &rtc {
>   
>   &sdio2 {
>   	status = "okay";
> -	vmmc-supply = <&mmc_vcard>;
> +	vmmc-supply = <&vcc_3v3>;
>   	cd-gpios = <&gpioi 15 GPIO_ACTIVE_LOW>;
>   	broken-cd;
>   	pinctrl-names = "default", "opendrain", "sleep";

Re: [PATCH v8 3/5] ARM: dts: stm32: rename mmc_vcard to vcc-3v3 on stm32f769-disco

[Dario Binacchi]

Hi Alexandre,

On Tue, Jan 23, 2024 at 5:31 PM Alexandre TORGUE
<alexandre.torgue@foss.st.com> wrote:
>
> Hi Dario
>
> On 1/12/24 15:48, Dario Binacchi wrote:
> > In the schematics of document UM2033, the power supply for the micro SD
> > card is the same 3v3 voltage that is used to power other devices on the
> > board. By generalizing the name of the voltage regulator, it can be
> > referenced by other nodes in the device tree without creating
> > misunderstandings.
> >
> > This patch is preparatory for future developments.
> >
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> > Reviewed-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
> >
> > ---
> >
> > Changes in v8:
> > - Add Reviewed-by tag of Raphael Gallais-Pou
> >
> >   arch/arm/boot/dts/st/stm32f769-disco.dts | 6 +++---
> >   1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/st/stm32f769-disco.dts b/arch/arm/boot/dts/st/stm32f769-disco.dts
> > index 5d12ae25b327..8632bd866272 100644
> > --- a/arch/arm/boot/dts/st/stm32f769-disco.dts
> > +++ b/arch/arm/boot/dts/st/stm32f769-disco.dts
> > @@ -92,9 +92,9 @@ usbotg_hs_phy: usb-phy {
> >               clock-names = "main_clk";
> >       };
> >
> > -     mmc_vcard: mmc_vcard {
> > +     vcc_3v3: vcc_3v3 {
>
> Replace node name by vcc-3v3. If no v9 sent, I'll do it directly.

I'll do it

Thanks and regards,
Dario

>
> >               compatible = "regulator-fixed";
> > -             regulator-name = "mmc_vcard";
> > +             regulator-name = "vcc_3v3";
> >               regulator-min-microvolt = <3300000>;
> >               regulator-max-microvolt = <3300000>;
> >       };
> > @@ -128,7 +128,7 @@ &rtc {
> >
> >   &sdio2 {
> >       status = "okay";
> > -     vmmc-supply = <&mmc_vcard>;
> > +     vmmc-supply = <&vcc_3v3>;
> >       cd-gpios = <&gpioi 15 GPIO_ACTIVE_LOW>;
> >       broken-cd;
> >       pinctrl-names = "default", "opendrain", "sleep";



-- 

Dario Binacchi

Senior Embedded Linux Developer

dario.binacchi@amarulasolutions.com

__________________________________


Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
info@amarulasolutions.com

www.amarulasolutions.com

[PATCH v8 4/5] ARM: dts: stm32: add display support on stm32f769-disco

[Dario Binacchi]

The patch adds display support on the stm32f769-disco board.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>

---

Changes in v8:
- Remove unit name from 'ltdc/port/endpoint@0' to fix the compiling
  warning:
  ../arch/arm/boot/dts/st/stm32f769-disco.dts:189.28-191.5: Warning
  (unit_address_vs_reg): /soc/display-controller@40016800/port/endpoint@0: node
  has a unit name, but no reg or ranges property

 arch/arm/boot/dts/st/stm32f769-disco.dts | 72 +++++++++++++++++++++++-
 1 file changed, 71 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/st/stm32f769-disco.dts b/arch/arm/boot/dts/st/stm32f769-disco.dts
index 8632bd866272..b38eef824463 100644
--- a/arch/arm/boot/dts/st/stm32f769-disco.dts
+++ b/arch/arm/boot/dts/st/stm32f769-disco.dts
@@ -41,7 +41,7 @@
  */
 
 /dts-v1/;
-#include "stm32f746.dtsi"
+#include "stm32f769.dtsi"
 #include "stm32f769-pinctrl.dtsi"
 #include <dt-bindings/input/input.h>
 #include <dt-bindings/gpio/gpio.h>
@@ -60,6 +60,19 @@ memory@c0000000 {
 		reg = <0xC0000000 0x1000000>;
 	};
 
+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		linux,dma {
+			compatible = "shared-dma-pool";
+			linux,dma-default;
+			no-map;
+			size = <0x100000>;
+		};
+	};
+
 	aliases {
 		serial0 = &usart1;
 	};
@@ -85,6 +98,13 @@ button-0 {
 		};
 	};
 
+	panel_backlight: panel-backlight {
+		compatible = "gpio-backlight";
+		gpios = <&gpioi 14 GPIO_ACTIVE_HIGH>;
+		default-on;
+		status = "okay";
+	};
+
 	usbotg_hs_phy: usb-phy {
 		#phy-cells = <0>;
 		compatible = "usb-nop-xceiv";
@@ -114,6 +134,46 @@ &clk_hse {
 	clock-frequency = <25000000>;
 };
 
+&dsi {
+	#address-cells = <1>;
+	#size-cells = <0>;
+	status = "okay";
+
+	ports {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		port@0 {
+			reg = <0>;
+			dsi_in: endpoint {
+				remote-endpoint = <&ltdc_out_dsi>;
+			};
+		};
+
+		port@1 {
+			reg = <1>;
+			dsi_out: endpoint {
+				remote-endpoint = <&dsi_panel_in>;
+			};
+		};
+	};
+
+	panel0: panel-dsi@0 {
+		compatible = "orisetech,otm8009a";
+		reg = <0>; /* dsi virtual channel (0..3) */
+		reset-gpios = <&gpioj 15 GPIO_ACTIVE_LOW>;
+		power-supply = <&vcc_3v3>;
+		backlight = <&panel_backlight>;
+		status = "okay";
+
+		port {
+			dsi_panel_in: endpoint {
+				remote-endpoint = <&dsi_out>;
+			};
+		};
+	};
+};
+
 &i2c1 {
 	pinctrl-0 = <&i2c1_pins_b>;
 	pinctrl-names = "default";
@@ -122,6 +182,16 @@ &i2c1 {
 	status = "okay";
 };
 
+&ltdc {
+	status = "okay";
+
+	port {
+		ltdc_out_dsi: endpoint {
+			remote-endpoint = <&dsi_in>;
+		};
+	};
+};
+
 &rtc {
 	status = "okay";
 };
-- 
2.43.0

[PATCH v8 5/5] ARM: dts: add stm32f769-disco-mb1225-revb03-mb1166-reva09

[Dario Binacchi]

As reported in the section 8.3 (i. e. Board revision history) of document
UM2033 (i. e. Discovery kit with STM32F769NI MCU) these are the changes
related to the board revisions addressed by the patch:
- Board MB1225 revision B-03:
  - Memory MICRON MT48LC4M32B2B5-6A replaced by ISSI IS42S32400F-6BL
- Board MB1166 revision A-09:
  - LCD FRIDA FRD397B25009-D-CTK replaced by FRIDA FRD400B25025-A-CTK

The patch only adds the DTS support for the new display which belongs to
to the Novatek NT35510-based panel family.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>

---

Changes in v8:
- Add Reviewed-by tag of Linus Walleij
- Add Reviewed-by tag of Raphael Gallais-Pou

Changes in v7:
- Replace .dts with .dtb in the Makefile

Changes in v6:
- Drop patches
  - [5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK
  - [7/8] drm/panel: nt35510: move hardwired parameters to configuration
  - [8/8] drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK
  because applied by the maintainer Linus Walleij

Changes in v5:
- Replace GPIOD_ASIS with GPIOD_OUT_HIGH in the call to devm_gpiod_get_optional().

Changes in v2:
- Change the status of panel_backlight node to "disabled"
- Delete backlight property from panel0 node.
- Re-write the patch [8/8] "drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK"
  in the same style as the original driver.

 arch/arm/boot/dts/st/Makefile                  |  1 +
 ...2f769-disco-mb1225-revb03-mb1166-reva09.dts | 18 ++++++++++++++++++
 2 files changed, 19 insertions(+)
 create mode 100644 arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts

diff --git a/arch/arm/boot/dts/st/Makefile b/arch/arm/boot/dts/st/Makefile
index 7892ad69b441..aa5b50d7ac61 100644
--- a/arch/arm/boot/dts/st/Makefile
+++ b/arch/arm/boot/dts/st/Makefile
@@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_STM32) += \
 	stm32f469-disco.dtb \
 	stm32f746-disco.dtb \
 	stm32f769-disco.dtb \
+	stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb \
 	stm32429i-eval.dtb \
 	stm32746g-eval.dtb \
 	stm32h743i-eval.dtb \
diff --git a/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts b/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts
new file mode 100644
index 000000000000..014cac192375
--- /dev/null
+++ b/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts
@@ -0,0 +1,18 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2023 Dario Binacchi <dario.binacchi@amarulasolutions.com>
+ */
+
+#include "stm32f769-disco.dts"
+
+&panel_backlight {
+	status = "disabled";
+};
+
+&panel0 {
+	compatible = "frida,frd400b25025", "novatek,nt35510";
+	vddi-supply = <&vcc_3v3>;
+	vdd-supply = <&vcc_3v3>;
+	/delete-property/backlight;
+	/delete-property/power-supply;
+};
-- 
2.43.0

Re: [PATCH v8 5/5] ARM: dts: add stm32f769-disco-mb1225-revb03-mb1166-reva09

[Alexandre TORGUE]

Hi Dario

On 1/12/24 15:48, Dario Binacchi wrote:
> As reported in the section 8.3 (i. e. Board revision history) of document
> UM2033 (i. e. Discovery kit with STM32F769NI MCU) these are the changes
> related to the board revisions addressed by the patch:
> - Board MB1225 revision B-03:
>    - Memory MICRON MT48LC4M32B2B5-6A replaced by ISSI IS42S32400F-6BL
> - Board MB1166 revision A-09:
>    - LCD FRIDA FRD397B25009-D-CTK replaced by FRIDA FRD400B25025-A-CTK
> 
> The patch only adds the DTS support for the new display which belongs to
> to the Novatek NT35510-based panel family.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Reviewed-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
> 

I still have YAML error. Do you have same on your side or maybe I missed 
a dt-binding patch somewhere ?

/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb: 
dsi@40016c00: Unevaluated properties are not allowed ('interrupts', 
'panel-dsi@0' were unexpected)
	from schema $id: http://devicetree.org/schemas/display/st,stm32-dsi.yaml#
/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb: 
panel-dsi@0: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
	from schema $id: 
http://devicetree.org/schemas/display/panel/novatek,nt35510.yaml#

Aside that, I just have a cosmetic question. Can we find a shorter name 
for the board ? (not sure we can).

Cheers
Alex



> ---
> 
> Changes in v8:
> - Add Reviewed-by tag of Linus Walleij
> - Add Reviewed-by tag of Raphael Gallais-Pou
> 
> Changes in v7:
> - Replace .dts with .dtb in the Makefile
> 
> Changes in v6:
> - Drop patches
>    - [5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK
>    - [7/8] drm/panel: nt35510: move hardwired parameters to configuration
>    - [8/8] drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK
>    because applied by the maintainer Linus Walleij
> 
> Changes in v5:
> - Replace GPIOD_ASIS with GPIOD_OUT_HIGH in the call to devm_gpiod_get_optional().
> 
> Changes in v2:
> - Change the status of panel_backlight node to "disabled"
> - Delete backlight property from panel0 node.
> - Re-write the patch [8/8] "drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK"
>    in the same style as the original driver.
> 
>   arch/arm/boot/dts/st/Makefile                  |  1 +
>   ...2f769-disco-mb1225-revb03-mb1166-reva09.dts | 18 ++++++++++++++++++
>   2 files changed, 19 insertions(+)
>   create mode 100644 arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts
> 
> diff --git a/arch/arm/boot/dts/st/Makefile b/arch/arm/boot/dts/st/Makefile
> index 7892ad69b441..aa5b50d7ac61 100644
> --- a/arch/arm/boot/dts/st/Makefile
> +++ b/arch/arm/boot/dts/st/Makefile
> @@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_STM32) += \
>   	stm32f469-disco.dtb \
>   	stm32f746-disco.dtb \
>   	stm32f769-disco.dtb \
> +	stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb \
>   	stm32429i-eval.dtb \
>   	stm32746g-eval.dtb \
>   	stm32h743i-eval.dtb \
> diff --git a/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts b/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts
> new file mode 100644
> index 000000000000..014cac192375
> --- /dev/null
> +++ b/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts
> @@ -0,0 +1,18 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2023 Dario Binacchi <dario.binacchi@amarulasolutions.com>
> + */
> +
> +#include "stm32f769-disco.dts"
> +
> +&panel_backlight {
> +	status = "disabled";
> +};
> +
> +&panel0 {
> +	compatible = "frida,frd400b25025", "novatek,nt35510";
> +	vddi-supply = <&vcc_3v3>;
> +	vdd-supply = <&vcc_3v3>;
> +	/delete-property/backlight;
> +	/delete-property/power-supply;
> +};

Re: [PATCH v8 5/5] ARM: dts: add stm32f769-disco-mb1225-revb03-mb1166-reva09

[Dario Binacchi]

Hi Alexandre,

On Tue, Jan 23, 2024 at 5:36 PM Alexandre TORGUE
<alexandre.torgue@foss.st.com> wrote:
>
> Hi Dario
>
> On 1/12/24 15:48, Dario Binacchi wrote:
> > As reported in the section 8.3 (i. e. Board revision history) of document
> > UM2033 (i. e. Discovery kit with STM32F769NI MCU) these are the changes
> > related to the board revisions addressed by the patch:
> > - Board MB1225 revision B-03:
> >    - Memory MICRON MT48LC4M32B2B5-6A replaced by ISSI IS42S32400F-6BL
> > - Board MB1166 revision A-09:
> >    - LCD FRIDA FRD397B25009-D-CTK replaced by FRIDA FRD400B25025-A-CTK
> >
> > The patch only adds the DTS support for the new display which belongs to
> > to the Novatek NT35510-based panel family.
> >
> > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> > Reviewed-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
> >
>
> I still have YAML error. Do you have same on your side or maybe I missed
> a dt-binding patch somewhere ?
>
> /arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb:
> dsi@40016c00: Unevaluated properties are not allowed ('interrupts',
> 'panel-dsi@0' were unexpected)
>         from schema $id: http://devicetree.org/schemas/display/st,stm32-dsi.yaml#
> /arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb:
> panel-dsi@0: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
>         from schema $id:
> http://devicetree.org/schemas/display/panel/novatek,nt35510.yaml#

What command do you run?

As reported by commit:
commit b81c8c3b8e3847a14bd83dd1de460df3efcb3329
Author: Benjamin Gaignard <benjamin.gaignard@st.com>
Date:   Fri Oct 11 15:06:58 2019 +0200

    ARM: dts: stm32: remove useless interrupt from dsi node for stm32f469

    DSI driver doesn't use interrupt, remove it from the node since it
    breaks yaml check.

    Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
    Signed-off-by: Alexandre Torgue <alexandre.torgue@st.com

The fix could be to remove the 'interrupts' property from the dsi@40016c00
added by the patch [2/5] "ARM: dts: stm32: add DSI support on stm32f769"

>
> Aside that, I just have a cosmetic question. Can we find a shorter name
> for the board ? (not sure we can).

In the repo https://github.com/STMicroelectronics/STM32CubeF7.git
you can find this code:

#if defined(USE_STM32F769I_DISCO_REVB03)
/***********************NT35510
Initialization********************************/

  /* Initialize the NT35510 LCD Display IC Driver (TechShine LCD IC Driver)
   * depending on configuration set in 'hdsivideo_handle'.
   */
  NT35510_Init(NT35510_FORMAT_RGB888, orientation);
/***********************End NT35510 Initialization****************************/
#else

/***********************OTM8009A Initialization********************************/

  /* Initialize the OTM8009A LCD Display IC Driver (KoD LCD IC Driver)
  *  depending on configuration set in 'hdsivideo_handle'.
  */
  OTM8009A_Init(OTM8009A_FORMAT_RGB888, orientation);

/***********************End OTM8009A Initialization****************************/
#endif /* USE_STM32F769I_DISCO_REVB03 */

in file Drivers/BSP/STM32F769I-Discovery/stm32f769i_discovery_lcd.c.

And the comment:

/* USE_STM32F769I_DISCO_REVB03 */ /* Applicable only for STM32F769I
DISCOVERY w/ MB1166-A09 LCD daughter board connected on */
in file Drivers/BSP/STM32F769I-Discovery/stm32f769i_discovery.h.

One possible approach might be to drop 'mb1225,' assuming that
'revb03' refers to it implicitly:
stm32f769-disco-revb03-mb1166-reva09

But any suggestion is welcome.

I will wait for your opinion before sending version 9.

Thanks and regards,
Dario
>
> Cheers
> Alex
>
>
>
> > ---
> >
> > Changes in v8:
> > - Add Reviewed-by tag of Linus Walleij
> > - Add Reviewed-by tag of Raphael Gallais-Pou
> >
> > Changes in v7:
> > - Replace .dts with .dtb in the Makefile
> >
> > Changes in v6:
> > - Drop patches
> >    - [5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK
> >    - [7/8] drm/panel: nt35510: move hardwired parameters to configuration
> >    - [8/8] drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK
> >    because applied by the maintainer Linus Walleij
> >
> > Changes in v5:
> > - Replace GPIOD_ASIS with GPIOD_OUT_HIGH in the call to devm_gpiod_get_optional().
> >
> > Changes in v2:
> > - Change the status of panel_backlight node to "disabled"
> > - Delete backlight property from panel0 node.
> > - Re-write the patch [8/8] "drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK"
> >    in the same style as the original driver.
> >
> >   arch/arm/boot/dts/st/Makefile                  |  1 +
> >   ...2f769-disco-mb1225-revb03-mb1166-reva09.dts | 18 ++++++++++++++++++
> >   2 files changed, 19 insertions(+)
> >   create mode 100644 arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts
> >
> > diff --git a/arch/arm/boot/dts/st/Makefile b/arch/arm/boot/dts/st/Makefile
> > index 7892ad69b441..aa5b50d7ac61 100644
> > --- a/arch/arm/boot/dts/st/Makefile
> > +++ b/arch/arm/boot/dts/st/Makefile
> > @@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_STM32) += \
> >       stm32f469-disco.dtb \
> >       stm32f746-disco.dtb \
> >       stm32f769-disco.dtb \
> > +     stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb \
> >       stm32429i-eval.dtb \
> >       stm32746g-eval.dtb \
> >       stm32h743i-eval.dtb \
> > diff --git a/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts b/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts
> > new file mode 100644
> > index 000000000000..014cac192375
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts
> > @@ -0,0 +1,18 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (c) 2023 Dario Binacchi <dario.binacchi@amarulasolutions.com>
> > + */
> > +
> > +#include "stm32f769-disco.dts"
> > +
> > +&panel_backlight {
> > +     status = "disabled";
> > +};
> > +
> > +&panel0 {
> > +     compatible = "frida,frd400b25025", "novatek,nt35510";
> > +     vddi-supply = <&vcc_3v3>;
> > +     vdd-supply = <&vcc_3v3>;
> > +     /delete-property/backlight;
> > +     /delete-property/power-supply;
> > +};



-- 

Dario Binacchi

Senior Embedded Linux Developer

dario.binacchi@amarulasolutions.com

__________________________________


Amarula Solutions SRL

Via Le Canevare 30, 31100 Treviso, Veneto, IT

T. +39 042 243 5310
info@amarulasolutions.com

www.amarulasolutions.com

Re: [PATCH v8 5/5] ARM: dts: add stm32f769-disco-mb1225-revb03-mb1166-reva09

[Alexandre TORGUE]

Hi Dario

On 1/23/24 19:48, Dario Binacchi wrote:
> Hi Alexandre,
> 
> On Tue, Jan 23, 2024 at 5:36 PM Alexandre TORGUE
> <alexandre.torgue@foss.st.com> wrote:
>>
>> Hi Dario
>>
>> On 1/12/24 15:48, Dario Binacchi wrote:
>>> As reported in the section 8.3 (i. e. Board revision history) of document
>>> UM2033 (i. e. Discovery kit with STM32F769NI MCU) these are the changes
>>> related to the board revisions addressed by the patch:
>>> - Board MB1225 revision B-03:
>>>     - Memory MICRON MT48LC4M32B2B5-6A replaced by ISSI IS42S32400F-6BL
>>> - Board MB1166 revision A-09:
>>>     - LCD FRIDA FRD397B25009-D-CTK replaced by FRIDA FRD400B25025-A-CTK
>>>
>>> The patch only adds the DTS support for the new display which belongs to
>>> to the Novatek NT35510-based panel family.
>>>
>>> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
>>> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
>>> Reviewed-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
>>>
>>
>> I still have YAML error. Do you have same on your side or maybe I missed
>> a dt-binding patch somewhere ?
>>
>> /arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb:
>> dsi@40016c00: Unevaluated properties are not allowed ('interrupts',
>> 'panel-dsi@0' were unexpected)
>>          from schema $id: http://devicetree.org/schemas/display/st,stm32-dsi.yaml#
>> /arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb:
>> panel-dsi@0: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
>>          from schema $id:
>> http://devicetree.org/schemas/display/panel/novatek,nt35510.yaml#
> 
> What command do you run?
> 

make -j16 CHECK_DTBS=y st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb


> As reported by commit:
> commit b81c8c3b8e3847a14bd83dd1de460df3efcb3329
> Author: Benjamin Gaignard <benjamin.gaignard@st.com>
> Date:   Fri Oct 11 15:06:58 2019 +0200
> 
>      ARM: dts: stm32: remove useless interrupt from dsi node for stm32f469
> 
>      DSI driver doesn't use interrupt, remove it from the node since it
>      breaks yaml check.
> 
>      Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
>      Signed-off-by: Alexandre Torgue <alexandre.torgue@st.com
> 
> The fix could be to remove the 'interrupts' property from the dsi@40016c00
> added by the patch [2/5] "ARM: dts: stm32: add DSI support on stm32f769"
> 
>>
>> Aside that, I just have a cosmetic question. Can we find a shorter name
>> for the board ? (not sure we can).
> 
> In the repo https://github.com/STMicroelectronics/STM32CubeF7.git
> you can find this code:
> 
> #if defined(USE_STM32F769I_DISCO_REVB03)
> /***********************NT35510
> Initialization********************************/
> 
>    /* Initialize the NT35510 LCD Display IC Driver (TechShine LCD IC Driver)
>     * depending on configuration set in 'hdsivideo_handle'.
>     */
>    NT35510_Init(NT35510_FORMAT_RGB888, orientation);
> /***********************End NT35510 Initialization****************************/
> #else
> 
> /***********************OTM8009A Initialization********************************/
> 
>    /* Initialize the OTM8009A LCD Display IC Driver (KoD LCD IC Driver)
>    *  depending on configuration set in 'hdsivideo_handle'.
>    */
>    OTM8009A_Init(OTM8009A_FORMAT_RGB888, orientation);
> 
> /***********************End OTM8009A Initialization****************************/
> #endif /* USE_STM32F769I_DISCO_REVB03 */
> 
> in file Drivers/BSP/STM32F769I-Discovery/stm32f769i_discovery_lcd.c.
> 
> And the comment:
> 
> /* USE_STM32F769I_DISCO_REVB03 */ /* Applicable only for STM32F769I
> DISCOVERY w/ MB1166-A09 LCD daughter board connected on */
> in file Drivers/BSP/STM32F769I-Discovery/stm32f769i_discovery.h.
> 
> One possible approach might be to drop 'mb1225,' assuming that
> 'revb03' refers to it implicitly:
> stm32f769-disco-revb03-mb1166-reva09
> 
> But any suggestion is welcome.

It is actually a tricky point. My position for MPU is to only support 
the latest board revision (the one which is really sold). Idea behind is 
to not have many board revisions to support. But I can understand that 
some people using the "old" board would like to continue to work on it 
with an upstream version. I 'm just not sure that this "old" version has 
to be maintained.
Concerning the name, yes the first thing is to drop mb1225 (as disco = 
MB1225). I would propose also to drop re "revb03" as there are no 
changes regarding memory in this series.

regards
alex

> 
> I will wait for your opinion before sending version 9.
> 
> Thanks and regards,
> Dario
>>
>> Cheers
>> Alex
>>
>>
>>
>>> ---
>>>
>>> Changes in v8:
>>> - Add Reviewed-by tag of Linus Walleij
>>> - Add Reviewed-by tag of Raphael Gallais-Pou
>>>
>>> Changes in v7:
>>> - Replace .dts with .dtb in the Makefile
>>>
>>> Changes in v6:
>>> - Drop patches
>>>     - [5/8] dt-bindings: nt35510: add compatible for FRIDA FRD400B25025-A-CTK
>>>     - [7/8] drm/panel: nt35510: move hardwired parameters to configuration
>>>     - [8/8] drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK
>>>     because applied by the maintainer Linus Walleij
>>>
>>> Changes in v5:
>>> - Replace GPIOD_ASIS with GPIOD_OUT_HIGH in the call to devm_gpiod_get_optional().
>>>
>>> Changes in v2:
>>> - Change the status of panel_backlight node to "disabled"
>>> - Delete backlight property from panel0 node.
>>> - Re-write the patch [8/8] "drm/panel: nt35510: support FRIDA FRD400B25025-A-CTK"
>>>     in the same style as the original driver.
>>>
>>>    arch/arm/boot/dts/st/Makefile                  |  1 +
>>>    ...2f769-disco-mb1225-revb03-mb1166-reva09.dts | 18 ++++++++++++++++++
>>>    2 files changed, 19 insertions(+)
>>>    create mode 100644 arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts
>>>
>>> diff --git a/arch/arm/boot/dts/st/Makefile b/arch/arm/boot/dts/st/Makefile
>>> index 7892ad69b441..aa5b50d7ac61 100644
>>> --- a/arch/arm/boot/dts/st/Makefile
>>> +++ b/arch/arm/boot/dts/st/Makefile
>>> @@ -23,6 +23,7 @@ dtb-$(CONFIG_ARCH_STM32) += \
>>>        stm32f469-disco.dtb \
>>>        stm32f746-disco.dtb \
>>>        stm32f769-disco.dtb \
>>> +     stm32f769-disco-mb1225-revb03-mb1166-reva09.dtb \
>>>        stm32429i-eval.dtb \
>>>        stm32746g-eval.dtb \
>>>        stm32h743i-eval.dtb \
>>> diff --git a/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts b/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts
>>> new file mode 100644
>>> index 000000000000..014cac192375
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/st/stm32f769-disco-mb1225-revb03-mb1166-reva09.dts
>>> @@ -0,0 +1,18 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>>> +/*
>>> + * Copyright (c) 2023 Dario Binacchi <dario.binacchi@amarulasolutions.com>
>>> + */
>>> +
>>> +#include "stm32f769-disco.dts"
>>> +
>>> +&panel_backlight {
>>> +     status = "disabled";
>>> +};
>>> +
>>> +&panel0 {
>>> +     compatible = "frida,frd400b25025", "novatek,nt35510";
>>> +     vddi-supply = <&vcc_3v3>;
>>> +     vdd-supply = <&vcc_3v3>;
>>> +     /delete-property/backlight;
>>> +     /delete-property/power-supply;
>>> +};
> 
> 
>