Re: [PATCH v3 2/2] bus: mhi: Fix MHI DMA structure endianness

Hemant Kumar
2021-07-01T01:53:08Z

Hi Paul,
On Tue, 2021-06-29 at 15:53 +1200, Paul Davey wrote:
> The MHI driver does not work on big endian architectures.  The
> controller never transitions into mission mode.  This appears to be
> due
> to the modem device expecting the various contexts and transfer rings
> to
> have fields in little endian order in memory, but the driver
> constructs
> them in native endianness.
>
> Fix MHI event, channel and command contexts and TRE handling macros
> to
> use explicit conversion to little endian.  Mark fields in relevant
> structures as little endian to document this requirement.
>
> Signed-off-by: Paul Davey <paul.davey@alliedtelesis.co.nz>
> ---
> Removed Tested-by as patch has changed somewhat from v2.
Bhaumik is going to help testing V2 on x86 platform. Change looks good
to me. Will ack it once testing is done.
> [..]
>

Thanks,
Hemant
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project