From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7331513C816 for ; Fri, 9 May 2025 11:03:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746788615; cv=none; b=X6b9zJGeRVjYWrGKq/qdi5l+w57GMIX4rKRPrAkxhzo12zmyQb0CesOCVkc9oxmyJlscKudJje4JRjuu5Rtdy7Dli0kFtAQn2hXW8TSKersqUkHBW6LFyv8KdNlgL4Y9NUsd5fOhjiS0B1b5/2OvIfbqyrGSHxWo+tqF00BGscA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746788615; c=relaxed/simple; bh=OgYLS6rN/aWcHmC0TbnGXQkvQ3XWroRBm3sInogUo9Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mf9NX1Q7u3WklZvF5uHruLK86vmo9qqbzDvQbqqBWCXsGFzSBbavvM5/YnLMLGulIJkDCHiuYUOfiLjw1bjKmRRoTBSYA6sgqaC4k+cHoY5GqR6uR2T8CAS6eS8u0u4mG5TPi2FZcbCMyAAxmel46f/WNfghXmlt4Fw+PZ5huvs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=rGssEQb/; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="rGssEQb/" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-5fbda5a8561so2870001a12.2 for ; Fri, 09 May 2025 04:03:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1746788611; x=1747393411; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zFxcvkRZTPa+CugcSqwsIxPTpM3T5RF/mU8pEgzipws=; b=rGssEQb/mIDN7BNY717WLpYV6SOzTje2fhZx17ZG/qAxJfgCg7tEK/Dlrbzn3ceZke mCKlpV1q4SD3+/FZiijpkyliovb6/HCvFQDuEm6BEAkLnc3Qo1X+Ci13+d+q7hc3+PeT 2b86KavOY8GP1JNFoj1Yf3ci9N0XRjA/NTauJdQrZA2qEpjWc0TP9wGMX0raTTFeRPWv QZ1+MTUFgNyE5K/vpDbfgz18BCoiO+H0z4yA3RUsgyEH+WRFE34ixTc7hzyadaQaL4hA usyCdpRvq4+NY9Sa8iTpUJeNDOQ1gOMxz8nLHI2bue1aPzYMJBVYZYNXoVp5z8KVTsvN 5Mhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746788611; x=1747393411; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zFxcvkRZTPa+CugcSqwsIxPTpM3T5RF/mU8pEgzipws=; b=VAXRi3bcORbs6THLgBnOsgO401+zNZv/sdIrjOfgzZBw9MPjjbk7b+eAH1MDoCkTb7 fehoBORI+cCjMb6Xm+dRfOObeuyjTBRMBmz61P1T6/AMBYWor9pxRf8LWrVZm0Li0HAn 3vYFxB3svkRXZjpJknRHE7NRin9mZCSpaJiIkTmU+EOptRDqhRlL/ZjW/OutevkyvwQA e0rcRiJj/TE1luVer011LUlA8pWPIAtZZRS8cp5O+3XlZ36CIYOLVh8YndTd42EF+BCb qqT8iueUqRf2XsF7E6yzEQGDX5HPiWCR1QUo/DjBYd/FFQkXUXhXWszbN6LxtAMKqoQk 50qg== X-Forwarded-Encrypted: i=1; AJvYcCXLozOiub+TkLhXt3F8+n0kWZnOIiPCr5H+Eo56Fbpx2lL0Q1gY2+gtxrdc9NaXTZU+XNl2EwPwXkhnHM4=@vger.kernel.org X-Gm-Message-State: AOJu0YyTJr+HWaPFZ3/cWmiePZzlimi1C5+gJghjGFZk+hUIribSZX4I SnZn3gCTO9yt0Tsg2Qs2tZsjBkfKwJK99koRwW/JZDwTGaWSJP/TJVi9yHnRaVs= X-Gm-Gg: ASbGnct4R002hI7iGn3oc4kp2PjTYDEEi0sR0VUV/jPuJoofMaCCPJfTGY4yDcwiz6x tmjUuk1045pPMgnLRABbzzKcRO2o3gaEWcQ//1NdBmsGiqxiVS5EdihFQbFyVMd9i02OXyS87y2 99k2RB42MND31Zk3pRsCuIgzuvjGvW9STTITh2c9T5U0ZaY3tuMhQrNvgLHtm2zYCJ2jabAgAWI sknzXzmIemBe6edADKP77ghUXOyV9qQDhWG1aE5idI2vgn/q3ohjojXBnSPMFbKogbqHZXWIu2Y hkTjffu0Bcc73wH53/sTBBXctXuG4ZP+2J/ChMApQh4QA2Lv X-Google-Smtp-Source: AGHT+IH/1p6uEeOzTVLPAx+9fTyhrp0ya4CKbQUgABhxisJMsnfrdqYaw7fre4wd9sK5d2WCYVgROA== X-Received: by 2002:a05:6402:3581:b0:5fc:9bce:65c3 with SMTP id 4fb4d7f45d1cf-5fca0818926mr2247906a12.30.1746788610572; Fri, 09 May 2025 04:03:30 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.50]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5fc9cc261e9sm1233651a12.23.2025.05.09.04.03.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 May 2025 04:03:30 -0700 (PDT) Message-ID: Date: Fri, 9 May 2025 14:03:28 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 4/7] clk: renesas: r9a08g045: Drop power domain instantiation To: Geert Uytterhoeven Cc: mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, magnus.damm@gmail.com, linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Claudiu Beznea References: <20250410140628.4124896-1-claudiu.beznea.uj@bp.renesas.com> <20250410140628.4124896-5-claudiu.beznea.uj@bp.renesas.com> From: Claudiu Beznea Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Geert, On 07.05.2025 20:10, Geert Uytterhoeven wrote: > Hi Claudiu, > > On Thu, 10 Apr 2025 at 16:06, Claudiu wrote: >> From: Claudiu Beznea >> >> Since the configuration order between the individual MSTOP and CLKON bits >> cannot be preserved with the power domain abstraction, drop the power >> domain instantiations. >> >> Signed-off-by: Claudiu Beznea > > Thanks for your patch! > >> --- a/drivers/clk/renesas/r9a08g045-cpg.c >> +++ b/drivers/clk/renesas/r9a08g045-cpg.c >> @@ -192,59 +192,105 @@ static const struct cpg_core_clk r9a08g045_core_clks[] __initconst = { >> }; >> >> static const struct rzg2l_mod_clk r9a08g045_mod_clks[] = { > >> + DEF_MOD("dmac_aclk", R9A08G045_DMAC_ACLK, R9A08G045_CLK_P3, 0x52c, 0, >> + MSTOP(BUS_REG1, BIT(2))), >> + DEF_MOD("dmac_pclk", R9A08G045_DMAC_PCLK, CLK_P3_DIV2, 0x52c, 1, >> + MSTOP(BUS_REG1, BIT(3))), > > The documentation is not very clear about the mapping to the 4 MSTOP > bits related to DMA. Can you enlighten me? I chose it like these thinking that the bits 0 and 1 are secure specific variants of bits 2 and 3, thinking that they should be controlled from secure world. > >> @@ -294,78 +340,6 @@ static const unsigned int r9a08g045_crit_mod_clks[] __initconst = { >> MOD_CLK_BASE + R9A08G045_VBAT_BCLK, >> }; >> >> -static const struct rzg2l_cpg_pm_domain_init_data r9a08g045_pm_domains[] = { >> - /* Keep always-on domain on the first position for proper domains registration. */ >> - DEF_PD("always-on", R9A08G045_PD_ALWAYS_ON, >> - DEF_REG_CONF(0, 0), >> - GENPD_FLAG_ALWAYS_ON | GENPD_FLAG_IRQ_SAFE), >> - DEF_PD("gic", R9A08G045_PD_GIC, >> - DEF_REG_CONF(CPG_BUS_ACPU_MSTOP, BIT(3)), >> - GENPD_FLAG_ALWAYS_ON), >> - DEF_PD("ia55", R9A08G045_PD_IA55, >> - DEF_REG_CONF(CPG_BUS_PERI_CPU_MSTOP, BIT(13)), >> - GENPD_FLAG_ALWAYS_ON), >> - DEF_PD("dmac", R9A08G045_PD_DMAC, >> - DEF_REG_CONF(CPG_BUS_REG1_MSTOP, GENMASK(3, 0)), >> - GENPD_FLAG_ALWAYS_ON), > > [...] > >> - DEF_PD("rtc", R9A08G045_PD_RTC, >> - DEF_REG_CONF(CPG_BUS_MCPU3_MSTOP, BIT(7)), 0), > > These MSTOP bits are no longer controlled. Is that intentional? No, that's a mistake from me. Thank you for pointing it. Claudiu > > Gr{oetje,eeting}s, > > Geert >