From: "Denis Efremov (Oracle)" <efremov@linux.com>
To: Jeff Johnson <quic_jjohnson@quicinc.com>, Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] floppy: add missing MODULE_DESCRIPTION() macro
Date: Mon, 3 Jun 2024 14:35:40 +0400 [thread overview]
Message-ID: <f3a27dbe-091a-43d0-aac8-eebb4e2833d4@linux.com> (raw)
In-Reply-To: <20240602-md-block-floppy-v1-1-bc628ea5eb84@quicinc.com>
On 6/3/24 04:05, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/floppy.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/block/floppy.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
> index 25c9d85667f1..854a88cf56bd 100644
> --- a/drivers/block/floppy.c
> +++ b/drivers/block/floppy.c
> @@ -5016,6 +5016,7 @@ module_param(floppy, charp, 0);
> module_param(FLOPPY_IRQ, int, 0);
> module_param(FLOPPY_DMA, int, 0);
> MODULE_AUTHOR("Alain L. Knaff");
> +MODULE_DESCRIPTION("Normal floppy disk support");
> MODULE_LICENSE("GPL");
>
> /* This doesn't actually get used other than for module information */
>
> ---
> base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
> change-id: 20240602-md-block-floppy-1984117350ec
>
Reviewed-by: Denis Efremov <efremov@linux.com>
Thanks,
Denis
next prev parent reply other threads:[~2024-06-03 10:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-03 0:05 [PATCH] floppy: add missing MODULE_DESCRIPTION() macro Jeff Johnson
2024-06-03 10:35 ` Denis Efremov (Oracle) [this message]
2024-07-09 19:56 ` Jeff Johnson
2024-07-10 6:23 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3a27dbe-091a-43d0-aac8-eebb4e2833d4@linux.com \
--to=efremov@linux.com \
--cc=axboe@kernel.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox