* [PATCH] floppy: add missing MODULE_DESCRIPTION() macro
@ 2024-06-03 0:05 Jeff Johnson
2024-06-03 10:35 ` Denis Efremov (Oracle)
2024-07-10 6:23 ` Jens Axboe
0 siblings, 2 replies; 4+ messages in thread
From: Jeff Johnson @ 2024-06-03 0:05 UTC (permalink / raw)
To: Denis Efremov, Jens Axboe
Cc: linux-block, linux-kernel, kernel-janitors, Jeff Johnson
make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/floppy.o
Add the missing invocation of the MODULE_DESCRIPTION() macro.
Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
---
drivers/block/floppy.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 25c9d85667f1..854a88cf56bd 100644
--- a/drivers/block/floppy.c
+++ b/drivers/block/floppy.c
@@ -5016,6 +5016,7 @@ module_param(floppy, charp, 0);
module_param(FLOPPY_IRQ, int, 0);
module_param(FLOPPY_DMA, int, 0);
MODULE_AUTHOR("Alain L. Knaff");
+MODULE_DESCRIPTION("Normal floppy disk support");
MODULE_LICENSE("GPL");
/* This doesn't actually get used other than for module information */
---
base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
change-id: 20240602-md-block-floppy-1984117350ec
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] floppy: add missing MODULE_DESCRIPTION() macro
2024-06-03 0:05 [PATCH] floppy: add missing MODULE_DESCRIPTION() macro Jeff Johnson
@ 2024-06-03 10:35 ` Denis Efremov (Oracle)
2024-07-09 19:56 ` Jeff Johnson
2024-07-10 6:23 ` Jens Axboe
1 sibling, 1 reply; 4+ messages in thread
From: Denis Efremov (Oracle) @ 2024-06-03 10:35 UTC (permalink / raw)
To: Jeff Johnson, Jens Axboe; +Cc: linux-block, linux-kernel, kernel-janitors
On 6/3/24 04:05, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/floppy.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> ---
> drivers/block/floppy.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
> index 25c9d85667f1..854a88cf56bd 100644
> --- a/drivers/block/floppy.c
> +++ b/drivers/block/floppy.c
> @@ -5016,6 +5016,7 @@ module_param(floppy, charp, 0);
> module_param(FLOPPY_IRQ, int, 0);
> module_param(FLOPPY_DMA, int, 0);
> MODULE_AUTHOR("Alain L. Knaff");
> +MODULE_DESCRIPTION("Normal floppy disk support");
> MODULE_LICENSE("GPL");
>
> /* This doesn't actually get used other than for module information */
>
> ---
> base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
> change-id: 20240602-md-block-floppy-1984117350ec
>
Reviewed-by: Denis Efremov <efremov@linux.com>
Thanks,
Denis
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] floppy: add missing MODULE_DESCRIPTION() macro
2024-06-03 10:35 ` Denis Efremov (Oracle)
@ 2024-07-09 19:56 ` Jeff Johnson
0 siblings, 0 replies; 4+ messages in thread
From: Jeff Johnson @ 2024-07-09 19:56 UTC (permalink / raw)
To: efremov, Jens Axboe; +Cc: linux-block, linux-kernel, kernel-janitors
On 6/3/2024 3:35 AM, Denis Efremov (Oracle) wrote:
> On 6/3/24 04:05, Jeff Johnson wrote:
>> make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/floppy.o
>>
>> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>
>> ---
>> drivers/block/floppy.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
>> index 25c9d85667f1..854a88cf56bd 100644
>> --- a/drivers/block/floppy.c
>> +++ b/drivers/block/floppy.c
>> @@ -5016,6 +5016,7 @@ module_param(floppy, charp, 0);
>> module_param(FLOPPY_IRQ, int, 0);
>> module_param(FLOPPY_DMA, int, 0);
>> MODULE_AUTHOR("Alain L. Knaff");
>> +MODULE_DESCRIPTION("Normal floppy disk support");
>> MODULE_LICENSE("GPL");
>>
>> /* This doesn't actually get used other than for module information */
>>
>> ---
>> base-commit: a693b9c95abd4947c2d06e05733de5d470ab6586
>> change-id: 20240602-md-block-floppy-1984117350ec
>>
>
> Reviewed-by: Denis Efremov <efremov@linux.com>
I don't see this in linux-next yet so following up to see if anything else is
needed to get this merged.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] floppy: add missing MODULE_DESCRIPTION() macro
2024-06-03 0:05 [PATCH] floppy: add missing MODULE_DESCRIPTION() macro Jeff Johnson
2024-06-03 10:35 ` Denis Efremov (Oracle)
@ 2024-07-10 6:23 ` Jens Axboe
1 sibling, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2024-07-10 6:23 UTC (permalink / raw)
To: Denis Efremov, Jeff Johnson; +Cc: linux-block, linux-kernel, kernel-janitors
On Sun, 02 Jun 2024 17:05:31 -0700, Jeff Johnson wrote:
> make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/floppy.o
>
> Add the missing invocation of the MODULE_DESCRIPTION() macro.
>
>
Applied, thanks!
[1/1] floppy: add missing MODULE_DESCRIPTION() macro
commit: 3c1743a685b19bc17cf65af4a2eb149fd3b15c50
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-07-10 6:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-03 0:05 [PATCH] floppy: add missing MODULE_DESCRIPTION() macro Jeff Johnson
2024-06-03 10:35 ` Denis Efremov (Oracle)
2024-07-09 19:56 ` Jeff Johnson
2024-07-10 6:23 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox