From: "Randy Dunlap" <rdunlap@xenotime.net>
To: "Jim Cromie" <jim.cromie@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
"Jim Cromie" <jim.cromie@gmail.com>
Subject: Re: [PATCH 1/3] do collectcfiles work in perl itself, eschew shell pipeline
Date: Sun, 22 May 2011 19:16:17 -0700 [thread overview]
Message-ID: <f3b1b41cec770d7cca99849e22fa9946.squirrel@xenotime.net> (raw)
In-Reply-To: <1305966108-13399-2-git-send-email-jim.cromie@gmail.com>
On Sat, May 21, 2011 1:21 am, Jim Cromie wrote:
> sub collectcfiles {
> - my @file
> - = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko$/.mod.c/`;
> + my @file;
> + while (<.tmp_versions/*.mod>) {
> + open my $fh, '<', $_ or die "cant open $_: $!\n";
Use either "can't" or "cannot". "cant" is a different word.
> + push (@file,
> + grep s/\.ko/.mod.c/, # change the suffix
> + grep m/.+\.ko/, # find the .ko path
> + <$fh>); # lines in opened file
> + }
> chomp @file;
> return @file;
> }
--
~Randy
next prev parent reply other threads:[~2011-05-23 2:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-21 8:21 [PATCH 0/3] fixes, improvements on scripts/export_report.pl Jim Cromie
2011-05-21 8:21 ` [PATCH 1/3] do collectcfiles work in perl itself, eschew shell pipeline Jim Cromie
2011-05-23 2:16 ` Randy Dunlap [this message]
2011-05-21 8:21 ` [PATCH 2/3] sort SECTION 2 output of scripts/export_report.pl Jim Cromie
2011-05-21 8:21 ` [PATCH 3/3] in scripts/export_report.pl use warn() to issue WARNING, so they go to stderr Jim Cromie
2011-05-23 15:21 ` Randy Dunlap
2011-05-23 18:44 ` [PATCH 0/3 rev2] fix scripts/export_report.pl Jim Cromie
2011-05-23 18:44 ` [PATCH 1/3] do collectcfiles work in perl itself, eschew shell pipeline Jim Cromie
2011-05-23 18:44 ` [PATCH 2/3] sort SECTION 2 output of scripts/export_report.pl Jim Cromie
2011-05-23 18:44 ` [PATCH 3/3] in scripts/export_report.pl use warn() to issue WARNING, so they go to stderr Jim Cromie
2011-05-24 14:10 ` [PATCH 0/3 rev2] fix scripts/export_report.pl Michal Marek
2011-05-24 17:53 ` Jim Cromie
2011-05-25 12:15 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3b1b41cec770d7cca99849e22fa9946.squirrel@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=jim.cromie@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).