From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753219AbdKMPfD (ORCPT ); Mon, 13 Nov 2017 10:35:03 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:33682 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751605AbdKMPfC (ORCPT ); Mon, 13 Nov 2017 10:35:02 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D4F3560313 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=tbaicar@codeaurora.org Subject: Re: [PATCH V3 2/2] acpi: apei: call into AER handling regardless of severity To: Dongdong Liu , rjw@rjwysocki.net, tony.luck@intel.com, bp@alien8.de, bp@suse.de, will.deacon@arm.com, james.morse@arm.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas References: <1510168392-30114-1-git-send-email-tbaicar@codeaurora.org> <1510168392-30114-3-git-send-email-tbaicar@codeaurora.org> From: Tyler Baicar Message-ID: Date: Mon, 13 Nov 2017 10:34:58 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/13/2017 7:36 AM, Dongdong Liu wrote: > > 在 2017/11/9 3:13, Tyler Baicar 写道: >> Currently the GHES code only calls into the AER driver for >> recoverable type errors. This is incorrect because errors of >> other severities do not get logged by the AER driver and do not >> get exposed to user space via the AER trace event. So, call >> into the AER driver for PCIe errors regardless of the severity > > It will also call do_recovery() regardless of the severity for AER correctable > errors. > Correctable errors include those error conditions where hardware can recover > without any loss of information. > Hardware corrects these errors and software intervention is not required. > So we'd better modify the code as below. > diff --git a/drivers/pci/pcie/aer/aerdrv_core.c > b/drivers/pci/pcie/aer/aerdrv_core.c > index 7448052..a7f77549 100644 > --- a/drivers/pci/pcie/aer/aerdrv_core.c > +++ b/drivers/pci/pcie/aer/aerdrv_core.c > @@ -633,7 +633,8 @@ static void aer_recover_work_func(struct work_struct *work) >                         continue; >                 } >                 cper_print_aer(pdev, entry.severity, entry.regs); > -           do_recovery(pdev, entry.severity); > +         if(entry.severity != AER_CORRECTABLE) > +                 do_recovery(pdev, entry.severity); >                 pci_dev_put(pdev); >         } >  } Hello Dongdong, Yes, I have a patch for this that needs to be picked up. https://lkml.org/lkml/2017/8/28/848 Thanks, Tyler -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.