From: Krzysztof Kozlowski <krzk@kernel.org>
To: Robert Marko <robert.marko@sartura.hr>,
srini@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, horatiu.vultur@microchip.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
daniel.machon@microchip.com
Cc: luka.perkov@sartura.hr
Subject: Re: [PATCH 1/2] dt-bindings: nvmem: lan9662-otpc: Add LAN969x series
Date: Sun, 26 Oct 2025 11:10:09 +0100 [thread overview]
Message-ID: <f3bd99c8-eb70-40d3-9b43-fba56546f591@kernel.org> (raw)
In-Reply-To: <20251024192532.637563-1-robert.marko@sartura.hr>
On 24/10/2025 21:24, Robert Marko wrote:
> LAN969x series also has the same HW block, its just 16KB instead of 8KB
> like on LAN966x series.
>
> So, document compatibles for the LAN969x series.
>
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
> .../devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml b/Documentation/devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml
> index f97c6beb4766..f8c68cf22c1c 100644
> --- a/Documentation/devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/microchip,lan9662-otpc.yaml
> @@ -23,8 +23,15 @@ properties:
> - items:
> - const: microchip,lan9668-otpc
> - const: microchip,lan9662-otpc
> + - const: microchip,lan9691-otpc
> + - const: microchip,lan9692-otpc
> + - const: microchip,lan9693-otpc
> + - const: microchip,lan9694-otpc
> + - const: microchip,lan9696-otpc
> + - const: microchip,lan9698-otpc
Why are you changing lan9668? Nothing on this is explained in commit
msg. Also, list of more than 3 items is not really useful.
> - enum:
> - microchip,lan9662-otpc
> + - microchip,lan9691-otpc
Why is it listed twice? First you say lan9662 is compatible with
lan9691, now you say it is not.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-26 10:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-24 19:24 [PATCH 1/2] dt-bindings: nvmem: lan9662-otpc: Add LAN969x series Robert Marko
2025-10-24 19:24 ` [PATCH 2/2] nvmem: lan9662-otp: add support for LAN969x Robert Marko
2025-10-26 10:10 ` Krzysztof Kozlowski [this message]
2025-10-27 12:23 ` [PATCH 1/2] dt-bindings: nvmem: lan9662-otpc: Add LAN969x series Robert Marko
2025-10-27 13:42 ` Krzysztof Kozlowski
2025-10-27 18:22 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f3bd99c8-eb70-40d3-9b43-fba56546f591@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.machon@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=horatiu.vultur@microchip.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=robert.marko@sartura.hr \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox