From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 424883D2FF7 for ; Thu, 30 Apr 2026 09:46:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777542370; cv=none; b=UzVi4jTqmElscvugsq3QhbQt4jlK8Q6tCF727mEhkLm6PfPQlYIXYpbEHgZPrOjqupoWPIf/hKzYIxxy3qAGLXabIygq0kJXzkXKO0lgDrBQv3AX5D0MTABr0+rHI4gWt58l0emXiB+WeNaKr+eID80VN2sdS/NsmLYZr00qqOM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777542370; c=relaxed/simple; bh=woRvBPn/VL2arW37XBup5O5UydeDIXiz/UmZy+ONkWo=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=u7q+GtHH8dRHz7lmnr9gfQ+PWeQh4Xy1XFy+Ttvwqvq/mvaUrqc4UUr8eXyek3cvnJtGlu5j4YhAmJG3PEyYumb5wHG+JALBMLIiLaDepo/BTWLXDsizNwhe7DQ/T/YSDrPdenVGdLbc/qRPpm8rJSEor3NPWVwxdC5tk954Qxw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=eZLLJKGN; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eZLLJKGN" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-43d7645adbdso479133f8f.1 for ; Thu, 30 Apr 2026 02:46:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1777542367; x=1778147167; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=sz6Ai6P4Nx2rPtIOkXtAQOJrKasr5iAAQ5nvgpjOt+M=; b=eZLLJKGNdctLutxOWmV5ooKrSibjzTnhTdyPg8l/Ba5R1hAh+3UW6mfcmyf7/P6Sgc HhuhmCqMjXRfi+TI34Qits+uuBiPtvrOSr8evPA5eKtSVg4PmV6TLOBSPb82lKQi23Sf m+SmINbCIYEBucvU4WZvi3q0MAUlBtvQGeWG4KhVRQwEvLIX2WRA8I+IPQtNs3n9x0No 5NWlFDMIhknmlXy2kgxx0unoEe6RDj1Xnyu4xVmw4f4xgrLF9EgY3DAPHw0d/ltIzRPx VQimGRy5S6+sIlyC61aV593A7rhDCB1LsCnr2GJcZnrbg37WBV0oKHNKcP4vV56isBtm RMbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777542367; x=1778147167; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sz6Ai6P4Nx2rPtIOkXtAQOJrKasr5iAAQ5nvgpjOt+M=; b=NuLzYGRRPrN95E2FORR+RRxe0+bZ0naXHt6N7n5meAsF9XP0TdgF/DbOBMvapFvRpi dFn04bdWALCkIRuYv3DSmtNxjvtomi3EPOW3pYMgpLmc7b3rPxpOXXMhY/vIpKqc+dbH /fSIduA+ZiCEOMUwNrT7lNajGrKjgZ9BB4PUn4nezpk8IHgz2knHUtvvgRyAX8EkPBjM 1BxjlMPQIsOYkb9HS8URyQrTVJkTuHM70l426rSx5DDXatDkAiWNY6X6AFF8YY//4nTZ 7//SpY3OUxn98vqH6bRCQdKs/gJilqR4SgJuHJ6GrYw/GkDF/F0uFaLN7N0/TgAC18ZR Rz5w== X-Forwarded-Encrypted: i=1; AFNElJ8NOrMlkSH4l4SHp/vNkTTXkizY2tscLLKqE3+VtpfSLwkGn5e6ws5Secp45aVgNKI01VukNfYM0ApTWOs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw13X+Uug3WOLKHpjFtpMNbk2Fp3ZDzWiojRT49wC7oBsUkQDEo V2c7MQmOJUKjIlVvIvwH+/UKXnRJf1QlFC1To9QRVRl0ixpPgrMJm5Jwhy0qzAgEk0k= X-Gm-Gg: AeBDietIUZuHjiRzjTsb5RBNPf3SYfND7xM7jSHX6h6n7RKrSreS1yAUJ8/y+150Cmc NtUDNPkD+GwK0wvel53UyE1FtbP5+MJemlasFRc0EdbEh/KWQuG+UVO8v0D/JUyxkcmqYFT1nz8 ap5vQ7XgoQoz2/qc7gHKWn3Ob1X8z0Zye9MLPQMl4PNnANpGF6C5wykgyBNiBtbDUbhlum/VJzq nE9dL5hXobVF361LavlwNNP8DNhj1wYeAPsLSA/QzPC5umQZlh5avBbyweLPwJkKUsGzm1hVOGf vte8MXZNC7CjvRdOLltHPfgzGM0LDRmDcbO7XWW4PQSHReogoY+WgJ7ShZACr5xNhSey/5xqmx2 c8ezedKQRst3emCLInPUzGuAweh2eA1e7zqFsi/MlH1SL9sd7lfwGtSYtUsp0sPzCY9vgFTmgPt 1WhQN0YMxaSoJ9qKVHZ+F4HRF0z0T/3Rpk9rP7JdAqG/TUv+p/sO/9WpySvVIMQd5VNf3ckx/3f BYDv5kbSRu6Gvxe1Q== X-Received: by 2002:a05:6000:2088:b0:43d:75ec:26e7 with SMTP id ffacd0b85a97d-4493fed67admr3286239f8f.33.1777542367393; Thu, 30 Apr 2026 02:46:07 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:6dcc:3980:fe87:c6ae? ([2a01:e0a:106d:1080:6dcc:3980:fe87:c6ae]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-447b4216ecasm12188829f8f.14.2026.04.30.02.46.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2026 02:46:06 -0700 (PDT) Message-ID: Date: Thu, 30 Apr 2026 11:46:05 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH] drm/panel: jadard-jd9365da-h3: Fix signedness bug To: Ethan Tidmore , Jagan Teki Cc: Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Linus Walleij , Dmitry Baryshkov , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260429024954.697411-1-ethantidmore06@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260429024954.697411-1-ethantidmore06@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/29/26 04:49, Ethan Tidmore wrote: > The function drm_of_get_data_lanes_count_remote() returns negative error > codes and dsi->lanes is an unsigned integer, so the check (dsi->lanes < > 0) is always impossible. > > Detected by Smatch: > drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c:2959 jadard_dsi_probe() > warn: unsigned 'dsi->lanes' is never less than zero. > > Fixes: eb019688f2a97 ("drm/panel: jadard-jd9365da-h3: support variable DSI configuration") > Signed-off-by: Ethan Tidmore > --- > drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c > index 7157b1299bfd..f6b04de1182e 100644 > --- a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c > +++ b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c > @@ -2955,9 +2955,11 @@ static int jadard_dsi_probe(struct mipi_dsi_device *dsi) > dsi->format = desc->format; > dsi->lanes = desc->lanes; > if (!dsi->lanes) { > - dsi->lanes = drm_of_get_data_lanes_count_remote(dsi->dev.of_node, 0, -1, 2, 4); > - if (dsi->lanes < 0) > - return dsi->lanes; > + ret = drm_of_get_data_lanes_count_remote(dsi->dev.of_node, 0, -1, 2, 4); > + if (ret < 0) > + return ret; > + dsi->lanes = ret; > + > if (dsi->lanes == 4) { > if (!desc->mode_4ln) { > dev_err(&dsi->dev, "4-lane config is not supported\n"); Reviewed-by: Neil Armstrong Thanks, Neil