From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966154AbcIYLLV (ORCPT ); Sun, 25 Sep 2016 07:11:21 -0400 Received: from mout.web.de ([212.227.15.4]:61155 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938386AbcIYLLS (ORCPT ); Sun, 25 Sep 2016 07:11:18 -0400 Subject: [PATCH 1/5] ISDN-CAPI: Use kmalloc_array() in capidrv_addcontr() To: netdev@vger.kernel.org, Karsten Keil References: Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: Date: Sun, 25 Sep 2016 13:11:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:vYrKOBzU7/pInPHwVyraOeZSWTmXENco34Ep51DlMtx/7f+4WPp f0tBBf+19RXoo8LtxX0tst/Mzv1ecbdQslQBNwKUwpnYNGvzoaZfOaoyzY3FOxpXdVydkCw CZbIH0CZnmkqluS88D55h82Iig0PGAH64kS94AeAmq0FEBfhtTC4NdW9GyYcpKDiqMZD9++ R2H+9oCVDj8vCcMGyQbDw== X-UI-Out-Filterresults: notjunk:1;V01:K0:B0ATqguhHs4=:pEi5v6wUBLJX4ntpUjZ8Y5 WA5RrUZVYISf+7OH+X1nf5DhiJFVewEYvHlcFPGS3tQ9KochGEd1Hea0HYEVRvBcZ20fBcrpR 6YUbdPBPp5RfY4LkaTVgLKpmNjLY7f+uevpeCK+AoD1abY43vLefsNjhZihpJlqNlNX2JZlLg tYOf/MG8ngEjMySOLCFf18ktYtoUln6Nwwye2N55V8YogcfALIUyWpph3XjcZmfS5sMM0DrVM zFA0RLq8ga3bWIW7zbDgqInmAmr2i25gPnELG88N3gDaP6gVHMsRJXA0V/Qn82d/FzfqzIfa9 Q8E/lVzfZcIKEbJ58DHK99+SY3Uz8y8zrBzcMcv2QKgFMCGMq1SWI1ORa5YU3BQk5Kvpxym+U CMBG0jO5lx7IG7b3papqNKDiDEK01to/aYCC16D+cblKsfh2/QLg+CZPbVuFINE6i+L+ivAhB 5nhY3xWfNLyh2vH5e0f/3aB6QKJz2vVtDeUxsL/RT6pqn7WZEAPutmYriI9xTXGSkca55ytpr 9mMaTJ4NaAIVhhGILKTeGLhHkEa/CZ0c3D/3MmizBIgBD5vzG6v5OHhCUyLxC1eiuzs64jdFp b1gdAf31KAPGzquAGHK9SqZABEsENSsKpLAwGP8SsMes73u0UaBibn9SlSmJWrRtdf/Mrw76R u9e6Q2r9uxTepA91erHreowHFGThc7zLZcuMFJhsuXD+3VIG4b2toUdMM6UL3ANPFonJRjp/w l7roHiTYEZWFXHPJM5tzCVkI46+glGUp4C/Hj38cSq3HLphaomC0xa3e0VRgFodjp3xHEQ1ZS SARhGJj Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 25 Sep 2016 11:06:17 +0200 A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/isdn/capi/capidrv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/isdn/capi/capidrv.c b/drivers/isdn/capi/capidrv.c index 85cfa4f..cd8e1a6 100644 --- a/drivers/isdn/capi/capidrv.c +++ b/drivers/isdn/capi/capidrv.c @@ -2268,7 +2268,9 @@ static int capidrv_addcontr(u16 contr, struct capi_profile *profp) strcpy(card->name, id); card->contrnr = contr; card->nbchan = profp->nbchannel; - card->bchans = kmalloc(sizeof(capidrv_bchan) * card->nbchan, GFP_ATOMIC); + card->bchans = kmalloc_array(card->nbchan, + sizeof(capidrv_bchan), + GFP_ATOMIC); if (!card->bchans) { printk(KERN_WARNING "capidrv: (%s) Could not allocate bchan-structs.\n", id); -- 2.10.0