From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757609AbeBPJLY (ORCPT ); Fri, 16 Feb 2018 04:11:24 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:54872 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757595AbeBPJLW (ORCPT ); Fri, 16 Feb 2018 04:11:22 -0500 X-Google-Smtp-Source: AH8x224oc6jgvQhX1NtqShRt39S4VT/fLbeF2pfccpJ0KzJuQFGsueq9KpkMlyAbH25CGLgYcwjhng== Subject: Re: [PATCH 8/8] thermal/drivers/cpu_cooling: Add the combo cpu cooling device To: Viresh Kumar Cc: edubezval@gmail.com, kevin.wangtao@linaro.org, leo.yan@linaro.org, vincent.guittot@linaro.org, amit.kachhap@gmail.com, linux-kernel@vger.kernel.org, Zhang Rui , Javi Merino , "open list:THERMAL" , daniel.thompson@linaro.org References: <1516721671-16360-1-git-send-email-daniel.lezcano@linaro.org> <1516721671-16360-9-git-send-email-daniel.lezcano@linaro.org> <20180202104259.GA28462@vireshk-i7> <8dadd854-25ac-68aa-aa9f-33ba76a137a4@linaro.org> <20180209094419.GN28462@vireshk-i7> From: Daniel Lezcano Message-ID: Date: Fri, 16 Feb 2018 10:11:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180209094419.GN28462@vireshk-i7> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/02/2018 10:44, Viresh Kumar wrote: > On 02-02-18, 15:30, Daniel Lezcano wrote: >> Agree the cpufreq driver can be unloaded and this part needs some >> adjustments. > > Also note that the cpufreq cooling device has two separate set of > callbacks, one for the power-specific callbacks. You haven't taken > care of them in the combo thing. The plan is add them after. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog