From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E1D936EA9A for ; Mon, 27 Apr 2026 07:20:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777274450; cv=none; b=aMesGCgOF/V4jr7dAq7HDYLYn4J876kHchXyEI42ZAtulQSWlvCmVIoRbIZEzvrI3Gke3i5L0alCmqv1Zt9yQz+tCkqXOk9cpWFC3KrbgLfglG99O+FRVA4Sx8N/7WWTQU4ZRh9QvLdiu6YgllpSH3zrIPBefen/Us/kPyh/S30= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777274450; c=relaxed/simple; bh=o9f762Gf9TU4Xcf3RUmv4xe1w+G1LPDPNbt+IgF6tjs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uGFrAzwiALB2eptpP9rLlKz1YJzRlSw0Bb6zitUtmiTzRO95IRP5oF4cnxGxp5C/vCrX/o3Pd4I5yB5IMcNMll73bOQWLi5dSHkie97yd2rcxHhLjsUeZ8BkYaX+6g9aW70YwYsJHiM/6jy5vFLkBIl6hySOetOFNT5bRkDqmi4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KIMErKLP; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=D3X3Vfch; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KIMErKLP"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="D3X3Vfch" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63QLOH5S3646807 for ; Mon, 27 Apr 2026 07:20:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7PmnkfFyBl7ajnSl177EBYWpYk1Eo9oHSOysxEGNHNM=; b=KIMErKLPlETn3HjY tQNcunp5B8oH67/o/f6xIg/G0QtRFQCrR5oyZ3PL5CFl+rTr0D2tLnMLC16sMPGB TcrdJufvPgRux5+3PqPGblfGIY9yXhqVvpUTcqO/UkK1/5KGd4gBUZWxY92V8cVj G0lSN4MNK5jRDNkHekrNFvfpt3bdMMUZDgNCpz2cnJ3v7L3r9aQrbM2YXYDyAodP efIfc/YutxSBHG9x49MFtCTCGtZCdhhiioMvnPBpaFG8ZuX98H/lUJCgrqepcu3t Q1m/ran42opvHcDWAiR/y3V9J0xeDgfB6nDugHQL6gcouk0DdZ34uOjkgb9zhxnz M+LLeA== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4drnpw4wcm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 27 Apr 2026 07:20:47 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2b24af7ca99so135123165ad.1 for ; Mon, 27 Apr 2026 00:20:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777274447; x=1777879247; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7PmnkfFyBl7ajnSl177EBYWpYk1Eo9oHSOysxEGNHNM=; b=D3X3VfchKNl0alXmYl8L/L9YlVY+3LNkXzm4NvqaiXs8YpJXY7GucyVM2oJi2ZAYvq pVc3iHvqb6NyPMaLuFDxZQviaTBmyD8k4W2yQNJdaw85BiS4wqQ9I6Oftl4apLip+H1L FkFpkD1b5KSIm+TZos7ghzUVRsXOYTpIeY5O5m24zmBu711n77tYyrB6ZELhZeJ+zUcf L+taxGo2qJKmm21diqv3AdUD3QZTdmyiLKxuU7O9LjialIvObF59THOIhnyivYlClOY5 V2x8nXPfyG1SQokwZirHdzJ0wnAibPedfWFCyt699tc8ZCqWNy5/1lFhJhOo6CXvAptE xjmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777274447; x=1777879247; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7PmnkfFyBl7ajnSl177EBYWpYk1Eo9oHSOysxEGNHNM=; b=DeDzu+HOoM/JSfHGtZhZqZOF19AaDOVB/xvETJxu6bej2OZNiNJGc+7qlmH73nKvx/ fRepmEQs/vdrr1pud6ITBMvv0Oa+/hB65Hh3y0PuSv2+z77odaKhX57MozLSiQl2c3v7 C6Z2A5YmOr/A3HCW/6Qtm7rXIBxgAqRiuy1q7DkAi3q6TLlDqzCy8dOApdhj5ZjSjYDC f45SvAshx+X3dv96c8WgfcULxiaAKN3L3c7iv43gCNTOde/hjNg6yet0MD7KywlNbp5t IqipS3NuzfH3JKrKpZANEwN3S1dLzo1BP+aHOrXVlwXP2L0y0tS0woCtwuvxokCXlRIP HRqg== X-Forwarded-Encrypted: i=1; AFNElJ/iSEK059DDnL2necSk7u1HbwZ8p573zJGvYl+YV5P5ok0/IfSnN9GKPpHiHf3Ttk1L1o5Cv3vkTp8oHec=@vger.kernel.org X-Gm-Message-State: AOJu0YwnlyAQOSaRuQwvYq6aHOF1VVirM8Jxisrrd03MjOJNUoydK2XW RIk/+OtjPz5yk+piVP/tFsMV7UaNQBi+bEK1nTgLILzoF+eyiv6hEVo3pm13n8Nj12h/UYduETJ 9AD+J++83fsKWuN44Nil7nO2iOG5zsCPjsQQ/79SldsSSJnaXjDq/rnMpGpBH38sboxcfjQVWHN 8= X-Gm-Gg: AeBDieuGAS0N8UkZ81/BtKuzon2f0VBzbQt0IExnzhSCr1wqR6sWaZgph7YaVsB2bVY qaGfLegkpW3IWkRP6OTCKe+UXr64Zqj8lGVCttsFj8XaB8df0avgoy5i8OYO4heP0763/sTnn28 5yBdjMV4Cv2CmqPXxWFU7jiLJhk03fMw3ofWtMk33bUfOK9lrlO1fbBim0ywbqT75ZNXuwglZcb GRmrn44DMxdQGN5leqI7xzy8HD4Rz1rWBOQ/bzBH73ZRFDFSu36M4h0RHQAYSF4SZ6Xtq6/KI8Y vGSw8SuEfaUwasbmZZpsNqRL+/4gGTMLWeUvzhHu7qJ5xp4h/dBvHAfEnob/l8+xbgJ9WMrRBVz BjJTOyn20lSV7NLH7dDUERPLRoD2M4o6Ue+hgwGyUTYeekZS31Fglrbu+3+1VLw== X-Received: by 2002:a17:903:8c6:b0:2b0:c45a:bc2 with SMTP id d9443c01a7336-2b5f9eddc7emr446294665ad.16.1777274446568; Mon, 27 Apr 2026 00:20:46 -0700 (PDT) X-Received: by 2002:a17:903:8c6:b0:2b0:c45a:bc2 with SMTP id d9443c01a7336-2b5f9eddc7emr446294365ad.16.1777274446032; Mon, 27 Apr 2026 00:20:46 -0700 (PDT) Received: from [10.217.223.121] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b5fab3ac1fsm315877045ad.70.2026.04.27.00.20.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Apr 2026 00:20:45 -0700 (PDT) Message-ID: Date: Mon, 27 Apr 2026 12:50:40 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] dt-bindings: crypto: qcom,inline-crypto-engine: Document Nord ICE To: Shawn Guo , Herbert Xu Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , Bartosz Golaszewski , Deepti Jaggi , linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260427010527.230473-1-shengchao.guo@oss.qualcomm.com> Content-Language: en-US From: Harshal Dev In-Reply-To: <20260427010527.230473-1-shengchao.guo@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI3MDA3NyBTYWx0ZWRfX80p/CeHsHFHR xsnS2cIzkYojdKLWKdMCu1Bz7IU1E6llXot7SBCD6zEMIkJ95waRInA8xYCiKIqlfBA7nlQgFzi MoIWAzayXX2C4T8I7EoOKU8hQEdaBjwQGOt3xVZatiR1RnqDTyn1bQFf+uLdmfYW1/iuHfOZUwJ QotuWowpPVrVDQzYTOQ+GyX5VMx8GQ5f7Dd+HVPsOWWbGZAC1aSS9koL0AmcOvDs5l321ZXOfUV 9WiCPtt2e4r9roWbWKOTD1xiUlRB8zJ4+/RAYV1ZTpBQpyQdBy6+7idvlsMrWUnwbjgI/Ch1lPC zB7Xxyi+T70Y7mSRCY8bm4XrHJFN17TcyvNiIPQMiLEyWC5JMmlyUO5R3T3gL0y7DhRJhoqrnA/ NRhKyv6jwQhYgbyEbYJukTBj9KYJw9quGVupn4Z4TzIhSPtEyvaOucora1oqMQGZJekdJZ+VhcS mQ2bc0L47rIwvBqmtGw== X-Proofpoint-ORIG-GUID: ghf6mVRjCOSzU7icqJN7qZ0PdTmCyksD X-Authority-Analysis: v=2.4 cv=RaGgzVtv c=1 sm=1 tr=0 ts=69ef0e4f cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=JrGBsv4J1yBW9PuSV2wA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: ghf6mVRjCOSzU7icqJN7qZ0PdTmCyksD X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-27_02,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 bulkscore=0 malwarescore=0 lowpriorityscore=0 phishscore=0 spamscore=0 clxscore=1015 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604270077 Hi Shawn, On 4/27/2026 6:35 AM, Shawn Guo wrote: > Document Inline Crypto Engine (ICE) on Qualcomm Nord SoC which is > compatible with 'qcom,inline-crypto-engine'. > > Signed-off-by: Shawn Guo > --- > Changes in v2: > - Improve commit log to make the compatibility explicit > - Link to v1: https://lore.kernel.org/all/20260420073301.1250197-1-shengchao.guo@oss.qualcomm.com/ > > .../devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml > index 876bf90ed96e..9251db2b8fcd 100644 > --- a/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml > +++ b/Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml > @@ -16,6 +16,7 @@ properties: > - qcom,eliza-inline-crypto-engine > - qcom,kaanapali-inline-crypto-engine > - qcom,milos-inline-crypto-engine > + - qcom,nord-inline-crypto-engine Wanted to bring your attention to this patch we are hoping to send for 7.1 fixes window which mandates the iface clock and power-domain for ICE (from Eliza/Milos onwards) to avoid issues seen when these properties are missing: https://lore.kernel.org/all/20260416-qcom_ice_power_and_clk_vote-v5-1-5ccf5d7e2846@oss.qualcomm.com/ While I won't ask you to adjust your patch immediately, if our patch is merged, would request you to update this binding to comply with the newly introduced ones such that the iface clock and power-domain are made mandatory for Nord as well. Regards, Harshal