[PATCH] rtc: amlogic-a4: Optimize global variables

[PATCH] rtc: amlogic-a4: Optimize global variables

[Xianwei Zhao via B4 Relay]

From: Xianwei Zhao <xianwei.zhao@amlogic.com>

Use local variables struct regmap_config instread of global
variables. The goal of saving memory has been achieve.

Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
---
Use local variables struct regmap_config instread of global
variables. 
---
 drivers/rtc/rtc-amlogic-a4.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/rtc/rtc-amlogic-a4.c b/drivers/rtc/rtc-amlogic-a4.c
index 09d78c2cc691..1928b29c1045 100644
--- a/drivers/rtc/rtc-amlogic-a4.c
+++ b/drivers/rtc/rtc-amlogic-a4.c
@@ -72,13 +72,6 @@ struct aml_rtc_data {
 	const struct aml_rtc_config *config;
 };
 
-static const struct regmap_config aml_rtc_regmap_config = {
-	.reg_bits = 32,
-	.val_bits = 32,
-	.reg_stride = 4,
-	.max_register = RTC_REAL_TIME,
-};
-
 static inline u32 gray_to_binary(u32 gray)
 {
 	u32 bcd = gray;
@@ -328,6 +321,13 @@ static int aml_rtc_probe(struct platform_device *pdev)
 	void __iomem *base;
 	int ret = 0;
 
+	const struct regmap_config aml_rtc_regmap_config = {
+		.reg_bits = 32,
+		.val_bits = 32,
+		.reg_stride = 4,
+		.max_register = RTC_REAL_TIME,
+	};
+
 	rtc = devm_kzalloc(dev, sizeof(*rtc), GFP_KERNEL);
 	if (!rtc)
 		return -ENOMEM;

---
base-commit: 0bafe291cb429d39b5ff70bcf7b2f3ab026dcb02
change-id: 20250717-rtc-regmap-140ee38b7bf7

Best regards,
-- 
Xianwei Zhao <xianwei.zhao@amlogic.com>

Re: [PATCH] rtc: amlogic-a4: Optimize global variables

[Markus Elfring]

> Use local variables struct regmap_config instread of global

            variable?                      instead?


> variables. The goal of saving memory has been achieve.

                                                achieved?

You may occasionally put more than 59 characters into text lines
of such a change description.


…
> ---
> Use local variables struct regmap_config instread of global
> variables. 
> ---
>  drivers/rtc/rtc-amlogic-a4.c | 14 +++++++-------
…

Please avoid duplicate information here.


Can a summary phrase like “Convert a global variable into a local one
of aml_rtc_probe()” be more appropriate?

Regards,
Markus

Re: [PATCH] rtc: amlogic-a4: Optimize global variables

[Xianwei Zhao]

Hi Markus,
    Thanks for your advice.

On 2025/7/17 23:42, Markus Elfring wrote:
> [Some people who received this message don't often get email from markus.elfring@web.de. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
> 
> [ EXTERNAL EMAIL ]
> 
>> Use local variables struct regmap_config instread of global
> 
>              variable?                      instead?
> 
> 
>> variables. The goal of saving memory has been achieve.
> 
>                                                  achieved?
> 
> You may occasionally put more than 59 characters into text lines
> of such a change description.
> 
> 
> …
>> ---
>> Use local variables struct regmap_config instread of global
>> variables.
>> ---
>>   drivers/rtc/rtc-amlogic-a4.c | 14 +++++++-------
> …
> 
> Please avoid duplicate information here.
> 
> 
> Can a summary phrase like “Convert a global variable into a local one
> of aml_rtc_probe()” be more appropriate?
> 

Will do.

> Regards,
> Markus