From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1ACC7265621 for ; Wed, 18 Mar 2026 15:01:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773846066; cv=none; b=GssRCMvyEiHCERw2sPHBU8ceLJgYiwRyAzqcE/op8BtrHdB1XlJHiI5G7mE+mfKLLSMuRHI3feAcNlHGPt1m0n8OsAbGgB94DHla5B4NS+ZNsvIAE/dtxNocKSYAdLwQlQ77zsnjDWVerU+Hs9buCIsw/wfUA7a4oTm02c8/LbY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773846066; c=relaxed/simple; bh=XAa6VmqtNtdLopFuNm9rW/yY4K2VDb8qrgNvEv0xz+I=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NzV/Rdz2XC8SWjdlkKts3els4so3JwIX2+/fPZrFywVMuE40wfv2zq4INnMJYKjXxhvjUDfUeu22peHtoth59X8BBC2LTN1xbAx8xEZScINJtzDkUGwBrmfemRZaVPeLs/qGMlRSGCo8dLo0+bBQ6wVOxp+wmrtKQaZMr/WCSg8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AtqAR6tM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CwltEIIw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AtqAR6tM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CwltEIIw" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62IBBAar320117 for ; Wed, 18 Mar 2026 15:01:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= GoRA2L8D/wURa/t15xJL/5XRoOAzSYwjg4eZrkQhmRQ=; b=AtqAR6tMi3ikpWkL in8e0PAi3EBWndJlXJobe6bmgyDzv2lkO+SkJOoZb6pRkKPjhAhtE4/qCbLXxG5o C69L+LZtpBAg00LODkiljNSvZ+jlxNUztu5kEHU5a3g+L8xaDCL1tFWJglhcpDRD AjXCL3C3ZbH9JbbuSOjqM0RS9Tm/9lWMwuyxj02QtagIBzgSz1biNYK08n/fL0rC t0fSKdq25gqKBxOMl+dZYg20x7gWEpzJwqu2DBubchpcHM0SelkUR5LNyPSxMf5W XT6mMDnH7ICg9U98Fcwfngn25xLUJ6ftJF4SKpHAZiemlSW7tRPJfQqyDL81SYV+ kM+Oxg== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cytxyrsea-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Mar 2026 15:01:03 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50937cf66b5so1046621771cf.3 for ; Wed, 18 Mar 2026 08:01:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773846063; x=1774450863; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=GoRA2L8D/wURa/t15xJL/5XRoOAzSYwjg4eZrkQhmRQ=; b=CwltEIIw7pn0LM7k7Av/xQPDtcSdKPy5zwS96jSjHbdJDeL/qt744cB7lVJzjaZZYW 0gIcgdi0wMjGN3Sau7tEblhWtAaE/liYV09Hvsj8tvzjpfGkiJMC0W02HPzPMvV4X5L0 OrrGQ+ECbA+8b5IGFRk9R43Sz33e58QXJYrwxlFTOsAlxrCavAtglJvAIFgtRionpArE 5C2u7v9zYJ+lKSXTg5Se1gev1wkVzj0U9XqWddhqoekMzdvAZ5rARE6zD/kV05OzDf3U thY1npWe/TUMTe6QkW0fmxZsTvsfhudtxlMWehmMDCYelnp7c3wkuhwqFb8Sh5UFcwz9 VymA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773846063; x=1774450863; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GoRA2L8D/wURa/t15xJL/5XRoOAzSYwjg4eZrkQhmRQ=; b=Vb8xDyP4NJzZdk/8974m78FqyhvBrqiYZG2wKA11YN/HmZrIp82ctZzG5G9lwPWqLm uTStjn47X3RRz+5nUfT8mvF0FHcMaPi6aKJC/xMHdP8wHp3vYs8Hi7dYMf8cw0KiydJc lNkfdxAFTU9wrD47tPFQE16ffxnoHKd5vrffIWNstARvK817rUvGGYskL8M9l23htLNd NKzlHLoygIubxO4y2QbM4p7CoV1jO4p3w3ydqHGTd7/JpoCKfEQQxmusih9ZMQMGN2Ds TUKqCrrmb1BFTs9jMIXP9BoTTiqEi1ubvKfOxPv5t1GeqENk4rjSFEAleiPDE1r60KCP qUwA== X-Forwarded-Encrypted: i=1; AJvYcCVEjbbEBDznVKcpG3I8v+TL6ByoXCdqNiQ0SBl55bNxe96On1BnCxTsl6EHt/y/hF7JzzIyu+Oec2h2+9o=@vger.kernel.org X-Gm-Message-State: AOJu0YwMdM4qE0ufuJA3yTP+8ZF+QffM42K4oIHvSn0qWzu9+5/rIjxm uXqobrT4xS0ENEUxkwaSgt8XW7soLtKU/Rvt4u5Hqb71DGZNWqAJ7E+0tK/95662gwlEL2jgJHU E/BSz8mNyENEtEwDYrEIwEf5jC2g3KLblOaefl0ZjfMsqOqggt7dhdp5LPJ2CAgNyuSU= X-Gm-Gg: ATEYQzxSbYCptgAh3gmFjAiNYACTStOOzUBP/5hT7CofKsef1OoB6NnaaGIt8ldqOPM Bxcl1F0Huix3xSCsarlgyomldSdqODxUDgSPY78GEzapI/D0N7xfHtPmh1yWBhYNEvravudUgNU PbwR3pcUkQGhG8Btde/qBjhxSFdbPAIu1eLPm+AanAI/Vn6woLgIBS8zFHCzN0M1KJiaE9AjbrR +IYNsO7pMbOHZqxTb9ZxkZGyOUmeCut4bDCyD63DaRqzLhyiC4A7MW/iw3RuzuMnx0DxE0TKDU8 tZKov/8THRKOvZjhoskZ6nUxrjH1NxxUmEFP5iI/JcnNkLH82+7Xk0XoXPPtXBsu6jP/FgnLzaV 3ROJ27eUKG6CqSlfA7t7fLTrR4gHphO4F0IZsAHrwxtRhM/fT X-Received: by 2002:ac8:5755:0:b0:509:4410:4492 with SMTP id d75a77b69052e-50b14796234mr47711701cf.22.1773846062602; Wed, 18 Mar 2026 08:01:02 -0700 (PDT) X-Received: by 2002:ac8:5755:0:b0:509:4410:4492 with SMTP id d75a77b69052e-50b14796234mr47710741cf.22.1773846061978; Wed, 18 Mar 2026 08:01:01 -0700 (PDT) Received: from [192.168.1.29] ([178.197.219.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4856eaee04fsm144565215e9.13.2026.03.18.08.01.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 08:01:01 -0700 (PDT) Message-ID: Date: Wed, 18 Mar 2026 16:00:59 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND 1/2] powerpc/ps3: Drop redundant result assignment To: "Christophe Leroy (CS GROUP)" , Segher Boessenkool Cc: Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Geoff Levand , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev References: <20260317130823.240279-3-krzysztof.kozlowski@oss.qualcomm.com> <9434f836-aa96-44e7-8f34-243d6c94f6dc@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@oss.qualcomm.com; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTpLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQG9zcy5xdWFsY29tbS5jb20+wsGXBBMB CgBBFiEEm9B+DgxR+NWWd7dUG5NDfTtBYpsFAmkknB4CGwMFCRaWdJoFCwkIBwICIgIGFQoJ CAsCBBYCAwECHgcCF4AACgkQG5NDfTtBYpuCRw/+J19mfHuaPt205FXRSpogs/WWdheqNZ2s i50LIK7OJmBQ8+17LTCOV8MYgFTDRdWdM5PF2OafmVd7CT/K4B3pPfacHATtOqQFHYeHrGPf 2+4QxUyHIfx+Wp4GixnqpbXc76nTDv+rX8EbAB7e+9X35oKSJf/YhLFjGOD1Nl/s1WwHTJtQ a2XSXZ2T9HXa+nKMQfaiQI4WoFXjSt+tsAFXAuq1SLarpct4h52z4Zk//ET6Xs0zCWXm9HEz v4WR/Q7sycHeCGwm2p4thRak/B7yDPFOlZAQNdwBsnCkoFE1qLXI8ZgoWNd4TlcjG9UJSwru s1WTQVprOBYdxPkvUOlaXYjDo2QsSaMilJioyJkrniJnc7sdzcfkwfdWSnC+2DbHd4wxrRtW kajTc7OnJEiM78U3/GfvXgxCwYV297yClzkUIWqVpY2HYLBgkI89ntnN95ePyTnLSQ8WIZJk ug0/WZfTmCxX0SMxfCYt36QwlWsImHpArS6xjTvUwUNTUYN6XxYZuYBmJQF9eLERK2z3KUeY 2Ku5ZTm5axvlraM0VhUn8yv7G5Pciv7oGXJxrA6k4P9CAvHYeJSTXYnrLr/Kabn+6rc0my/l RMq9GeEUL3LbIUadL78yAtpf7HpNavYkVureuFD8xK8HntEHySnf7s2L28+kDbnDi27WR5kn u/POwU0EVUNcNAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDy fv4dEKuCqeh0hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOG mLPRIBkXHqJYoHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6 H79LIsiYqf92H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4ar gt4e+jum3NwtyupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8 nO2N5OsFJOcd5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFF knCmLpowhct95ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz 7fMkcaZU+ok/+HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgN yxBZepj41oVqFPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMi p+12jgw4mGjy5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYC GwwWIQSb0H4ODFH41ZZ3t1Qbk0N9O0FimwUCaBdQXwUJFpZbKgAKCRAbk0N9O0Fim07TD/92 Vcmzn/jaEBcqyT48ODfDIQVvg2nIDW+qbHtJ8DOT0d/qVbBTU7oBuo0xuHo+MTBp0pSTWbTh LsSN1AuyP8wFKChC0JPcwOZZRS0dl3lFgg+c+rdZUHjsa247r+7fvm2zGG1/u+33lBJgnAIH 5lSCjhP4VXiGq5ngCxGRuBq+0jNCKyAOC/vq2cS/dgdXwmf2aL8G7QVREX7mSl0x+CjWyrpF c1D/9NV/zIWBG1NR1fFb+oeOVhRGubYfiS62htUQjGLK7qbTmrd715kH9Noww1U5HH7WQzeP t/SvC0RhQXNjXKBB+lwwM+XulFigmMF1KybRm7MNoLBrGDa3yGpAkHMkJ7NM4iSMdSxYAr60 RtThnhKc2kLIzd8GqyBh0nGPIL+1ZVMBDXw1Eu0/Du0rWt1zAKXQYVAfBLCTmkOnPU0fjR7q VT41xdJ6KqQMNGQeV+0o9X91X6VBeK6Na3zt5y4eWkve65DRlk1aoeBmhAteioLZlXkqu0pZ v+PKIVf+zFKuh0At/TN/618e/QVlZPbMeNSp3S3ieMP9Q6y4gw5CfgiDRJ2K9g99m6Rvlx1q wom6QbU06ltbvJE2K9oKd9nPp1NrBfBdEhX8oOwdCLJXEq83vdtOEqE42RxfYta4P3by0BHp cwzYbmi/Et7T2+47PN9NZAOyb771QoVr8A== In-Reply-To: <9434f836-aa96-44e7-8f34-243d6c94f6dc@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: Ftkc5a-Wr84S4fUFxyG5Mp7w-gMh9XrY X-Authority-Analysis: v=2.4 cv=FKAWBuos c=1 sm=1 tr=0 ts=69babe2f cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=gOEeR9iKwsj33Yj5oN/cWg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=LO4XtezffzH7F-Og_NQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE4MDEyNyBTYWx0ZWRfXxz3smVM3r7/7 UoNsqw+jIP1JQzcQOiPtvrw8rmWY60eisQJkU/c/pd2FU0xeyl3siORDDDuH2KGxNpXwq95Ip7x i8eQLH2llIKmchbmwcMgrzh3eJDfmdKjJX+PKAALkrr03Yj3IZtGY3UKYFi7cIdoFOfpgGCoE5o /dsTCwyCKW8kdwR0hirPxDvziLJWEC3rWOGW2ctnelcZGP7c6IADUXTZf+jduW6l0SXTOaCmgG8 4ktkAJ1SGi6FEQN9soFCpPrkTnaMmYmU7TA0bs4xejnYdeUi3KavR9cakdNu9HA2bGUr3SSTdxI PYZ9CPAuGR8xn3n9dD2kjx835sLtgISZu9ZOIvgEANRR8AP4m6efGQqB0s3yTXA8CyfDIX6ya+q tbQX3nQgmGvmOr46vWtHiafyjorwWYtLprNcNgfGY3nXnT94AQWeplGLu/2Xvuf611EMGzXXtEJ 5hgLcMYKP+ZUHSWeZwA== X-Proofpoint-ORIG-GUID: Ftkc5a-Wr84S4fUFxyG5Mp7w-gMh9XrY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-18_01,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 adultscore=0 bulkscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603180127 On 18/03/2026 13:21, Christophe Leroy (CS GROUP) wrote: > > > Le 18/03/2026 à 12:58, Segher Boessenkool a écrit : >> On Wed, Mar 18, 2026 at 12:54:30PM +0100, Krzysztof Kozlowski wrote: >>> On 18/03/2026 12:51, Segher Boessenkool wrote: >>>> On Tue, Mar 17, 2026 at 02:08:24PM +0100, Krzysztof Kozlowski wrote: >>>>> Return value of ps3_start_probe_thread() is not used, so code can be >>>>> simplified to fix W=1 clang warnings: >>>>> >>>>> arch/powerpc/platforms/ps3/device-init.c:953:6: error: variable 'result' set but not used [-Werror,-Wunused-but-set-variable] >>>> >>>> And this is exactly why -Werror is harmful. A boring harmless warning >>>> turned into a build break :-( >>> >>> -Werror does not matter here. We do not want warnings either, assuming >>> of course they are correct. >>> >>> So if this warning is correct, then patch should be applied and WERROR >>> is irrelevant. >> >> The build is broken. -Werror is positively harmful. >> >> Yes, you want the warnings fixed, but maybe something else has priority >> right now? > > But if I understand correctly this is a build performed with W=1 Yes > > Without W=1 there is no build breakage. There is no build breakage with W=1. This is somehow total offtopic or trolling. :/ > > Someone who forces W=1 on its build can be expected to unselect > CONFIG_PPC_WERROR if it is needed for him, no ? Of course :). Best regards, Krzysztof