public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Siqueira Jordao <Rodrigo.Siqueira@amd.com>
To: Hamza Mahfooz <hamza.mahfooz@amd.com>, amd-gfx@lists.freedesktop.org
Cc: "kernel test robot" <lkp@intel.com>,
	"Harry Wentland" <harry.wentland@amd.com>,
	"Leo Li" <sunpeng.li@amd.com>,
	"Alex Deucher" <alexander.deucher@amd.com>,
	"Christian König" <christian.koenig@amd.com>,
	"Pan, Xinhui" <Xinhui.Pan@amd.com>,
	"David Airlie" <airlied@gmail.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Qingqing Zhuo" <qingqing.zhuo@amd.com>,
	"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Hersen Wu" <hersenxs.wu@amd.com>,
	"Stylon Wang" <stylon.wang@amd.com>, "Jun Lei" <Jun.Lei@amd.com>,
	"Leon Huang" <Leon.Huang1@amd.com>,
	"Wenjing Liu" <wenjing.liu@amd.com>,
	"Mike Hsieh" <Mike.Hsieh@amd.com>,
	pengfuyuan <pengfuyuan@kylinos.cn>,
	"Nasir Osman" <nasir.osman@amd.com>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] drm/amd/display: drop unused count variable in create_eml_sink()
Date: Wed, 17 May 2023 18:04:45 -0600	[thread overview]
Message-ID: <f424478c-dc1e-a75d-d7ea-853546dd582c@amd.com> (raw)
In-Reply-To: <20230517183350.314082-3-hamza.mahfooz@amd.com>



On 5/17/23 12:33, Hamza Mahfooz wrote:
> Since, we are only interested in having
> drm_edid_override_connector_update(), update the value of
> connector->edid_blob_ptr. We don't care about the return value of
> drm_edid_override_connector_update() here. So, drop count.
> 
> Fixes: 068553e14f86 ("drm/amd/display: assign edid_blob_ptr with edid from debugfs")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Hamza Mahfooz <hamza.mahfooz@amd.com>
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 14b296e1d0f6..5a2d04f47276 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -6396,9 +6396,8 @@ static void create_eml_sink(struct amdgpu_dm_connector *aconnector)
>   		/* if connector->edid_override valid, pass
>   		 * it to edid_override to edid_blob_ptr
>   		 */
> -		int count;
>   
> -		count = drm_edid_override_connector_update(&aconnector->base);
> +		drm_edid_override_connector_update(&aconnector->base);
>   
>   		if (!aconnector->base.edid_blob_ptr) {
>   			DRM_ERROR("No EDID firmware found on connector: %s ,forcing to OFF!\n",

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>


  reply	other threads:[~2023-05-18  0:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-17 18:33 [PATCH 1/3] drm/amd/display: drop redundant memset() in get_available_dsc_slices() Hamza Mahfooz
2023-05-17 18:33 ` [PATCH 2/3] drm/amd/display: drop unused function set_abm_event() Hamza Mahfooz
2023-05-18  0:03   ` Rodrigo Siqueira Jordao
2023-05-17 18:33 ` [PATCH 3/3] drm/amd/display: drop unused count variable in create_eml_sink() Hamza Mahfooz
2023-05-18  0:04   ` Rodrigo Siqueira Jordao [this message]
2023-08-22 11:43   ` Jani Nikula
2023-05-18  0:01 ` [PATCH 1/3] drm/amd/display: drop redundant memset() in get_available_dsc_slices() Rodrigo Siqueira Jordao
2023-05-18  6:28 ` Marion & Christophe JAILLET

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f424478c-dc1e-a75d-d7ea-853546dd582c@amd.com \
    --to=rodrigo.siqueira@amd.com \
    --cc=Jun.Lei@amd.com \
    --cc=Leon.Huang1@amd.com \
    --cc=Mike.Hsieh@amd.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=aurabindo.pillai@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hamza.mahfooz@amd.com \
    --cc=harry.wentland@amd.com \
    --cc=hdegoede@redhat.com \
    --cc=hersenxs.wu@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=nasir.osman@amd.com \
    --cc=pengfuyuan@kylinos.cn \
    --cc=qingqing.zhuo@amd.com \
    --cc=stylon.wang@amd.com \
    --cc=sunpeng.li@amd.com \
    --cc=wenjing.liu@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox