From: Zhang Yi <yi.zhang@huawei.com>
To: chuguangqing <chuguangqing@inspur.com>
Cc: <linux-ext4@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>
Subject: Re: [PATCH 1/1] ext4: add FALLOC_FL_ALLOCATE_RANGE to supported flags mask
Date: Tue, 15 Jul 2025 20:50:16 +0800 [thread overview]
Message-ID: <f42f9a79-75cf-491e-bf46-5ea036cf6656@huawei.com> (raw)
In-Reply-To: <20250715064536.12053-1-chuguangqing@inspur.com>
On 2025/7/15 14:45, chuguangqing wrote:
> Note that since FALLOC_FL_ALLOCATE_RANGE is defined as 0x00, this addition
> has no functional modifications.
>
> Signed-off-by: chuguangqing <chuguangqing@inspur.com>
> ---
> fs/ext4/extents.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index b43aa82c1b39..f0f9363fd9fd 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -4784,9 +4784,9 @@ long ext4_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
> return -EOPNOTSUPP;
>
> /* Return error if mode is not supported */
> - if (mode & ~(FALLOC_FL_KEEP_SIZE | FALLOC_FL_PUNCH_HOLE |
> - FALLOC_FL_ZERO_RANGE | FALLOC_FL_COLLAPSE_RANGE |
> - FALLOC_FL_INSERT_RANGE | FALLOC_FL_WRITE_ZEROES))
> + if (mode & ~(FALLOC_FL_ALLOCATE_RANGE | FALLOC_FL_KEEP_SIZE |
> + FALLOC_FL_PUNCH_HOLE | FALLOC_FL_COLLAPSE_RANGE |
> + FALLOC_FL_ZERO_RANGE | FALLOC_FL_INSERT_RANGE))
> return -EOPNOTSUPP;
>
> inode_lock(inode);
Why did you remove the FALLOC_FL_WRITE_ZEROES support?
Regards,
Yi.
next prev parent reply other threads:[~2025-07-15 12:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 3:15 [PATCH 0/1] ext4: add FALLOC_FL_ALLOCATE_RANGE to supported flags mask chuguangqing
2025-07-15 3:15 ` [PATCH 1/1] Add FALLOC_FL_ALLOCATE_RANGE to the set of supported fallocate mode flags. This change improves code clarity and maintains by explicitly showing this flag in the " chuguangqing
2025-07-15 14:08 ` kernel test robot
2025-07-15 4:37 ` [PATCH 0/1] ext4: add FALLOC_FL_ALLOCATE_RANGE to " chuguangqing
2025-07-15 4:37 ` [PATCH 1/1] " chuguangqing
2025-07-15 6:45 ` chuguangqing
2025-07-15 12:34 ` Theodore Ts'o
2025-07-16 2:28 ` [PATCH v2 0/1] " chuguangqing
2025-07-16 2:28 ` [PATCH v2 1/1] " chuguangqing
2025-07-16 2:44 ` Re: [PATCH " chuguangqing
2025-07-15 12:50 ` Zhang Yi [this message]
2025-07-16 3:04 ` [PATCH v3 0/1] " chuguangqing
2025-07-16 3:04 ` [PATCH v3] " chuguangqing
2025-07-16 7:05 ` Zhang Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f42f9a79-75cf-491e-bf46-5ea036cf6656@huawei.com \
--to=yi.zhang@huawei.com \
--cc=adilger.kernel@dilger.ca \
--cc=chuguangqing@inspur.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).