From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1F46280005 for ; Tue, 10 Jun 2025 08:39:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749544752; cv=none; b=ujtKcm9DNngM8TZM6gZcbh/2ksKFTIWpVohtEagOasnYTN0SJKNTvjWWnudHpC6Pma6lv6ntiAX+akWNg4oOSZr+FP5COn5XChiTktRvKIamHbKdIdw8PXgnGx2gCSszT8gCONFAy22bWW7tlFMcMVB4T8oizNe9ELN2jYZlHLg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749544752; c=relaxed/simple; bh=Yl4VK5rapXeTeoJSO8TtkOTrZLDEqTO12ZY4/dzcD+U=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=H5dC1Rv48/Yvf0MwBQW33CTyU1xyNyRU7TS0/JdTyc8wbiAnZ5sLdofYoYBJd55Mwomd+sd6hUSkOIjpPsSuMRAJHssvvWGyAWbseilTaOFhe16EH60jeuH2pYsOBQZ3BckA47ZbidnfbkcbHaBBjFu9Vpb7onV2GCufhrSENiM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=QjdNqlvb; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QjdNqlvb" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4508287895dso37763855e9.1 for ; Tue, 10 Jun 2025 01:39:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749544749; x=1750149549; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=Yl4VK5rapXeTeoJSO8TtkOTrZLDEqTO12ZY4/dzcD+U=; b=QjdNqlvbVtV/1IHx2p5MIEVmfvFmv7GtiPiU8legWaocfKjNdHysysQo4h6cNUqZ+e OTMf2Mism+kkeKvq11TzU3s+St3N+sAfCqE7EDwUp7Hbapa5HIP2Vbk64egX9HISYu7b Y4Lpp/74+8OCyr5YjFFfpTGNSzzlxS1XL9jzrntxB082g80t7AMHan/BWflkZChTk6RQ a4dIkvke1p8eJdaEoHaTAHfus7EiV+7xANQYuS+N52QlBLjPYpcF8FVqR70oYZZMLWEL t7YRu/EqnVU54W3SaEMegVOCbP67hv6lZsKQLEA4iFRRh1TLYve+DN9eZrcVgv3QhjoW o1gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749544749; x=1750149549; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Yl4VK5rapXeTeoJSO8TtkOTrZLDEqTO12ZY4/dzcD+U=; b=nimkabR2sU3MvzsaX2W5ArWPpuvwSFYigLxMkp3u8P9F/diTLGmwEGuW+GKjAgQgIo fPdZ21MtXxFQ0n5Gv1p/BlxOvRXJ3lZUo1NmnyWeCtR+4DRTgBPvaHRyaohIRuaTrBPp Q1afMgwMijJ2kp6cwt/9pK7Uax/TC2zkXU3QaigBiZCPn6UbhIEiwPbuQ6cUgpaSKjSO PBypwXS+vNylAtxA7U4/cLlawwUXbFmBxs2UoenTjoxCI8zL59oIJt2BibCz3eI7csAd KCUyfJh1JBuuFA3XjQoKmbzPyJtuaSGpB+oeBl7leTG3ENMi/cwUSL6HVMXPqWtKg2ik UhFA== X-Forwarded-Encrypted: i=1; AJvYcCXC/6/EiYctPlUx63xgacy6s7FAtmmvxLpBfL4kw81IKhR7FgyT/KoSabj+o6C3z8lMw4Wf1xBernVrYME=@vger.kernel.org X-Gm-Message-State: AOJu0YwV/dHq/TWAqX0PRrS455/1/VlU/5guTjt1c9rtt88qKeMykx4P TLCy3HYjt/Yf108Z7VvpItERRe5zhAQNZtnd/Q4U397ELTbCiD3V1GoXFUSJ6YitAxg= X-Gm-Gg: ASbGnctsNcRVRFEeJhFCoJVt5XiUL7C96tm7IaeslbAtIzFRpZLl8IaGR4XMrUfmLLG S52ifZ5Oax+SXUKXYgln0y176lORJFAINxPT4xIogolbmwVyoY8QKHpTVXTr1Q3M9in4i2Zp5Kk dNxAgZe9TOoWEJSdFBJTGXAX5Xs7Qr548PKtE6yumIv1n3PLU9A+nUdAOAF3n/Gn6+/ymftkc+L C88NicuJC3owyUMPj+3TEZvinDu990YZ6ie9kZAW6inDx80e+F096pW8nAiU+pKy8TI7CLg0DpJ LE5yOGeodIrMx9ot7MObWg8zqNboOpLX0m+4v9DQrY1nURaEZfrac/nFV8vklbaQ6PhBk8wsfRC Dmg== X-Google-Smtp-Source: AGHT+IEgnzAuPZxC9PK7wFrxzn2rTCPjmEyvknSgU3kvtfzCGxGRajpBv/Wk8P5qBxM/ob8j0SfRdA== X-Received: by 2002:a5d:5f94:0:b0:3a4:ebfc:8c7 with SMTP id ffacd0b85a97d-3a5513ed8dfmr2108902f8f.8.1749544749195; Tue, 10 Jun 2025 01:39:09 -0700 (PDT) Received: from [10.1.1.109] ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a5322ae43fsm11467552f8f.25.2025.06.10.01.39.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 01:39:08 -0700 (PDT) Message-ID: Subject: Re: [PATCH v2 06/17] dt-bindings: firmware: google,gs101-acpm-ipc: update PMIC examples From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Tudor Ambarus , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Lee Jones , Linus Walleij , Bartosz Golaszewski Cc: Peter Griffin , Will McVicker , kernel-team@android.com, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org Date: Tue, 10 Jun 2025 09:39:07 +0100 In-Reply-To: <20250606-s2mpg1x-regulators-v2-6-b03feffd2621@linaro.org> References: <20250606-s2mpg1x-regulators-v2-0-b03feffd2621@linaro.org> <20250606-s2mpg1x-regulators-v2-6-b03feffd2621@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.55.2-1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Copying my comment below from v1 of this series to make sure it doesn't get= lost. On Fri, 2025-06-06 at 16:03 +0100, Andr=C3=A9 Draszik wrote: > In a typical system using the Samsung S2MPG10 PMIC, an S2MPG11 is used > as a sub-PMIC. >=20 > The interface for both is the ACPM firmware protocol, so update the > example here to describe the connection for both. >=20 > Signed-off-by: Andr=C3=A9 Draszik > --- > =C2=A0.../bindings/firmware/google,gs101-acpm-ipc.yaml=C2=A0=C2=A0 | 40 += +++++++++++++++++++-- > =C2=A01 file changed, 37 insertions(+), 3 deletions(-) >=20 > diff --git a/Documentation/devicetree/bindings/firmware/google,gs101-acpm= -ipc.yaml > b/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.yaml > index 62a3a7dac5bd250a7f216c72f3315cd9632d93e1..408cf84e426b80b6c06e69fda= 87d0f8bfc61498d 100644 > --- a/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.ya= ml > +++ b/Documentation/devicetree/bindings/firmware/google,gs101-acpm-ipc.ya= ml > @@ -36,6 +36,15 @@ properties: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 compatible: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 const: samsung,s2mpg10-p= mic > =C2=A0 > +=C2=A0 pmic2: > +=C2=A0=C2=A0=C2=A0 description: Child node describing the sub PMIC. > +=C2=A0=C2=A0=C2=A0 type: object > +=C2=A0=C2=A0=C2=A0 additionalProperties: true > + > +=C2=A0=C2=A0=C2=A0 properties: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 compatible: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 const: samsung,s2mpg11-pmic > + Since we have two PMICs here, but can not use the 'reg' property (as the addressing is based on software, i.e. the ACPM firmware), I've opted for 'pmic' (existing) and 'pmic2' (new) as nodenames. Maybe 'pmic-main' and 'pmic-sub' would be more appropriate, but 'pmic' is a bit more standard I believe. I'm open for better suggestions :-) Cheers, Andre'