Re: [RFC, PATCH 4/6] jbd: refactor nested journal log recovery loop into separate functions

Christoph Hellwig
2008-03-08T14:54:03Z

On Thu, Mar 06, 2008 at 01:59:12AM +0000, Duane Griffin wrote:
> +static int replay_data_block(
> + journal_t *journal, struct buffer_head *obh, char *data,
> + int flags, unsigned long blocknr)

quite odd formatting, this should be more like:

static int replay_data_block(journal_t *journal, struct buffer_head *obh,
char *data, int flags, unsigned long blocknr)

(same for the other new helpers)