From: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
To: Charles Keepax <ckeepax@opensource.cirrus.com>,
broonie@kernel.org, vkoul@kernel.org, oder_chiou@realtek.com
Cc: jack.yu@realtek.com, shumingf@realtek.com, lgirdwood@gmail.com,
peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com,
sanyog.r.kale@intel.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH v2 0/6] Expand SoundWire MBQ register map support
Date: Tue, 7 Jan 2025 13:56:50 -0600 [thread overview]
Message-ID: <f459b7be-169f-4ab9-9cb1-97db6e89a13a@linux.dev> (raw)
In-Reply-To: <20250107154408.814455-1-ckeepax@opensource.cirrus.com>
On 1/7/25 9:44 AM, Charles Keepax wrote:
> The current SDCA MBQ (Multi-Byte Quantities) register map only
> supports 16-bit types, add support for more sizes and then update
> the rt722 driver to use the new support. We also add support for
> the deferring feature of MBQs to allow hardware to indicate it is
> not currently ready to service a read/write.
>
> Afraid I don't have hardware to test the rt722 change so it is
> only build tested, but I thought it good to include a change to
> demonstrate the new features in use.
>
> Changes since v1:
> - Fixed a potentially uninitialised variable.
> - Added some extra rt722 registers, Shuming Fan asked for.
For the series:
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
> Thanks,
> Charles
>
> Charles Keepax (6):
> soundwire: SDCA: Add additional SDCA address macros
> ASoC: SDCA: Update list of entity_0 controls
> regmap: sdw-mbq: Add support for further MBQ register sizes
> regmap: sdw-mbq: Add support for SDCA deferred controls
> ASoC: rt722-sdca: Add some missing readable registers
> ASoC: rt722-sdca: Make use of new expanded MBQ regmap
>
> drivers/base/regmap/regmap-sdw-mbq.c | 219 +++++++++++++++++++++---
> include/linux/regmap.h | 62 ++++++-
> include/linux/soundwire/sdw_registers.h | 30 +++-
> include/sound/sdca_function.h | 33 +++-
> sound/soc/codecs/rt722-sdca-sdw.c | 128 ++++++++------
> sound/soc/codecs/rt722-sdca-sdw.h | 99 ++++++-----
> sound/soc/codecs/rt722-sdca.c | 135 ++++-----------
> sound/soc/codecs/rt722-sdca.h | 4 +-
> 8 files changed, 454 insertions(+), 256 deletions(-)
>
next prev parent reply other threads:[~2025-01-07 20:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-07 15:44 [PATCH v2 0/6] Expand SoundWire MBQ register map support Charles Keepax
2025-01-07 15:44 ` [PATCH v2 1/6] soundwire: SDCA: Add additional SDCA address macros Charles Keepax
2025-01-07 15:44 ` [PATCH v2 2/6] ASoC: SDCA: Update list of entity_0 controls Charles Keepax
2025-01-07 15:44 ` [PATCH v2 3/6] regmap: sdw-mbq: Add support for further MBQ register sizes Charles Keepax
2025-01-07 15:44 ` [PATCH v2 4/6] regmap: sdw-mbq: Add support for SDCA deferred controls Charles Keepax
2025-01-07 15:44 ` [PATCH v2 5/6] ASoC: rt722-sdca: Add some missing readable registers Charles Keepax
2025-01-07 20:00 ` Pierre-Louis Bossart
2025-01-08 11:07 ` Charles Keepax
2025-01-07 15:44 ` [PATCH v2 6/6] ASoC: rt722-sdca: Make use of new expanded MBQ regmap Charles Keepax
2025-01-07 19:56 ` Pierre-Louis Bossart [this message]
2025-01-08 13:32 ` (subset) [PATCH v2 0/6] Expand SoundWire MBQ register map support Mark Brown
2025-02-05 12:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f459b7be-169f-4ab9-9cb1-97db6e89a13a@linux.dev \
--to=pierre-louis.bossart@linux.dev \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=jack.yu@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=patches@opensource.cirrus.com \
--cc=peter.ujfalusi@linux.intel.com \
--cc=sanyog.r.kale@intel.com \
--cc=shumingf@realtek.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox