From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5FB6EB64D9 for ; Wed, 14 Jun 2023 19:57:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235383AbjFNT5W (ORCPT ); Wed, 14 Jun 2023 15:57:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232934AbjFNT5J (ORCPT ); Wed, 14 Jun 2023 15:57:09 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96B4D1FEF; Wed, 14 Jun 2023 12:57:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2FB3462272; Wed, 14 Jun 2023 19:57:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 83A54C433C0; Wed, 14 Jun 2023 19:57:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686772627; bh=GZ5mggTqw3teUuvhXLevUDfehWEgkhXaVlZpI7pRM+8=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=G1FQlghZ+qpoY1+fjk1mP61XCz4qQB2uWxd18kFRsMgFVQCivvXg4WTGaEKrnvwQA W3wjff3ZWKZYsUR0vO4MOIqIrOqpfvohOJlh73pUP7n9qeA0O2h04H51kKXhP2kro1 Sxq7NQ5aOfgzNt8VD+xDfovd2N4E96+3ERRn5yyTED3xCaNoIKdc2QVlkB9D+muWim Hnks3S5h52/W8AqwZukzSlL2sbx6hlCv9XaJQ0SyKgu9Fs5/sjN4sQ+hlBgyNofLzA hP/ZBtVzW3TBjKV4nwCEtAepOado/aTds3W3BAMA99eNxp0pL+fFxqWCZFfmSvhmEV JNcM+uvxaCr3A== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230614012913.122220-2-yang.lee@linux.alibaba.com> References: <20230614012913.122220-1-yang.lee@linux.alibaba.com> <20230614012913.122220-2-yang.lee@linux.alibaba.com> Subject: Re: [PATCH -next 2/3] clk: stm32: core: Fix unsigned comparison with less than zero From: Stephen Boyd Cc: mturquette@baylibre.com, orsonzhai@gmail.com, baolin.wang@linux.alibaba.com, zhang.lyra@gmail.com, pdeschrijver@nvidia.com, pgaikwad@nvidia.com, thierry.reding@gmail.com, jonathanh@nvidia.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot To: Yang Li Date: Wed, 14 Jun 2023 12:57:05 -0700 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Yang Li (2023-06-13 18:29:12) > The return value of the divider_ro_round_rate() is long. > However, the return value is being assigned to an unsigned > long variable 'rate', so making 'rate' to long. >=20 > silence the warnings: > ./drivers/clk/stm32/clk-stm32-core.c:451:6-10: WARNING: Unsigned expressi= on compared with zero: rate < 0 > ./drivers/clk/stm32/clk-stm32-core.c:461:5-9: WARNING: Unsigned expressio= n compared with zero: rate < 0 >=20 > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D5519 > Signed-off-by: Yang Li > --- > drivers/clk/stm32/clk-stm32-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/clk/stm32/clk-stm32-core.c b/drivers/clk/stm32/clk-s= tm32-core.c > index d5aa09e9fce4..067b918a8894 100644 > --- a/drivers/clk/stm32/clk-stm32-core.c > +++ b/drivers/clk/stm32/clk-stm32-core.c > @@ -431,7 +431,7 @@ static int clk_stm32_composite_determine_rate(struct = clk_hw *hw, > { > struct clk_stm32_composite *composite =3D to_clk_stm32_composite(= hw); > const struct stm32_div_cfg *divider; > - unsigned long rate; > + long rate; > =20 Instead of this can you convert this code to use divider_ro_determine_rate() and divider_determine_rate()?