From: Pavel Begunkov <asml.silence@gmail.com>
To: Mina Almasry <almasrymina@google.com>, Paolo Abeni <pabeni@redhat.com>
Cc: kuba@kernel.org, kaiyuanz@google.com, willemb@google.com,
edumazet@google.com, sdf@fomichev.me, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, dev@openvswitch.org,
davem@davemloft.net, horms@kernel.org, ncardwell@google.com,
kuniyu@google.com, aconole@redhat.com, echaudro@redhat.com,
i.maximets@ovn.org, kerneljasonxing@gmail.com,
bobbyeshleman@gmail.com, fw@strlen.de
Subject: Re: [PATCH net v4 2/2] net: tcp: block mixing readable and unreadable frags
Date: Sat, 22 Aug 2026 11:55:22 +0100 [thread overview]
Message-ID: <f4602941-5010-42de-a59c-4caf3d60b10d@gmail.com> (raw)
In-Reply-To: <CAHS8izPid1ZBEE1PqdUZGi10KK0vPZjza-nSOP65h5Munr9bHQ@mail.gmail.com>
On 8/18/26 19:37, Mina Almasry wrote:
> On Tue, Aug 18, 2026 at 3:26 AM Paolo Abeni <pabeni@redhat.com> wrote:
...>> Note the mixing described in the second direction pre-dates this patch
>> (there was no check at all before); the incorrect predicate and the
>> forced re-segmentation are new. Reaching this also needs a local
>> privileged setup (dmabuf TX binding plus MD5/AO or IPsec plus an ethtool
>> feature change), and in that configuration a devmem send through the copy
>> path would likely already fail in skb_copy_to_page_nocache() since the
>> iovec holds dmabuf offsets rather than user addresses, so this is stated
>> as an observation rather than a demonstrated corruption path.
>
> Pre-existing issue I think. We indeed assume binding != NULL means the
> send is devmem and zc is set. We missed that we may not set zc if
> NETIF_F_SG is not enabled. Probably the code setting binding to
Hmm, I flagged this one, I'm going to send out the diff I attached
in the thread for v3.
--
Pavel Begunkov
next prev parent reply other threads:[~2026-08-22 10:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 19:13 [PATCH net v4 1/2] net: core: propagate unreadable flag in skb_zerocopy Mina Almasry
2026-08-14 19:13 ` [PATCH net v4 2/2] net: tcp: block mixing readable and unreadable frags Mina Almasry
2026-08-18 10:26 ` Paolo Abeni
2026-08-18 18:37 ` Mina Almasry
2026-08-22 10:55 ` Pavel Begunkov [this message]
2026-08-18 10:25 ` [PATCH net v4 1/2] net: core: propagate unreadable flag in skb_zerocopy Paolo Abeni
2026-08-18 18:36 ` Mina Almasry
2026-08-20 20:30 ` patchwork-bot+netdevbpf
2026-08-21 16:38 ` Mina Almasry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4602941-5010-42de-a59c-4caf3d60b10d@gmail.com \
--to=asml.silence@gmail.com \
--cc=aconole@redhat.com \
--cc=almasrymina@google.com \
--cc=bobbyeshleman@gmail.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=i.maximets@ovn.org \
--cc=kaiyuanz@google.com \
--cc=kerneljasonxing@gmail.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox