From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38F0521D5AA for ; Thu, 21 Aug 2025 02:22:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755742939; cv=none; b=NCgxUgRp2WTQJ74u0Atg7LBVVLU+G5YiU9YNIaCzAn7mZDrxsXGg7NyECIf/Za+FX5riMVbJnu8jLuhzKH6Vef9uUCEQ++CbxYo4APt3x5hpkHoOax4u+Ird3hIrEyfStXeCsS5q1QyYA8BgcoPz7M7zouRu8usF9th4h3O5qc0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755742939; c=relaxed/simple; bh=M+Tt7lOyvwNBEVxje7vB5+qnUcdtvBNxt4rOINYoqf0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=d/d3jiISJdK5eJmezLdBYtLFZITu3iBtCNPCTk1lKj+QJIot+z91h3Hzy6C5PYYz95fHOHjLv7eHfP0DanTVgGOuQgLnY0HM80iS+gCnuOZrrLWnlGEYs0Q2duSmmlTPru+4oTJ1tiH8fYM6oXUFov2mv7G1Fto6kPUrY6Uh8xw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mx8Xv+UK; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mx8Xv+UK" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 57KGnGrm001621 for ; Thu, 21 Aug 2025 02:22:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= fhuQQAYtkFz1+EMzbo9h41xY8JijUtMlK2wIkAFemmg=; b=mx8Xv+UKFekjgIea zpwoOjBGpC8vG24HybBj9dFPUt5QlmnxYQI1nLF8qREnKjpKlPZWWhwvbIQSm75g AcfvH8kA10kv7f/86IZhqHh0uayUClUfBvRuLXE/AJBKZPrNY2mJlOufKoHv0fVy c0OBFnzpDknd9ZbpLkJ98UFg9FM+oxyx+q7o3t19K0C754pSN2QwlwdVhOeGq05S wyA/ACFZPVgH4tfzv/wZNXwBN7MwYWzXTMeO+citUmkwfWKIixxOuoUwhJzeacWI NaBtSrWeTcKHyU4ig+xdplvCIu80jwleequB4k36qWtceMtk4klLI/tzwrWQemCl SJD2FQ== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48n52dkkqe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 21 Aug 2025 02:22:17 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-32326e2f184so1136645a91.3 for ; Wed, 20 Aug 2025 19:22:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755742936; x=1756347736; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fhuQQAYtkFz1+EMzbo9h41xY8JijUtMlK2wIkAFemmg=; b=k3BZCfbElyTga7wlEEf+SRouqV1CfbZAaLwRJiOPVST3G5ROQIkO6p+yL7sVQBadNj Yh6THFEzFjcA6qs07LLOC3wHcdvbU9xeKHrVtWxeIP6YXXNI2Rauwvft7r83jx9tquBb 4uNs6DW+WerayWWkxCLlXMOc1sB+kSuOomIDNj/Hr2Ile+P7bawRktvnAlF/OWIxMjO1 W/EMKL12gg5KB1+HmjKeyhDmzaGiatZjar5MUrP+t4uZ8stJyhqmOrfr+/u+glwBisId 64ueB3ag17OIXyLv+YeHRyD/vFJvhG98Skhtoy1Nbuxino++DNrs8/rXkRtjRBNbEDzd UO4w== X-Forwarded-Encrypted: i=1; AJvYcCWmRqZgAbEJ7mJ20kBTsVoA8v0Ui6RfuHYZHEK7JYwi8HE/DBYLBjzQ8pFze9MNdi/E/HDvKWAHo+ISuTE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz+3y7zwFB0zCMK4H8BC9WwO0eTVuTDwJgdctOUhiA29slgXvE2 aW/Fdf4xL2M0aY1z64Qxdg1HX4x3d/ui3gVLeFy2mwX8o3/cIDHyWR3kF+ek/102pdwsQfMvxfK e90vkbXQFaSoT2i6gz+hfO/5lwlEcDmWoOS2YzHBRTkxY/mfnndIwMDfb5kbWxWIe9Po= X-Gm-Gg: ASbGncvPZL3Wn8fiLt8BlPpQozlGNjMkd0muMgeu4ASdCwh7nnThEP1pr1NYAu5cLw+ mcWi05jj5l2VcQRXOtnEunSfpJmmkTn+/ys6pgyXTJIglRhtfPepksBpWcmQ1CdyW4Ay195tTkr s1NDGm2RwHpk0ckcw/Mz64/Ocy1j33W/Q7+3er2abvOtcaZCvb7b2Rx55xkFEz9qQa70XtLtmxC EB4IsCP1w9dA2TWontrf8tctoRqgkar2RTMakPJgqsBDc6qkiV7F8j6xmRWZMw7wkquOD2hvjKC fcPuqusuTY3i6ISSJnYCqbB+szjd2yKBDgCXPVIlrAdiAx0efz40yoElvsgZXrJqr87g05sqT8K AFu2ipv6CrNcn7aPtZmYXwQuZp9AQDQyj X-Received: by 2002:a17:90b:53c4:b0:324:e642:b5ca with SMTP id 98e67ed59e1d1-324ed13a72dmr1379004a91.29.1755742935703; Wed, 20 Aug 2025 19:22:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEJRz4sysTqGhrRLL4dSQy2QlK07feYrDXxAVKB+n79aOM7MsuZWRLWFY/xgGqdwpBUmHYgnw== X-Received: by 2002:a17:90b:53c4:b0:324:e642:b5ca with SMTP id 98e67ed59e1d1-324ed13a72dmr1378979a91.29.1755742935196; Wed, 20 Aug 2025 19:22:15 -0700 (PDT) Received: from [10.133.33.88] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-324f23d745csm356703a91.4.2025.08.20.19.22.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Aug 2025 19:22:14 -0700 (PDT) Message-ID: Date: Thu, 21 Aug 2025 10:22:05 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/6] net: stmmac: Inverse the phy-mode definition To: Andrew Lunn Cc: Vinod Koul , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Richard Cochran , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, stable+noautosel@kernel.org References: <20250819-qcs615_eth-v4-0-5050ed3402cb@oss.qualcomm.com> <20250819-qcs615_eth-v4-2-5050ed3402cb@oss.qualcomm.com> <80a60564-3174-4edd-a57c-706431f2ad91@lunn.ch> Content-Language: en-US From: Yijie Yang In-Reply-To: <80a60564-3174-4edd-a57c-706431f2ad91@lunn.ch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwODIwMDAxMyBTYWx0ZWRfX47F64QkyO+RN zKubxbnGWi8H+jYU0yiA0pDTlVpUdds38qsD357pssEho/F16oRyOpczLHDeUa+sKFDiFqlCpZx j0pFNJ3zJFlQ8X6pyU1vmrzijI9ykjlaB8HmYFfkDGWYJ13c09cY1AWrLJ0WqCgurfPS2stPRqk vo8FyUsexqB317wa0L3/y4xV5JEqR/pEbCzKLjatN8RJlMaG+dW/e0xSmyUHnanXLYmwiqTHtUP DYPF6VNVYfMaGhjA8Cq5veqrSRc5OQ/SKhPr+KE6KZdQ8dXhd/4EhOZNZi0yK1dphjScenjmXMU t5FPC00ad269zIOXDAXzttVd5KcsM9Unbau9pAJnSqB5iWBmMSULjQLdbzVFz8HYI+p+Eh2gCfC XTF+djg8jGKmY354i8ikCzBOfnOFcg== X-Proofpoint-ORIG-GUID: GswC_VCunnNU5lP60oO9RIOsh2hoXMn6 X-Proofpoint-GUID: GswC_VCunnNU5lP60oO9RIOsh2hoXMn6 X-Authority-Analysis: v=2.4 cv=SoXJKPO0 c=1 sm=1 tr=0 ts=68a682d9 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=2OwXVqhp2XgA:10 a=uddfqdTxQVX4ueY0IN0A:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-08-20_06,2025-08-20_03,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 priorityscore=1501 suspectscore=0 malwarescore=0 phishscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2508110000 definitions=main-2508200013 On 2025-08-20 00:20, Andrew Lunn wrote: >> static int ethqos_rgmii_macro_init(struct qcom_ethqos *ethqos, int speed) >> { >> struct device *dev = ðqos->pdev->dev; >> - int phase_shift; >> + int phase_shift = 0; >> int loopback; >> >> /* Determine if the PHY adds a 2 ns TX delay or the MAC handles it */ >> - if (ethqos->phy_mode == PHY_INTERFACE_MODE_RGMII_ID || >> - ethqos->phy_mode == PHY_INTERFACE_MODE_RGMII_TXID) >> - phase_shift = 0; >> - else >> + if (ethqos->phy_mode == PHY_INTERFACE_MODE_RGMII_ID) >> phase_shift = RGMII_CONFIG2_TX_CLK_PHASE_SHIFT_EN; > > Does this one setting control both RX and TX delays? The hardware > cannot support 2ns delay on TX, but 0ns on RX? Or 2ns on RX but 0ns on > TX? > This setting is only for Tx delay. Rx delays are taken care separately with DLL delays. > Andrew -- Best Regards, Yijie