The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Gabriele Monaco <gmonaco@redhat.com>
To: linux-kernel@vger.kernel.org,
	Anna-Maria Behnsen <anna-maria@linutronix.de>,
	 Frederic Weisbecker	 <frederic@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Waiman Long	 <llong@redhat.com>
Cc: "John B . Wyatt IV" <jwyatt@redhat.com>,
	"John B . Wyatt IV" <sageofredondo@gmail.com>
Subject: Re: [PATCH v14 7/7] timers: Exclude isolated cpus from timer migration
Date: Mon, 10 Nov 2025 14:06:08 +0100	[thread overview]
Message-ID: <f47a6827fa07db12581d2a6b8c1cfe1ce467aa21.camel@redhat.com> (raw)
In-Reply-To: <20251104104740.70512-8-gmonaco@redhat.com>

On Tue, 2025-11-04 at 11:47 +0100, Gabriele Monaco wrote:
> The timer migration mechanism allows active CPUs to pull timers from
> idle ones to improve the overall idle time. This is however undesired
> when CPU intensive workloads run on isolated cores, as the algorithm
> would move the timers from housekeeping to isolated cores, negatively
> affecting the isolation.
> 
> Exclude isolated cores from the timer migration algorithm, extend the
> concept of unavailable cores, currently used for offline ones, to
> isolated ones:
> * A core is unavailable if isolated or offline;
> * A core is available if non isolated and online;
> 
> ...
> 
> +/* Enabled during late initcall */
> +DEFINE_STATIC_KEY_FALSE(tmigr_exclude_isolated);
> +

I forgot to mark this as static:

+static DEFINE_STATIC_KEY_FALSE(tmigr_exclude_isolated);

will send a new version after getting a review/comments.

Frederic, Thomas, besides that, does this series look ready to you?

Thanks,
Gabriele


  reply	other threads:[~2025-11-10 13:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-04 10:47 [PATCH v14 0/7] timers: Exclude isolated cpus from timer migration Gabriele Monaco
2025-11-04 10:47 ` [PATCH v14 1/7] timers: Rename tmigr 'online' bit to 'available' Gabriele Monaco
2025-11-12 15:45   ` Frederic Weisbecker
2025-11-04 10:47 ` [PATCH v14 2/7] timers: Add the available mask in timer migration Gabriele Monaco
2025-11-04 10:47 ` [PATCH v14 3/7] timers: Use scoped_guard when setting/clearing the tmigr available flag Gabriele Monaco
2025-11-04 10:47 ` [PATCH v14 4/7] cgroup/cpuset: Rename update_unbound_workqueue_cpumask() to update_isolation_cpumasks() Gabriele Monaco
2025-11-04 10:47 ` [PATCH v14 5/7] sched/isolation: Force housekeeping if isolcpus and nohz_full don't leave any Gabriele Monaco
2025-11-04 10:47 ` [PATCH v14 6/7] cpumask: Add initialiser to use cleanup helpers Gabriele Monaco
2025-11-04 10:47 ` [PATCH v14 7/7] timers: Exclude isolated cpus from timer migration Gabriele Monaco
2025-11-10 13:06   ` Gabriele Monaco [this message]
2025-11-12 16:04   ` Frederic Weisbecker
2025-11-12 16:18     ` Gabriele Monaco
2025-11-12 16:59       ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f47a6827fa07db12581d2a6b8c1cfe1ce467aa21.camel@redhat.com \
    --to=gmonaco@redhat.com \
    --cc=anna-maria@linutronix.de \
    --cc=frederic@kernel.org \
    --cc=jwyatt@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llong@redhat.com \
    --cc=sageofredondo@gmail.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox