From: stuart hayes <stuart.w.hayes@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Tanjore Suresh <tansuresh@google.com>,
Martin Belanger <Martin.Belanger@dell.com>,
Oliver O'Halloran <oohall@gmail.com>,
Daniel Wagner <dwagner@suse.de>, Keith Busch <kbusch@kernel.org>,
Lukas Wunner <lukas@wunner.de>,
David Jeffery <djeffery@redhat.com>,
Jeremy Allison <jallison@ciq.com>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v6 3/4] driver core: shut down devices asynchronously
Date: Tue, 28 May 2024 22:35:27 -0500 [thread overview]
Message-ID: <f480f2a4-2958-4b08-ae32-ce307c3c63aa@gmail.com> (raw)
In-Reply-To: <20240528063109.GA29965@lst.de>
On 5/28/2024 1:31 AM, Christoph Hellwig wrote:
> On Thu, May 16, 2024 at 10:49:19AM -0500, Stuart Hayes wrote:
>> Add /sys/kernel/async_shutdown to allow user control of this feature:
>>
>> safe: shut down all devices synchronously, unless driver prefers async
>> shutdown (driver opt-in) (default)
>> on: shut down all devices asynchronously, unless disabled by the driver
>> (driver opt-out)
>> off: shut down all devices synchronously
>
> The on option seems very odd. IMHO safe is the only really sensible
> option, and maybe we have to support off as a bandaid due to userspace
> behavior dependent on synchronous shutdown, but I'd rather try even
> without that first.
>
I added the option because of comments from Greg K-H on the v4 submission
of this patch--see
https://lore.kernel.org/lkml/2023102151-rejoicing-studio-6126@gregkh/T/#m5d0459480bc0fda4563040cab2036839bcbb79a8).
I thought it would be nice to have the option for testing, even if it gets
removed later, but I'll certainly remove it now if necessary.
next prev parent reply other threads:[~2024-05-29 3:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 15:49 [PATCH v6 0/4] shut down devices asynchronously Stuart Hayes
2024-05-16 15:49 ` [PATCH v6 1/4] driver core: don't always lock parent in shutdown Stuart Hayes
2024-05-16 15:49 ` [PATCH v6 2/4] driver core: separate function to shutdown one device Stuart Hayes
2024-05-16 15:49 ` [PATCH v6 3/4] driver core: shut down devices asynchronously Stuart Hayes
2024-05-28 6:31 ` Christoph Hellwig
2024-05-29 3:35 ` stuart hayes [this message]
2024-05-29 6:06 ` Greg Kroah-Hartman
2024-06-12 20:55 ` Keith Busch
2024-06-12 21:02 ` Jeremy Allison
2024-05-16 15:49 ` [PATCH v6 4/4] nvme-pci: Make driver prefer asynchronous shutdown Stuart Hayes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f480f2a4-2958-4b08-ae32-ce307c3c63aa@gmail.com \
--to=stuart.w.hayes@gmail.com \
--cc=Martin.Belanger@dell.com \
--cc=axboe@fb.com \
--cc=djeffery@redhat.com \
--cc=dwagner@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jallison@ciq.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=lukas@wunner.de \
--cc=oohall@gmail.com \
--cc=rafael@kernel.org \
--cc=sagi@grimberg.me \
--cc=tansuresh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox