Re: [PATCH v2 0/6] selftests/x86: fix build errors and warnings found via clang

Shuah Khan
2024-05-30T14:58:17Z

On 5/27/24 15:00, John Hubbard wrote:
> Hi,
>
> Just a bunch of build and warnings fixes that show up when
> building with clang. Some of these depend on each other, so
> I'm sending them as a series.
>
> Changes since the first version:
>
> 1) Rebased onto Linux 6.10-rc1

x86 test patches usually go through x86 tree.

This series requires x86 maintainer review and ack for me
to take this through kselftest tree.

>
> Enjoy!
>
> thanks,
> John Hubbard
>
> John Hubbard (6):
> selftests/x86: build test_FISTTP.c with clang
> selftests/x86: build fsgsbase_restore.c with clang
> selftests/x86: build sysret_rip.c with clang
> selftests/x86: avoid -no-pie warnings from clang during compilation
> selftests/x86: remove (or use) unused variables and functions
> selftests/x86: fix printk warnings reported by clang
>
> tools/testing/selftests/x86/Makefile | 10 +++++++
> tools/testing/selftests/x86/amx.c | 16 -----------
> .../testing/selftests/x86/clang_helpers_32.S | 11 ++++++++
> .../testing/selftests/x86/clang_helpers_64.S | 28 +++++++++++++++++++
> tools/testing/selftests/x86/fsgsbase.c | 6 ----
> .../testing/selftests/x86/fsgsbase_restore.c | 11 ++++----
> tools/testing/selftests/x86/sigreturn.c | 2 +-
> .../testing/selftests/x86/syscall_arg_fault.c | 1 -
> tools/testing/selftests/x86/sysret_rip.c | 20 ++++---------
> tools/testing/selftests/x86/test_FISTTP.c | 8 +++---
> tools/testing/selftests/x86/test_vsyscall.c | 15 ++++------
> tools/testing/selftests/x86/vdso_restorer.c | 2 ++
> 12 files changed, 72 insertions(+), 58 deletions(-)
> create mode 100644 tools/testing/selftests/x86/clang_helpers_32.S
> create mode 100644 tools/testing/selftests/x86/clang_helpers_64.S
>
>
> base-commit: 2bfcfd584ff5ccc8bb7acde19b42570414bf880b
> prerequisite-patch-id: 39d606b9b165077aa1a3a3b0a3b396dba0c20070

thanks,
-- Shuah