public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Babu Moger <bmoger@amd.com>
To: "Luck, Tony" <tony.luck@intel.com>, Aaron Tomlin <atomlin@atomlin.com>
Cc: "Chatre, Reinette" <reinette.chatre@intel.com>,
	"Dave.Martin@arm.com" <Dave.Martin@arm.com>,
	"james.morse@arm.com" <james.morse@arm.com>,
	"babu.moger@amd.com" <babu.moger@amd.com>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"bp@alien8.de" <bp@alien8.de>,
	"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: RE: [PATCH 1/2] x86/resctrl: Add io_alloc_min_cbm_all interface for CBM reset
Date: Mon, 10 Nov 2025 13:42:17 -0600	[thread overview]
Message-ID: <f4a043d2-9cb0-41c9-a45d-31f96fd007d5@amd.com> (raw)
In-Reply-To: <SJ1PR11MB6083701B503CE361E3D7A656FCCEA@SJ1PR11MB6083.namprd11.prod.outlook.com>

Hi Tony,

On 11/10/25 11:50, Luck, Tony wrote:
>> Does the following option work for you?
>>
>> # echo "*=0" > /sys/fs/resctrl/info/L3/io_alloc_cbm
>>
>>
>> Here,|*| represents all domains.
>>
>>
>> This functionality was introduced when adding support for the*"mbm_event" assign mode* (see [1]).
>> [1]https://lore.kernel.org/lkml/b894ad853e6757d40da1469bf9fca4c64684df65.1757108044.git.babu.moger@amd.com/ <https://lore.kernel.org/lkml/b894ad853e6757d40da1469bf9fca4c64684df65.1757108044.git.babu.moger@amd.com/> <https://lore.kernel.org/lkml/b894ad853e6757d40da1469bf9fca4c64684df65.1757108044.git.babu.moger@amd.com/>
>> Also, this needs to be done for all the settings like L3, MBA also SMBA.
>>
>> # echo "L3:*=f" > /sys/fs/resctrl/schemata
>>
>> # echo "MB:*=128" > /sys/fs/resctrl/schemata
>>
>> I’d like to hear from Reinette and Tony if this seems like an acceptable
>> approach.
>>
>> Thanks
> Babu,
>
> It does look like a logical extension of the mbm_event assignment syntax.
>
> But might be awkward to use if the system has asymmetric domains. We don't
> currently. But if we wanted to support L2 cache allocation on hybrid platforms
> with a mix of P-core and E-core, those have historically supported different
> bit masks because the L2 caches may allow 12 bits for one core type and
> 16 for another. On such a platform:
>
> # echo "L2:*=fff" > schemata
>
> would work,. But
>
> # echo "L2:*=ffff" > schemata
>
> would try to set unimplemented bits on some cores and would fail.


I would consider this a user error, as the user is expected to know the 
supported value for the domain.
This situation can occur even now — we simply report the error and exit.

Thanks

Babu


  reply	other threads:[~2025-11-10 19:42 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07  1:23 [PATCH 0/2] x86/resctrl: Add io_alloc_min_cbm_all interface for CBM reset Aaron Tomlin
2025-11-07  1:24 ` [PATCH 1/2] " Aaron Tomlin
2025-11-07 22:02   ` Moger, Babu
2025-11-07 22:25     ` Aaron Tomlin
2025-11-07 23:08       ` Moger, Babu
2025-11-08  0:19         ` Aaron Tomlin
2025-11-08  0:42           ` Luck, Tony
2025-11-10 16:34           ` Babu Moger
2025-11-10 17:50             ` Luck, Tony
2025-11-10 19:42               ` Babu Moger [this message]
2025-11-10 19:56                 ` Luck, Tony
2025-11-10 21:40                   ` Reinette Chatre
2025-11-11  0:41             ` Aaron Tomlin
2025-11-11  0:51               ` Luck, Tony
2025-11-11  1:00                 ` Reinette Chatre
2025-11-11  1:40                   ` Luck, Tony
2025-11-11  2:37                     ` Reinette Chatre
2025-11-11  2:44                     ` Aaron Tomlin
2025-11-11 15:29                       ` Babu Moger
2025-11-11 21:04                         ` Babu Moger
2025-11-11 22:34                           ` Aaron Tomlin
2025-11-11 23:21                             ` Moger, Babu
2025-11-07  1:24 ` [PATCH 2/2] fs/resctrl: resctrl: Return -EINVAL for a missing seq_show implementation Aaron Tomlin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4a043d2-9cb0-41c9-a45d-31f96fd007d5@amd.com \
    --to=bmoger@amd.com \
    --cc=Dave.Martin@arm.com \
    --cc=atomlin@atomlin.com \
    --cc=babu.moger@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=reinette.chatre@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox