From: Shuah Khan <skhan@linuxfoundation.org>
To: 徐福海 <xufuhai1992@gmail.com>,
shuah@kernel.org, "Thomas Renninger" <trenn@suse.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
lishujin@kuaishou.com, xufuhai <xufuhai@kuaishou.com>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 1/2] cpupower: Fix amd cpu (family < 0x17) active state issue
Date: Thu, 22 Jul 2021 09:18:19 -0600 [thread overview]
Message-ID: <f4a86da9-446b-7104-e785-b4380dbc216a@linuxfoundation.org> (raw)
In-Reply-To: <b709dee3-4337-56bd-9ecb-a983142e416d@gmail.com>
On 5/30/21 12:58 AM, 徐福海 wrote:
> From: xufuhai<xufuhai@kuaishou.com>
>
> For the old AMD processor (family < 0x17), cpupower will call the
> amd_pci_get_num_boost_states function, but for the non-root user
> pci_read_byte function (implementation comes from the psutil library),
> val will be set to 0xff, indicating that there is no read function
> callback. At this time, the original logic will set the cpupower turbo
> active state to yes. This is an obvious issue~
>
> Reproduce procedure:
> cpupower frequency-info
>
Please resend this patch and the following from the same
address as the Signed-off-by.
https://patchwork.kernel.org/project/linux-pm/patch/2dccdf57-1546-e55e-2efe-3ac91ed7f043@gmail.com/
thanks,
-- Shuah
parent reply other threads:[~2021-07-22 15:21 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <b709dee3-4337-56bd-9ecb-a983142e416d@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4a86da9-446b-7104-e785-b4380dbc216a@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lishujin@kuaishou.com \
--cc=shuah@kernel.org \
--cc=trenn@suse.com \
--cc=xufuhai1992@gmail.com \
--cc=xufuhai@kuaishou.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox