From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC99CC3DA7C for ; Thu, 29 Dec 2022 03:00:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232837AbiL2DAW (ORCPT ); Wed, 28 Dec 2022 22:00:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231214AbiL2DAT (ORCPT ); Wed, 28 Dec 2022 22:00:19 -0500 Received: from out30-45.freemail.mail.aliyun.com (out30-45.freemail.mail.aliyun.com [115.124.30.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 252D512088; Wed, 28 Dec 2022 19:00:17 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0VYJZ1mx_1672282814; Received: from 30.236.46.126(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VYJZ1mx_1672282814) by smtp.aliyun-inc.com; Thu, 29 Dec 2022 11:00:15 +0800 Message-ID: Date: Thu, 29 Dec 2022 11:00:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH V3 3/3] gpio: gpio-sprd: Make the irqchip immutable To: Cixi Geng , linus.walleij@linaro.org, brgl@bgdev.pl, orsonzhai@gmail.com, zhang.lyra@gmail.com Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, cixi.geng1@unisoc.com References: <20221228122442.392504-1-cixi.geng@linux.dev> <20221228122442.392504-4-cixi.geng@linux.dev> From: Baolin Wang In-Reply-To: <20221228122442.392504-4-cixi.geng@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/28/2022 8:24 PM, Cixi Geng wrote: > From: Cixi Geng > > Make the struct irq_chip const, flag it as IRQCHIP_IMMUTABLE, add the > new helper functions, and call the appropriate gpiolib functions. > > Reported-by: kernel test robot > Reported-by: Julia Lawall > Signed-off-by: Cixi Geng LGTM. Reviewed-by: Baolin Wang > --- > drivers/gpio/gpio-sprd.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpio/gpio-sprd.c b/drivers/gpio/gpio-sprd.c > index 9bff63990eee..072b4e653216 100644 > --- a/drivers/gpio/gpio-sprd.c > +++ b/drivers/gpio/gpio-sprd.c > @@ -120,6 +120,7 @@ static void sprd_gpio_irq_mask(struct irq_data *data) > u32 offset = irqd_to_hwirq(data); > > sprd_gpio_update(chip, offset, SPRD_GPIO_IE, 0); > + gpiochip_disable_irq(chip, offset); > } > > static void sprd_gpio_irq_ack(struct irq_data *data) > @@ -136,6 +137,7 @@ static void sprd_gpio_irq_unmask(struct irq_data *data) > u32 offset = irqd_to_hwirq(data); > > sprd_gpio_update(chip, offset, SPRD_GPIO_IE, 1); > + gpiochip_enable_irq(chip, offset); > } > > static int sprd_gpio_irq_set_type(struct irq_data *data, > @@ -205,13 +207,14 @@ static void sprd_gpio_irq_handler(struct irq_desc *desc) > chained_irq_exit(ic, desc); > } > > -static struct irq_chip sprd_gpio_irqchip = { > +static const struct irq_chip sprd_gpio_irqchip = { > .name = "sprd-gpio", > .irq_ack = sprd_gpio_irq_ack, > .irq_mask = sprd_gpio_irq_mask, > .irq_unmask = sprd_gpio_irq_unmask, > .irq_set_type = sprd_gpio_irq_set_type, > - .flags = IRQCHIP_SKIP_SET_WAKE, > + .flags = IRQCHIP_SKIP_SET_WAKE | IRQCHIP_IMMUTABLE, > + GPIOCHIP_IRQ_RESOURCE_HELPERS, > }; > > static int sprd_gpio_probe(struct platform_device *pdev) > @@ -245,7 +248,7 @@ static int sprd_gpio_probe(struct platform_device *pdev) > sprd_gpio->chip.direction_output = sprd_gpio_direction_output; > > irq = &sprd_gpio->chip.irq; > - irq->chip = &sprd_gpio_irqchip; > + gpio_irq_chip_set_chip(irq, &sprd_gpio_irqchip); > irq->handler = handle_bad_irq; > irq->default_type = IRQ_TYPE_NONE; > irq->parent_handler = sprd_gpio_irq_handler;