From: kuiliang Shi <seakeel@gmail.com>
To: alexs@kernel.org, Tomas Winkler <tomas.winkler@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] samples: mei: remove unused parameter
Date: Thu, 1 Feb 2024 19:58:07 +0800 [thread overview]
Message-ID: <f4c6a0a1-e02b-4668-b3b3-0ba04fa079a6@gmail.com> (raw)
In-Reply-To: <20240119040012.2925013-1-alexs@kernel.org>
ping
On 1/19/24 12:00 PM, alexs@kernel.org wrote:
> From: Alex Shi <alexs@kernel.org>
>
> The timeout parameter isn't used in func mei_send_msg(), better to
> remove it.
>
> Signed-off-by: Alex Shi <alexs@kernel.org>
> To: linux-kernel@vger.kernel.org
> To: Tomas Winkler <tomas.winkler@intel.com>
> ---
> samples/mei/mei-amt-version.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/samples/mei/mei-amt-version.c b/samples/mei/mei-amt-version.c
> index 867debd3b912..bf14d8a819b9 100644
> --- a/samples/mei/mei-amt-version.c
> +++ b/samples/mei/mei-amt-version.c
> @@ -195,8 +195,7 @@ static ssize_t mei_recv_msg(struct mei *me, unsigned char *buffer,
> return rc;
> }
>
> -static ssize_t mei_send_msg(struct mei *me, const unsigned char *buffer,
> - ssize_t len, unsigned long timeout)
> +static ssize_t mei_send_msg(struct mei *me, const unsigned char *buffer, ssize_t len)
> {
> ssize_t written;
> ssize_t rc;
> @@ -391,8 +390,7 @@ static uint32_t amt_host_if_call(struct amt_host_if *acmd,
> memset(*read_buf, 0, in_buf_sz);
> msg_hdr = (struct amt_host_if_resp_header *)*read_buf;
>
> - written = mei_send_msg(&acmd->mei_cl,
> - command, command_sz, acmd->send_timeout);
> + written = mei_send_msg(&acmd->mei_cl, command, command_sz);
> if (written != command_sz)
> return AMT_STATUS_INTERNAL_ERROR;
>
next prev parent reply other threads:[~2024-02-01 11:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 4:00 [PATCH] samples: mei: remove unused parameter alexs
2024-02-01 11:58 ` kuiliang Shi [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-03-27 4:02 alexs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4c6a0a1-e02b-4668-b3b3-0ba04fa079a6@gmail.com \
--to=seakeel@gmail.com \
--cc=alexs@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox