From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Danila Tikhonov <danila@jiaxyga.com>,
andersson@kernel.org, konrad.dybcio@linaro.org,
lgirdwood@gmail.com, broonie@kernel.org, robh@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
gregkh@linuxfoundation.org, quic_wcheng@quicinc.com
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Subject: Re: [PATCH 3/3] arm64: dts: qcom: pm6150: define USB-C related blocks
Date: Sun, 18 Feb 2024 19:10:27 +0000 [thread overview]
Message-ID: <f4e2cd9f-d8d2-4669-9bbc-57f67a24e734@linaro.org> (raw)
In-Reply-To: <60728953-bdf0-4a06-a90a-d1191d41962b@jiaxyga.com>
On 18/02/2024 6:52 p.m., Danila Tikhonov wrote:
> You are referring to Dmitry Baryshkov, as I see. But Dmitry has already
> reviewed my patch (message above).
Yes we previously debated and discussed verbatim copy of downstream
versus the format we used for 8150b.
The original driver I wrote for tcpm and the dts that went with it
derived from 4.19 where the interrupt definition was already right, so
in that case copy/paste of downstream is fine.
However with earlier kernels, 4.14 in this case the signalling isn't right.
Please read the discussion and reconsider your patch.
> So it would be rude to change anything without his knowledge. Let's wait
> for his answer
He'd have to be arguing against his own patch.....
One final nag - please use the kernel discussion format of bottom not
top posting.
https://git.codelinaro.org/bryan.odonoghue/kernel/-/blob/sc8280xp-v6.8-rc4-camss/Documentation/process/submitting-patches.rst?ref_type=heads
---
bod
next prev parent reply other threads:[~2024-02-18 19:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 16:31 [PATCH 0/3] arm64: dts: qcom: pm6150: Add typec support for PM6150 Danila Tikhonov
2024-02-17 16:31 ` [PATCH 1/3] dt-bindings: regulator: qcom,usb-vbus-regulator: Add PM6150 compatible Danila Tikhonov
2024-02-19 7:13 ` Krzysztof Kozlowski
2024-02-17 16:32 ` [PATCH 2/3] dt-bindings: usb: qcom,pmic-typec: Add support for the PM6150 PMIC Danila Tikhonov
2024-02-19 7:13 ` Krzysztof Kozlowski
2024-02-17 16:32 ` [PATCH 3/3] arm64: dts: qcom: pm6150: define USB-C related blocks Danila Tikhonov
2024-02-17 18:17 ` Dmitry Baryshkov
2024-02-17 23:19 ` Bryan O'Donoghue
2024-02-18 8:05 ` Danila Tikhonov
2024-02-18 17:14 ` Bryan O'Donoghue
2024-02-18 18:52 ` Danila Tikhonov
2024-02-18 19:10 ` Bryan O'Donoghue [this message]
2024-02-18 22:07 ` Dmitry Baryshkov
2024-02-19 16:23 ` (subset) [PATCH 0/3] arm64: dts: qcom: pm6150: Add typec support for PM6150 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4e2cd9f-d8d2-4669-9bbc-57f67a24e734@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=danila@jiaxyga.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=quic_wcheng@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox