From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932510AbbFWPQs (ORCPT ); Tue, 23 Jun 2015 11:16:48 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:49498 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754523AbbFWPQk (ORCPT ); Tue, 23 Jun 2015 11:16:40 -0400 Message-ID: In-Reply-To: References: <1435014310-2080-1-git-send-email-ankgupta@codeaurora.org> Date: Tue, 23 Jun 2015 09:16:39 -0600 Subject: Re: [PATCH v2] trace/events: add chip name and hwirq to irq entry tracepoint From: "Ankit Gupta" To: "Thomas Gleixner" Cc: "Ankit Gupta" , rostedt@goodmis.org, mingo@redhat.com, agross@codeaurora.org, davem@davemloft.net, rdunlap@infradead.org, standby24x7@gmail.com, sboyd@codeaurora.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, gavidov@codeaurora.org, sdharia@codeaurora.org, linux-arm-msm@vger.kernel.org, mlocke@codeaurora.org User-Agent: SquirrelMail/1.4.22-4.el6 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Mon, 22 Jun 2015, Ankit Gupta wrote: > >> Add chip name and hw-irq number to the trace_irq_handler_entry() >> tracepoint. When tracing interrupt events the chip-name and hw-irq >> numbers are stable and known in advance. This makes them a better >> choice as a filtering criteria for the trace buffer dump. On the >> flipside, the os-irq numbers are dynamically allocated which makes >> them difficult to use for the same purpose. >> >> Dump messages will look like: >> ...irq_handler_entry: irq=22 name=msm_serial0 domain=GIC hwirq=140 > > I can't see the domain name being captured/printed in the code below. > >> - TP_printk("irq=%d name=%s", __entry->irq, __get_str(name)) >> + TP_printk("irq=%d name=%s chip_name=%s hwirq=%ld", __entry->irq, >> + __get_str(name), show_chip_name(__entry->irq), >> + show_hwirq(__entry->irq)) >> ); Thanks Thomas for your comment. Its actually printing a chipname and not the domain. Will correct the dump message in the next patch. It will print as follow. ...irq_handler_entry: irq=22 name=msm_serial0 Chip=GIC hwirq=140 > > Thanks, > > tglx > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >