Re: [PATCH v4 4/4] arm64: dts: mediatek: add device tree for Tungsten 700 board

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

Il 02/12/25 23:08, Gary Bisson ha scritto:
> Add device tree to support Ezurio Tungsten 700 (MT8390) SMARC SOM [1] +
> Universal SMARC carrier board [2].
> It includes support for the MIPI-DSI BD070LIC3 display which uses the
> Tianma TM070JDHG30 panel + TI SN65DSI84 MIPI-DSI to LVDS bridge [3].
> 
> [1] https://www.ezurio.com/product/tungsten700-smarc
> [2] https://www.ezurio.com/system-on-module/accessories/universal-smarc-carrier
> [3] https://www.ezurio.com/product/bd070lic3-7-touchscreen-display
> 
> Signed-off-by: Gary Bisson <bisson.gary@gmail.com>
> 
> ---
> Changes in v2:
> - None
> Changed in v3:
> - None
> Changed in v4:
> - None
> ---
>   arch/arm64/boot/dts/mediatek/Makefile              |  1 +
>   .../boot/dts/mediatek/mt8390-tungsten-smarc.dts    | 22 ++++++++++++++++++++++
>   2 files changed, 23 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile
> index 30d169a31b10..85f338344dd3 100644
> --- a/arch/arm64/boot/dts/mediatek/Makefile
> +++ b/arch/arm64/boot/dts/mediatek/Makefile
> @@ -102,6 +102,7 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8370-genio-510-evk.dtb
>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt8370-tungsten-smarc.dtb
>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt8395-genio-1200-evk.dtb
>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt8390-genio-700-evk.dtb
> +dtb-$(CONFIG_ARCH_MEDIATEK) += mt8390-tungsten-smarc.dtb
>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt8395-kontron-3-5-sbc-i1200.dtb
>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt8395-radxa-nio-12l.dtb
>   dtb-$(CONFIG_ARCH_MEDIATEK) += mt8395-radxa-nio-12l-8-hd-panel.dtbo
> diff --git a/arch/arm64/boot/dts/mediatek/mt8390-tungsten-smarc.dts b/arch/arm64/boot/dts/mediatek/mt8390-tungsten-smarc.dts
> new file mode 100644
> index 000000000000..f1cf2821107f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/mediatek/mt8390-tungsten-smarc.dts
> @@ -0,0 +1,22 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +/*
> + * Copyright (C) 2025 Ezurio LLC
> + * Author: Gary Bisson <bisson.gary@gmail.com>
> + */
> +/dts-v1/;
> +#include "mt8188.dtsi"
> +#include "mt83x0-tungsten-smarc.dtsi"

I just noticed: please, no wildcards in names - this has to be named
mt8390-tungsten-smarc.dtsi instead.

> +
> +/ {
> +	model = "Ezurio Tungsten700 SMARC (MT8390)";
> +	compatible = "ezurio,mt8390-tungsten-smarc", "mediatek,mt8390",
> +		     "mediatek,mt8188";
> +};
> +
> +&cpu4 {
> +	cpu-supply = <&mt6359_vcore_buck_reg>;
> +};
> +
> +&cpu5 {
> +	cpu-supply = <&mt6359_vcore_buck_reg>;
> +};
> 

You could also just put the cpu4 and cpu5 supplies in the common
mt8390-tungsten-smarc.dtsi file instead.

That's based on your own preference, so..

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>