From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Alien Wesley <alienwesley51@gmail.com>,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, ~lkcamp/patches@lists.sr.ht
Subject: Re: [PATCH] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c:681
Date: Sun, 25 Aug 2024 21:44:32 +0200 [thread overview]
Message-ID: <f514b1db-154e-4450-88e9-cbfb8c66a69e@gmail.com> (raw)
In-Reply-To: <20240825161335.21737-1-alienwesley51@gmail.com>
On 8/25/24 18:13, Alien Wesley wrote:
> Separated assignments for pairwise_key_type and group_key_type
> in order to silence the following checkpatch warning.
>
> CHECK: Assignment operator '=' should be on the previous line.
>
> Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> index 47f1adf30ab4..2d42e7a5bcdb 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> @@ -677,8 +677,8 @@ static int _rtl92e_wx_set_encode_ext(struct net_device *dev,
>
> if ((encoding->flags & IW_ENCODE_DISABLED) ||
> ext->alg == IW_ENCODE_ALG_NONE) {
> - ieee->pairwise_key_type = ieee->group_key_type
> - = KEY_TYPE_NA;
> + ieee->pairwise_key_type = KEY_TYPE_NA;
> + ieee->group_key_type = KEY_TYPE_NA;
> rtl92e_cam_reset(dev);
> memset(priv->rtllib->swcamtable, 0,
> sizeof(struct sw_cam_table) * 32);
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
next prev parent reply other threads:[~2024-08-25 19:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-25 16:13 [PATCH] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c:681 Alien Wesley
2024-08-25 19:44 ` Philipp Hortmann [this message]
2024-08-29 9:52 ` Greg KH
2024-08-29 11:33 ` Alien Wesley
2024-08-29 11:39 ` Greg KH
2024-08-29 11:43 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f514b1db-154e-4450-88e9-cbfb8c66a69e@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=alienwesley51@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox