* [PATCH] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c:681
@ 2024-08-25 16:13 Alien Wesley
2024-08-25 19:44 ` Philipp Hortmann
2024-08-29 9:52 ` Greg KH
0 siblings, 2 replies; 6+ messages in thread
From: Alien Wesley @ 2024-08-25 16:13 UTC (permalink / raw)
To: gregkh, linux-staging, linux-kernel, ~lkcamp/patches
Separated assignments for pairwise_key_type and group_key_type
in order to silence the following checkpatch warning.
CHECK: Assignment operator '=' should be on the previous line.
Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
index 47f1adf30ab4..2d42e7a5bcdb 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
@@ -677,8 +677,8 @@ static int _rtl92e_wx_set_encode_ext(struct net_device *dev,
if ((encoding->flags & IW_ENCODE_DISABLED) ||
ext->alg == IW_ENCODE_ALG_NONE) {
- ieee->pairwise_key_type = ieee->group_key_type
- = KEY_TYPE_NA;
+ ieee->pairwise_key_type = KEY_TYPE_NA;
+ ieee->group_key_type = KEY_TYPE_NA;
rtl92e_cam_reset(dev);
memset(priv->rtllib->swcamtable, 0,
sizeof(struct sw_cam_table) * 32);
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c:681
2024-08-25 16:13 [PATCH] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c:681 Alien Wesley
@ 2024-08-25 19:44 ` Philipp Hortmann
2024-08-29 9:52 ` Greg KH
1 sibling, 0 replies; 6+ messages in thread
From: Philipp Hortmann @ 2024-08-25 19:44 UTC (permalink / raw)
To: Alien Wesley, gregkh, linux-staging, linux-kernel,
~lkcamp/patches
On 8/25/24 18:13, Alien Wesley wrote:
> Separated assignments for pairwise_key_type and group_key_type
> in order to silence the following checkpatch warning.
>
> CHECK: Assignment operator '=' should be on the previous line.
>
> Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> index 47f1adf30ab4..2d42e7a5bcdb 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> @@ -677,8 +677,8 @@ static int _rtl92e_wx_set_encode_ext(struct net_device *dev,
>
> if ((encoding->flags & IW_ENCODE_DISABLED) ||
> ext->alg == IW_ENCODE_ALG_NONE) {
> - ieee->pairwise_key_type = ieee->group_key_type
> - = KEY_TYPE_NA;
> + ieee->pairwise_key_type = KEY_TYPE_NA;
> + ieee->group_key_type = KEY_TYPE_NA;
> rtl92e_cam_reset(dev);
> memset(priv->rtllib->swcamtable, 0,
> sizeof(struct sw_cam_table) * 32);
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c:681
2024-08-25 16:13 [PATCH] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c:681 Alien Wesley
2024-08-25 19:44 ` Philipp Hortmann
@ 2024-08-29 9:52 ` Greg KH
2024-08-29 11:33 ` Alien Wesley
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2024-08-29 9:52 UTC (permalink / raw)
To: Alien Wesley; +Cc: linux-staging, linux-kernel, ~lkcamp/patches
On Sun, Aug 25, 2024 at 01:13:35PM -0300, Alien Wesley wrote:
> Separated assignments for pairwise_key_type and group_key_type
> in order to silence the following checkpatch warning.
>
> CHECK: Assignment operator '=' should be on the previous line.
>
> Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
Please do not put line numbers in the subject line.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c:681
2024-08-29 9:52 ` Greg KH
@ 2024-08-29 11:33 ` Alien Wesley
2024-08-29 11:39 ` Greg KH
2024-08-29 11:43 ` Dan Carpenter
0 siblings, 2 replies; 6+ messages in thread
From: Alien Wesley @ 2024-08-29 11:33 UTC (permalink / raw)
To: Greg KH; +Cc: linux-staging, linux-kernel, ~lkcamp/patches
On 8/29/24 06:52, Greg KH wrote:
> On Sun, Aug 25, 2024 at 01:13:35PM -0300, Alien Wesley wrote:
>> Separated assignments for pairwise_key_type and group_key_type
>> in order to silence the following checkpatch warning.
>>
>> CHECK: Assignment operator '=' should be on the previous line.
>>
>> Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
> Please do not put line numbers in the subject line.
>
> thanks,
>
> greg k-h
Should I fix up the subject and resend it as v2?
Alien Wesley
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c:681
2024-08-29 11:33 ` Alien Wesley
@ 2024-08-29 11:39 ` Greg KH
2024-08-29 11:43 ` Dan Carpenter
1 sibling, 0 replies; 6+ messages in thread
From: Greg KH @ 2024-08-29 11:39 UTC (permalink / raw)
To: Alien Wesley; +Cc: linux-staging, linux-kernel, ~lkcamp/patches
On Thu, Aug 29, 2024 at 08:33:41AM -0300, Alien Wesley wrote:
> On 8/29/24 06:52, Greg KH wrote:
> > On Sun, Aug 25, 2024 at 01:13:35PM -0300, Alien Wesley wrote:
> > > Separated assignments for pairwise_key_type and group_key_type
> > > in order to silence the following checkpatch warning.
> > >
> > > CHECK: Assignment operator '=' should be on the previous line.
> > >
> > > Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
> > Please do not put line numbers in the subject line.
> >
> > thanks,
> >
> > greg k-h
>
> Should I fix up the subject and resend it as v2?
Please do.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c:681
2024-08-29 11:33 ` Alien Wesley
2024-08-29 11:39 ` Greg KH
@ 2024-08-29 11:43 ` Dan Carpenter
1 sibling, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2024-08-29 11:43 UTC (permalink / raw)
To: Alien Wesley; +Cc: Greg KH, linux-staging, linux-kernel, ~lkcamp/patches
On Thu, Aug 29, 2024 at 08:33:41AM -0300, Alien Wesley wrote:
> On 8/29/24 06:52, Greg KH wrote:
> > On Sun, Aug 25, 2024 at 01:13:35PM -0300, Alien Wesley wrote:
> > > Separated assignments for pairwise_key_type and group_key_type
> > > in order to silence the following checkpatch warning.
> > >
> > > CHECK: Assignment operator '=' should be on the previous line.
> > >
> > > Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
> > Please do not put line numbers in the subject line.
> >
> > thanks,
> >
> > greg k-h
>
> Should I fix up the subject and resend it as v2?
Yes.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-08-29 11:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-25 16:13 [PATCH] staging: rtl8192e: Fix Assignment operator '=' in rtl_wx.c:681 Alien Wesley
2024-08-25 19:44 ` Philipp Hortmann
2024-08-29 9:52 ` Greg KH
2024-08-29 11:33 ` Alien Wesley
2024-08-29 11:39 ` Greg KH
2024-08-29 11:43 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox