From: Oreste Salerno <oreste.salerno@tomtom.com>
To: <linux-kernel@vger.kernel.org>
Cc: <linux-input@vger.kernel.org>, <fery@cypress.com>,
<dmitry.torokhov@gmail.com>, <robh+dt@kernel.org>,
<pawel.moll@arm.com>, <mark.rutland@arm.com>,
<ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
<devicetree@vger.kernel.org>, <oreste.salerno@tomtom.com>
Subject: [PATCH v5 4/4] Input: cyttsp - perform hard reset of the chip during probe
Date: Thu, 21 Jan 2016 23:21:32 +0100 [thread overview]
Message-ID: <f5311f917c21caf5ba0cb8cca8220c43f46f0d0c.1453414661.git.oreste.salerno@tomtom.com> (raw)
In-Reply-To: <cover.1453414661.git.oreste.salerno@tomtom.com>
Since we removed support for calling an init() callback from
the platform data, introduce a function which initializes
the chip by performing a hard reset, using the reset gpio
defined in the device properties.
Signed-off-by: Oreste Salerno <oreste.salerno@tomtom.com>
---
drivers/input/touchscreen/cyttsp_core.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/input/touchscreen/cyttsp_core.c b/drivers/input/touchscreen/cyttsp_core.c
index d91668d..0fd0956 100644
--- a/drivers/input/touchscreen/cyttsp_core.c
+++ b/drivers/input/touchscreen/cyttsp_core.c
@@ -240,6 +240,16 @@ static int cyttsp_set_sysinfo_regs(struct cyttsp *ts)
return retval;
}
+static void cyttsp_hard_reset(struct cyttsp *ts)
+{
+ if (ts->reset_gpio) {
+ gpiod_set_value_cansleep(ts->reset_gpio, 1);
+ msleep(CY_DELAY_DFLT);
+ gpiod_set_value_cansleep(ts->reset_gpio, 0);
+ msleep(CY_DELAY_DFLT);
+ }
+}
+
static int cyttsp_soft_reset(struct cyttsp *ts)
{
unsigned long timeout;
@@ -663,6 +673,8 @@ struct cyttsp *cyttsp_probe(const struct cyttsp_bus_ops *bus_ops,
disable_irq(ts->irq);
+ cyttsp_hard_reset(ts);
+
error = cyttsp_power_on(ts);
if (error)
return ERR_PTR(error);
--
1.9.1
next prev parent reply other threads:[~2016-01-21 22:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 22:21 [PATCH v5 0/4] Add device tree support to the cyttsp driver Oreste Salerno
2016-01-21 22:21 ` [PATCH v5 1/4] Input: cyttsp - use devres managed resource allocations Oreste Salerno
2016-01-21 22:21 ` [PATCH v5 2/4] Input: cyttsp - check return value of input_mt_init_slots Oreste Salerno
2016-01-21 22:21 ` [PATCH v5 3/4] Input: cyttsp - switch to using device properties Oreste Salerno
2016-01-22 22:37 ` Rob Herring
2016-01-21 22:21 ` Oreste Salerno [this message]
2016-01-27 22:36 ` [PATCH v5 0/4] Add device tree support to the cyttsp driver Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f5311f917c21caf5ba0cb8cca8220c43f46f0d0c.1453414661.git.oreste.salerno@tomtom.com \
--to=oreste.salerno@tomtom.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fery@cypress.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).