From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8230353EF7 for ; Thu, 30 Apr 2026 21:21:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777584086; cv=none; b=kb3z5XbRaRCTiJF/XNEeDvRaxKZqHyX4vOscB+APOPwQYo2Olvcg9DinRdCk//CfJAatn/wAYPx8xLMk5rxH7z//NfTh7rz6DWVd2nKEQwHc4NhGxAFL18Pa7xJl86iF+CyuinWC/Xxf4AatCruIrKx+p22LDkq7W1wG01cFB0Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777584086; c=relaxed/simple; bh=spLgIvn0NH4l49cxYbH/NFY98s5AJjP+mD6xfK1Zc/w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TY5Pwj5ltjZ0bIZJKPng34cAnwLxbeNKJPtxZYbv/rxZZpWtBkfDlDc3s5Fu6030VlAjkI2MpFKTwPBw4xTr0nULvgUkMIlDSvY4nGSzLbSbO6byIibM7iYc1PHUNckhqwJa+2ZZ4V93ZWYlTfDnt03XCUUqBfm6YJpeJuSMzqM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=YjqpXQm+; arc=none smtp.client-ip=209.85.210.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="YjqpXQm+" Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-7de4e6c5a30so1169478a34.0 for ; Thu, 30 Apr 2026 14:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1777584082; x=1778188882; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DKXekugmcxOxqshMkbgYf6EhJCvVkmbBw/dLn2Qsiy4=; b=YjqpXQm+lOgSpXw1Xpi2gYxH9/ZDKK3Li2WvV0Fp+3a1EhOJ4h4plwqzGp/dPMd+fv cNZbGeSl5wMPDip3p+NQV6rs5U6nh/XOTZBx+BKQ/clCOxJkl8LOFFOkkfQo+jRIsHQM dp8yUc8GqoRDsPrWrcN3Bb9AU68NEd+JdpDMQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777584082; x=1778188882; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DKXekugmcxOxqshMkbgYf6EhJCvVkmbBw/dLn2Qsiy4=; b=R5CgwExEASk8qD/5BS77+87eQ8BR8kJOLylL3YAqa/FEu4XVeT4PDGST9HN0m8socq 2WbrZc7HG/OzsIBeFw9IB541RGVARJAQZL7aegIXw9hbgvXn+TiiY8yPtBL6dixZR8VN IfHV7KM0hJgSt8MefUoKTc+1/XYT/2+g5dpHKfbbQLlE1euNE2FhO8PPP+OVKbeoblL3 f7xpjnLgvl+mJ5MfRjTBVGXlJAzacs0CVhq2YfUwcuEIc4Vj1m+Z3WSAGeYpaC0pzwRt Ye+x0Y2mJzp+jU1KUPtaIE4TVdLRQNDVnhzvIYK+PH8nPynFVwvw1mtK81MgBEMSepi8 pMhw== X-Forwarded-Encrypted: i=1; AFNElJ+s/8VqMlWy33A4PaZoEpIhF3X8d5yaxbx8qdbqT5zDa53Sxx0RwgFRovV8xTHIHJOggB2JMtkQs7olc2Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwVv0puDK/tMg7ud9x1Lf/ULick6oIJgNv0DVkMjjLzFJsqz4sy CQ6k71wfAmnbPZhXSLOSo0AKKAPMkOJRjfWlSa4JoLrmY8uLSBnnc/2+bj1RtkAmK9k= X-Gm-Gg: AeBDievKsUMbiYOQ5YeT6xoKFYJHRJBzco0m/mJYZwZHAPPV7ggOlicueg9uWd5vgxX V+DZnqGpiSUI/W08+NH/ZHlkhUuTw8eeHb1RxGnTyidabJMcpBV+G+60UW4sVz9kSChj5nnlv/A 1dIxt+E46Z2PmaZj+pJxzlART25w2moHjpWJXT6qNEH3tkEEY1kj0gF6MqQoDoTy3EpZrvKMOOe i3nVDQmWIV49dil6puHUXCfJkKbtCukN8xqMlgzUThtsWBZGQN9RD4vN6TbsB9qpn0jhFrOkH++ mAOZXcw3T9II0uP0Pqb0eYJ/l6/3K6MVI+UJkxWB6MRiz5hqJDjneVN/UoJym5o6dOlXNsc0cff f9r7eOIxwEzysO0TSUn1jrpvYJr040PVl2HZbOYKghW3Qb2Jl13fIh46u6rS4AXkFQhGCW/HyDM BM+7OSHg7FyTI01+jLfsEJ9K1oJ+n+VIOb01D4t8Naiw== X-Received: by 2002:a05:6830:2b22:b0:7d9:7209:4378 with SMTP id 46e09a7af769-7deba2a151cmr2957885a34.17.1777584081679; Thu, 30 Apr 2026 14:21:21 -0700 (PDT) Received: from [192.168.1.14] ([38.15.57.99]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7decac8ef53sm713592a34.21.2026.04.30.14.21.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2026 14:21:21 -0700 (PDT) Message-ID: Date: Thu, 30 Apr 2026 15:21:20 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] selftests: runner: Avoid spurious warning about missing failures file To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= Cc: Yohei Kojima , Shuah Khan , Brendan Jackman , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260224-kselftest-fix-failures-file-v2-1-2bfb8f5cb6a8@linutronix.de> <4915db6e-5bcf-4f70-b510-693f5d5b8678@linuxfoundation.org> <20260429131021-f3cf0fba-0944-4a58-a69c-34df628c42d7@linutronix.de> Content-Language: en-US From: Shuah Khan In-Reply-To: <20260429131021-f3cf0fba-0944-4a58-a69c-34df628c42d7@linutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/29/26 05:12, Thomas Weißschuh wrote: > On Mon, Apr 27, 2026 at 10:20:43AM -0600, Shuah Khan wrote: >> On 4/22/26 08:51, Shuah Khan wrote: >>> On 4/9/26 07:38, Yohei Kojima wrote: >>>> On Tue, Feb 24, 2026 at 04:37:56PM +0100, Thomas Weißschuh wrote: >>>>> When runner.sh is *not* executed via run_kselftest.sh, the variable >>>>> $kselftest_failures_file does not exist. This triggers a harmless but >>>>> annyoing warning from runner.sh if a test fails: >>>>> >>>>> tools/testing/selftests/kselftest/runner.sh: line 50: : No such file or directory >>>>> >>>>> Silence the spurious warning. >>>>> >>>>> Fixes: d9e6269e3303 ("selftests/run_kselftest.sh: exit with error if tests fail") >>>>> Signed-off-by: Thomas Weißschuh >>>>> Reviewed-By: Brendan Jackman >>>> >>>> Hi all, >>>> >>>> It seems this patch hasn't been picked up yet, although it already got >>>> reviewed by Brendan. This bug is also mentioned by a netdev maintainer >>>> and several developers [1], so I think it would be nice to have this >>>> patch merged. >>>> >>>> [1]: https://lore.kernel.org/lkml/20260112135326.7ce71119@kernel.org/ >>>> >>>> I confirmed that it still applies to 7.0-rc7. I also tested it by adding >>>> a failing test to net and namespaces selftests, and confirmed that the >>>> error disappeared. >>>> >>>> Tested-by: Yohei Kojima >>>> >>> >>> Sorry for the delay. >>> >>> It disappeared in my Inbox - I will pick this up for Linux 7.1-rc2 >> >> Please rebase on Linux 7.1-rc1 and send it to me? > > This actually doesn't seem to be necessary anymore since commit 2964f6b816c2 > ("selftests: Use ktap helpers for runner.sh"). So let's drop it. > > Thanks for confirming. -- Shuah