public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Julian Pellico <jpellico@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: bug in smbfs source code?
Date: Mon, 20 Dec 2004 18:16:01 -0800	[thread overview]
Message-ID: <f537fb070412201816662ca65d@mail.gmail.com> (raw)

Hi,

I've been looking over the smbfs kernel code with someone at work and
he thinks there might be a bug.

In fs/smbfs/proc.c function smb_build_path (I won't give exact line
numbers 'cause I'm looking at 2.5.6), the first call of the form:

len = server->ops->convert(path, maxlen-2, 
				      entry->d_name.name, entry->d_name.len,
				      server->local_nls, server->remote_nls);

We think that maxlen-2 should be
maxlen - (2 << unicode)

Does anyone agree?

Thanks,
Julian

                 reply	other threads:[~2004-12-21  2:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f537fb070412201816662ca65d@mail.gmail.com \
    --to=jpellico@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox