From: Dipen Patel <dipenp@nvidia.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
timestamp@lists.linux.dev, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: dan.carpenter@linaro.org, kernel-janitors@vger.kernel.org,
error27@gmail.com
Subject: Re: [PATCH] hte: tegra: Fix missing error code in tegra_hte_test_probe()
Date: Thu, 26 Oct 2023 16:04:56 -0700 [thread overview]
Message-ID: <f545e695-d838-ec28-d319-e4e9a885f8cf@nvidia.com> (raw)
In-Reply-To: <20231026075328.996704-1-harshit.m.mogalapalli@oracle.com>
On 10/26/23 12:53 AM, Harshit Mogalapalli wrote:
> The value of 'ret' is zero when of_hte_req_count() fails to get number
> of entitties to timestamp. And returning success(zero) on this failure
> path is incorrect.
>
> Fixes: 9a75a7cd03c9 ("hte: Add Tegra HTE test driver")
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
> ---
> This is found using static analysis with smatch, only compile tested.
> ---
> drivers/hte/hte-tegra194-test.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hte/hte-tegra194-test.c b/drivers/hte/hte-tegra194-test.c
> index ba37a5efbf82..ab2edff018eb 100644
> --- a/drivers/hte/hte-tegra194-test.c
> +++ b/drivers/hte/hte-tegra194-test.c
> @@ -153,8 +153,10 @@ static int tegra_hte_test_probe(struct platform_device *pdev)
> }
>
> cnt = of_hte_req_count(hte.pdev);
> - if (cnt < 0)
> + if (cnt < 0) {
> + ret = cnt;
> goto free_irq;
> + }
>
> dev_info(&pdev->dev, "Total requested lines:%d\n", cnt);
>
Reviewed-by: Dipen Patel <dipenp@nvidia.com>
prev parent reply other threads:[~2023-10-26 23:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 7:53 [PATCH] hte: tegra: Fix missing error code in tegra_hte_test_probe() Harshit Mogalapalli
2023-10-26 23:04 ` Dipen Patel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f545e695-d838-ec28-d319-e4e9a885f8cf@nvidia.com \
--to=dipenp@nvidia.com \
--cc=dan.carpenter@linaro.org \
--cc=error27@gmail.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=jonathanh@nvidia.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=timestamp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox