From: kgunda@codeaurora.org
To: Shawn Guo <shawnguo@kernel.org>
Cc: gregkh@linuxfoundation.org, sboyd@codeaurora.org,
Abhijeet Dharmapurikar <adharmap@codeaurora.org>,
David Collins <collinsd@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH V2 11/12] spmi: pmic-arb: add support for HW version 5
Date: Fri, 18 Aug 2017 16:50:27 +0530 [thread overview]
Message-ID: <f57b973e7c87bcd9bf7f512a00977d27@codeaurora.org> (raw)
In-Reply-To: <1ce6e8a0816d6d9b0ade86d3592b4dca@codeaurora.org>
On 2017-08-18 16:43, kgunda@codeaurora.org wrote:
> On 2017-08-17 17:58, Shawn Guo wrote:
>> On Thu, Aug 17, 2017 at 03:38:30PM +0530, kgunda@codeaurora.org wrote:
>>> The intention of this check is to avoid the access to the
>>> peripherals those are
>>> not owned by the current EE (APSS) and it is expected to return a
>>> failure if the
>>> peripheral that is not owned by the current EE is trying to be
>>> accessed.
>>
>> Thanks for the background of this check.
>>
>>> Looks like you trying to access the GPIOs 0xc000 and 0xc100,
>>> which are owned by modem subsystem but not the APSS. That is why you
>>> seeing the failure for that.
>>> Please change the ownership of those GPIOs to APSS (id '0') if you
>>> are working on a non-modem device (APQ).
>>
>> Yes, it's device apq8016-sbc, and the error message is like below.
>>
>> [ 1.317186] spmi spmi-0: PMIC arbiter version v2 (0x20010000)
>> [ 1.324784] spmi spmi-0: failed to xlate sid = 0x0, periph = 0xc0,
>> irq = 0: ee=0 but owner=2
>> [ 1.329430] spmi spmi-0: failed to xlate sid = 0x0, periph = 0xc0,
>> irq = 0: ee=0 but owner=2
>> [ 1.337626] qcom-spmi-gpio: probe of
>> 200f000.spmi:pm8916@0:gpios@c000 failed with error -22
>>
>> I see that 'qcom,ee' property of spmi_bus is already <0>. Is that
>> what
>> you mean by ownership of those GPIOs?
>>
I do not mean that. The SPMI arbiter ownership register is programmed by
the boot-loader,
where the actual ownership is set. The same is shown in the above logs
as owner = 2.
>> The pm8916_gpio is working fine on apq8016-sbc device with the current
>> mainline kernel. It's not good to break the existing device without
>> a very good. IMO, we should get this fixed before the patch is
>> merged.
>>
>> Shawn
>> --
>
> From the logs the ownership for these GPIOs is not assigned to the
> application processor but to another master. Considering this is a
> (apq8016-sbc) APSS only platform ideally the fix for this would be to
> update the ownership table in the boot loader. The other option would
> be to make the existing ownership check in SW optional for a platform
> via DT. I will push a patch shortly for this. Could you please give
> that a try.
>
> Thanks,
> Kiran
>> To unsubscribe from this list: send the line "unsubscribe
>> linux-arm-msm" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-08-18 11:20 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-28 7:10 [PATCH V2 00/12]: spmi: pmic-arb: Support for HW v5 and other fixes Kiran Gunda
2017-07-28 7:10 ` [PATCH V2 01/12] spmi: pmic-arb: remove the read/write access checks Kiran Gunda
2017-07-28 7:10 ` [PATCH V2 02/12] spmi: pmic-arb: rename pa_xx to pmic_arb_xx and other cleanup Kiran Gunda
2017-07-28 7:10 ` [PATCH V2 03/12] spmi: pmic-arb: clean up pmic_arb_find_apid function Kiran Gunda
2017-07-28 7:10 ` [PATCH V2 04/12] spmi: pmic-arb: optimize qpnpint_irq_set_type function Kiran Gunda
2017-07-28 7:10 ` [PATCH V2 05/12] spmi: pmic-arb: fix memory allocation for mapping_table Kiran Gunda
2017-07-28 7:10 ` [PATCH V2 06/12] spmi: pmic-arb: replace the writel_relaxed with __raw_writel Kiran Gunda
2017-07-28 7:10 ` [PATCH V2 07/12] spmi: pmic-arb: return the value instead of passing by pointer Kiran Gunda
2017-07-28 7:10 ` [PATCH V2 08/12] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability Kiran Gunda
2017-07-28 7:10 ` [PATCH V2 09/12] spmi: pmic-arb: return __iomem pointer instead of offset Kiran Gunda
2017-07-28 7:10 ` [PATCH V2 10/12] spmi: pmic-arb: fix a possible null pointer dereference Kiran Gunda
2017-07-28 7:10 ` [PATCH V2 11/12] spmi: pmic-arb: add support for HW version 5 Kiran Gunda
2017-08-17 7:41 ` Shawn Guo
2017-08-17 10:08 ` kgunda
2017-08-17 12:28 ` Shawn Guo
2017-08-18 11:13 ` kgunda
2017-08-18 11:20 ` kgunda [this message]
2017-08-18 13:22 ` Shawn Guo
2017-07-28 7:10 ` [PATCH V2 12/12] spmi: pmic-arb: Remove checking opc value not less than 0 Kiran Gunda
2017-08-01 4:55 ` [PATCH V2 00/12]: spmi: pmic-arb: Support for HW v5 and other fixes kgunda
2017-08-01 18:07 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f57b973e7c87bcd9bf7f512a00977d27@codeaurora.org \
--to=kgunda@codeaurora.org \
--cc=adharmap@codeaurora.org \
--cc=collinsd@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).