From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE235383C9D for ; Tue, 14 Apr 2026 21:16:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776201374; cv=none; b=TD+scz+KnaTuRcOxyYiZyzEKJmYfdOo0Yub5LWG5YKCM7IvqMJc8ptvOC5mFjkb0KdqupAkaDOmt7sdx6wWBXTmzqYgwzP/imNjub0n1hsDWW6PvSk9Bwdp7JFktXufHo5u3zby6Pssmi9QffXcWe8O61vBlqyrbw3yh1hC9SEM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776201374; c=relaxed/simple; bh=Q4INpfKWk7mxaKmB7Uf/Gsp8EUYR21VjlgB0GxYGYxY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Y7vUy2hTHZYjVacTEkCRuN9Pu8fKvATvRaAAhhkxOUB4eNHK9F+26eanQoMHIODoS87nw8JdaN8SQY1aR+wXrWhuXkfE9HLNwxaRomDYW7CX2Y0lg/b0Fb/ggBabO9NV7FnvVmaEJ6bA8GjqkmnB5S6/NO3d9pXQ+GbFUztC2jI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DRxHPQJ/; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=J9lxTJWC; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DRxHPQJ/"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="J9lxTJWC" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776201371; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/TyCH9SMWGwZ0uzhcSuuZUtHYH+vVfCSIhLbgFrzZ0M=; b=DRxHPQJ/egnDVZbt6XKWNNLG1BbnzW1GdqsMHeHUFANNXTUDfOnJUiW+veSzlWqIJkf5Ww v7Rw0DesC/OiDbo8HvQnqdk5Hp2iCIaYaC1OLmHM47fftvqvmZ2TWWxkBdANqFny60DZNy Npv6WEw0a3CvQX4gwn4I9dGCo4v7kYo= Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-269-_mWLAtThPnK0ndhYa-XcAQ-1; Tue, 14 Apr 2026 17:16:10 -0400 X-MC-Unique: _mWLAtThPnK0ndhYa-XcAQ-1 X-Mimecast-MFC-AGG-ID: _mWLAtThPnK0ndhYa-XcAQ_1776201370 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-79cfec4344cso106040227b3.2 for ; Tue, 14 Apr 2026 14:16:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1776201369; x=1776806169; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=/TyCH9SMWGwZ0uzhcSuuZUtHYH+vVfCSIhLbgFrzZ0M=; b=J9lxTJWCRQDDhyiUkupzn8cMYvHVLAIBJlqClJPQwUpBcOkvzVQ4v53F/2CZupa84/ 7Hxw2slVx3GtFOJnZ8VhNa6WMJ1AiTn48KHGHFz+xP2k9wjdh5ItkPv5bQnvvQRdNsS3 55l4UdKPKvcB00mnswsJet7PmXfa/trkGSHxzViBiP2GcIo2MOWmnxD+dtFpTq3ksVmz mruVOSb60blj4noEyfD/OgNxNgJ3NkVNSt/m747LUvyruomgrzPlZV2aJChKWZeLF52C N5Xpjj3pvcm52mo7cI5KXf/NUxDVL+k1PRVeyaZUqV0Ckyum7ScPLqvDCjYNtt7YKFMV Euyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776201369; x=1776806169; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/TyCH9SMWGwZ0uzhcSuuZUtHYH+vVfCSIhLbgFrzZ0M=; b=ToWV+tqh9zeaWfaRba9+S5ApbczcIUzEOBTT3FQwtQVDdfSfmq+Z5OtVQyV8Xb2618 65Sv+d1hA0A/kZduN4Jowi05MjvfCafyD6Z3lbVJhLXeeb5e6bzLCB/3itPRzUd9h/3p o+Fj/e2AJrPJUwzvUwPPSh39p7RbkRiTNp9cqrdTphSlhXsJNfShsdGLZRn8OGzTSd81 IRlhyEw5iGgQoL5PURgDfYGxyR3XL4EE4qiGxqSe7KmiLkv8YCf/wuXIm128JJKRltge p9CKvPy/csOJJpwFm2UxTNnjOcbO1pq2a/thJ7NYJLsPUNjL3zaWHVZIp4i1kw2X4IcP NB3A== X-Forwarded-Encrypted: i=1; AFNElJ+F7I+GkZqpwHnoQS6wM4X2VMF0cJvABBj+Mj0+MnpS3MALbpl7WANZkJ+WexcYTJXE1NicJF2vL+cR/aw=@vger.kernel.org X-Gm-Message-State: AOJu0YwYM0eqpiQosiUC/dMrY+j1MzXumQw+byAoqnhCzc8xkq1w12Zr B2rxrYSeXEdJ9jBMzvttESAtCxbxovyK/cCeywbd+d95PcoGl/vQ/pHuhjMYKpjfDEZdBGEoY/K Qy4ANjDMrMorfCTf+ffCC+NCvvcNE4wVuHLXeCJcBqBLTSunRQGWsTxbYKh7f5JTYcBknKymagw == X-Gm-Gg: AeBDietaE+ukgPaV7Rwf8OYJ6FCmxUsC4jknA9TJdvIC4Nk+vDsE1WaycKBRGUV/5oa eSbjH6WoM3ow1kJxAXP3bxj3gvtH/dFwWIrDjfq4XHm4ypl853hHsbwCUjqz3E1C/X6qqoRC9sL IzXs1ZP6mLn3yT0hIyvSq2uWebnpyjLXk9VujN1nL6Skqyj6cCi8Qu4KFrQakjLnUuUZ8/0qida K/AG5a3oaqFWz4G2mxX4/FbGGXgyN4iu5wqkoD1B3klUB6TWygB5O+GN8kUGbr+WQq4WuBR4HSN nLzNuhfZotKd1LRvr3/z9w+P/dBC+s2Jvw4+GF5Wg7Las6/f9KCtBYJaxGEfn//Y/TaZzAWeD0H BCzj917eTTge8ONf7dZgPuuWT4X6bgBi4s4Rh2g1vr8tV2lpWkbmrsrM3Jj4qeNI= X-Received: by 2002:a05:690c:c1cc:b0:7a1:a31a:bfce with SMTP id 00721157ae682-7af715776famr166038027b3.32.1776201365715; Tue, 14 Apr 2026 14:16:05 -0700 (PDT) X-Received: by 2002:a05:690c:c1cc:b0:7a1:a31a:bfce with SMTP id 00721157ae682-7af715776famr166037817b3.32.1776201365354; Tue, 14 Apr 2026 14:16:05 -0700 (PDT) Received: from li-4c4c4544-0032-4210-804c-c3c04f423534.ibm.com ([2600:1700:6476:1430::29]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7af3d1c07absm73967887b3.19.2026.04.14.14.16.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Apr 2026 14:16:04 -0700 (PDT) Message-ID: Subject: Re: [PATCH] hfsplus: remove xattr error message From: Viacheslav Dubeyko To: "Colin King (gmail)" , Viacheslav Dubeyko , John Paul Adrian Glaubitz , Yangtao Li , linux-fsdevel@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Tue, 14 Apr 2026 14:16:03 -0700 In-Reply-To: <4a6a9ef3-cfa1-46df-bf82-d083ef30041a@gmail.com> References: <20260411125338.165758-1-colin.i.king@gmail.com> <4a6a9ef3-cfa1-46df-bf82-d083ef30041a@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.3 (3.58.3-1.fc43app2) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2026-04-14 at 21:19 +0100, Colin King (gmail) wrote: > On 13/04/2026 18:12, Viacheslav Dubeyko wrote: > > On Sat, 2026-04-11 at 13:53 +0100, Colin Ian King wrote: > > > When exercising hfsplus with the stress-ng xattr stressor a large > > > quantity of somewhat unhelpful error messages "hfsplus: xattr exists > > > yet" spam the kernel log. Remove these. > >=20 > > We can convert it into hfs_dbg() and to add showing inode ID + name. Wh= at do you > > think? >=20 > Yes, that's a good idea. Perhaps the phrase "xattr exists yet" can be=20 > rephrased as the message is not really that clear. Any ideas for an=20 > improved message? Maybe, "unable to recreate the existing xattr"? Thanks, Slava. >=20 > Colin >=20 > >=20 > > Also, there are other pr_err() in xattr code that can be converted into > > hfs_dbg(). Could you please take a look into other ones too? > >=20 > > Thanks, > > Slava. > >=20 > > >=20 > > > Signed-off-by: Colin Ian King > > > --- > > > fs/hfsplus/xattr.c | 2 -- > > > 1 file changed, 2 deletions(-) > > >=20 > > > diff --git a/fs/hfsplus/xattr.c b/fs/hfsplus/xattr.c > > > index c70bb6f494b2..e10e1d8a5862 100644 > > > --- a/fs/hfsplus/xattr.c > > > +++ b/fs/hfsplus/xattr.c > > > @@ -301,7 +301,6 @@ int __hfsplus_setxattr(struct inode *inode, const= char *name, > > > =20 > > > if (!strcmp_xattr_finder_info(name)) { > > > if (flags & XATTR_CREATE) { > > > - pr_err("xattr exists yet\n"); > > > err =3D -EOPNOTSUPP; > > > goto end_setxattr; > > > } > > > @@ -348,7 +347,6 @@ int __hfsplus_setxattr(struct inode *inode, const= char *name, > > > =20 > > > if (hfsplus_attr_exists(inode, name)) { > > > if (flags & XATTR_CREATE) { > > > - pr_err("xattr exists yet\n"); > > > err =3D -EOPNOTSUPP; > > > goto end_setxattr; > > > } > >=20